[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #601: Fix Parquet with special characters in field names.

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #601: Fix Parquet with special characters in field names.
URL: https://github.com/apache/incubator-iceberg/pull/601#discussion_r341744682
 
 

 ##########
 File path: core/src/main/java/org/apache/iceberg/avro/AvroSchemaUtil.java
 ##########
 @@ -347,6 +347,13 @@ static Schema copyRecord(Schema record, List<Schema.Field> newFields, String new
     return copy;
   }
 
+  public static String makeCompatibleName(String name) {
 
 Review comment:
   I considered it, but the `isValidFieldName` is reused to add the original name as a property, so I think it's fine as it is.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org