You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/10/21 16:59:32 UTC
[GitHub] [kafka] vvcephei opened a new pull request #9471: MINOR: Add Jenkinsfile to 2.6
vvcephei opened a new pull request #9471:
URL: https://github.com/apache/kafka/pull/9471
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jolshan commented on pull request #9471: MINOR: Add Jenkinsfile to 2.6
Posted by GitBox <gi...@apache.org>.
jolshan commented on pull request #9471:
URL: https://github.com/apache/kafka/pull/9471#issuecomment-714684198
@vvcephei Yeah. I was worried that might be happening. Good to check
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vvcephei commented on pull request #9471: MINOR: Add Jenkinsfile to 2.6
Posted by GitBox <gi...@apache.org>.
vvcephei commented on pull request #9471:
URL: https://github.com/apache/kafka/pull/9471#issuecomment-714674113
On second thought, it looks like there's legitimately a test that hangs on 2.6 in java 11.
I was looking before at the whole log, which I didn't realize shows all the builds and tests in one file.
Here are the logs for just the java 11 build on both runs:
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-9471/1/execution/node/85/log/
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-9471/2/execution/node/86/log/
It clearly gets stuck about 35 minutes in. I'm attempting a local repro.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vvcephei commented on pull request #9471: MINOR: Add Jenkinsfile to 2.6
Posted by GitBox <gi...@apache.org>.
vvcephei commented on pull request #9471:
URL: https://github.com/apache/kafka/pull/9471#issuecomment-714569139
The tests for 8 and 14 passed, but 11 timed out. Weirdly, the build log (https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-9471/1/console) actually shows that the tests passed after just under 2 hours, and then it looks like it got hung up "recording the results".
Re-running now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vvcephei merged pull request #9471: MINOR: Add Jenkinsfile to 2.6
Posted by GitBox <gi...@apache.org>.
vvcephei merged pull request #9471:
URL: https://github.com/apache/kafka/pull/9471
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vvcephei commented on pull request #9471: MINOR: Add Jenkinsfile to 2.6
Posted by GitBox <gi...@apache.org>.
vvcephei commented on pull request #9471:
URL: https://github.com/apache/kafka/pull/9471#issuecomment-713719243
@ijuma @jolshan @mumrah , are any of you able to review this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vvcephei commented on pull request #9471: MINOR: Add Jenkinsfile to 2.6
Posted by GitBox <gi...@apache.org>.
vvcephei commented on pull request #9471:
URL: https://github.com/apache/kafka/pull/9471#issuecomment-718826291
Ok, I've run it a total of 5 times now, and it has passed two times and timed out three times.
I did some analysis on the timed out logs, and found that every test that started either passed or got skipped. I was hoping to find a test that hung, but no luck.
For example, I downloaded the logs for run 1, which timed out as `timeout-1.txt`:
```bash
[john@arcturus Downloads]$ cat timeout-1.txt | grep STARTED | sed 's|^\[\S*] ||' | sed 's/ STARTED//' | sort > /tmp/1-started
[john@arcturus Downloads]$ cat timeout-1.txt | grep PASSED | sed 's|^\[\S*] ||' | sed 's/ PASSED//' | sort > /tmp/1-passed
[john@arcturus Downloads]$ cat timeout-1.txt | grep SKIPPED | sed 's|^\[\S*] ||' | sed 's/ SKIPPED//' | sort > /tmp/1-skipped
[john@arcturus Downloads]$ wc -l /tmp/1-skipped /tmp/1-passed
61 /tmp/1-skipped
10891 /tmp/1-passed
10952 total
[john@arcturus Downloads]$ wc -l /tmp/1-started
10952 /tmp/1-started
```
Since all the other builds in all the other branches are working with effectively the same Jenkinsfile, I'm deeply suspicious that there actually is something wrong with the 2.6 codebase and not this PR itself.
I think we should go ahead and merge this in some form. I could see:
1. Just merge this as-is and file a Jira ticket to investigate why java 11 builds time out on 2.6.
2. Exclude java 11 from the jenkinsfile and go ahead and merge with just java 8 and 14.
WDYT, @omkreddy @jolshan @ijuma ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vvcephei commented on pull request #9471: MINOR: Add Jenkinsfile to 2.6
Posted by GitBox <gi...@apache.org>.
vvcephei commented on pull request #9471:
URL: https://github.com/apache/kafka/pull/9471#issuecomment-717986480
Weird; it looks like the 3rd build ran fine. I'm running it again, just to be sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vvcephei commented on pull request #9471: MINOR: Add Jenkinsfile to 2.6
Posted by GitBox <gi...@apache.org>.
vvcephei commented on pull request #9471:
URL: https://github.com/apache/kafka/pull/9471#issuecomment-714776458
So far, I have not been able to reproduce it. I even re-ran the exact same command as Jenkins:
```
[john@arcturus kafka]$ javac -version
javac 11.0.8
[john@arcturus kafka]$ ./gradlew -PscalaVersion=2.13 unitTest integrationTest --profile --no-daemon --continue -PtestLoggingEvents=started,passed,skipped,failed -PignoreFailures=true -PmaxParallelForks=2 -PmaxTestRetries=1 -PmaxTestRetryFailures=5
...
BUILD SUCCESSFUL in 1h 20m 15s
144 actionable tasks: 59 executed, 85 up-to-date
See the profiling report at: file:///home/confluent/kafka/build/reports/profile/profile-2020-10-22-14-21-43.html
A fine-grained performance profile is available: use the --scan option.
```
Not sure where to go from here...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jolshan commented on pull request #9471: MINOR: Add Jenkinsfile to 2.6
Posted by GitBox <gi...@apache.org>.
jolshan commented on pull request #9471:
URL: https://github.com/apache/kafka/pull/9471#issuecomment-713724055
Looks like the right configurations are added to me. Might want to get one more pair of eyes and make sure the tests run.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org