You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Tomoe Sugihara <to...@midokura.com> on 2012/07/30 08:53:36 UTC
Review Request: Fix typo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6200/
-----------------------------------------------------------
Review request for cloudstack.
Description
-------
Fix typo
Agent would fail to run correctly as com.cloud.utils.script.Script#findScript
looks for "paths.script" instead of "paths.scripts".
Signed-off-by: Tomoe Sugihara <to...@midokura.com>
Diffs
-----
agent/conf/environment.properties.in 7fcf570538fdc7de0e9b180ba1d35897c2001f3f
Diff: https://reviews.apache.org/r/6200/diff/
Testing
-------
tested with cloud-agent deb package
Thanks,
Tomoe Sugihara
Re: Review Request: Fix typo
Posted by Tomoe Sugihara <to...@midokura.com>.
> On July 30, 2012, 3:27 p.m., John Kinsella wrote:
> > Tomoe - is there a bug filed for this? If not, can you create one?
Sure. Done: http://bugs.cloudstack.org/browse/CS-15776
- Tomoe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6200/#review9592
-----------------------------------------------------------
On July 30, 2012, 6:53 a.m., Tomoe Sugihara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6200/
> -----------------------------------------------------------
>
> (Updated July 30, 2012, 6:53 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Fix typo
>
> Agent would fail to run correctly as com.cloud.utils.script.Script#findScript
> looks for "paths.script" instead of "paths.scripts".
>
> Signed-off-by: Tomoe Sugihara <to...@midokura.com>
>
>
> Diffs
> -----
>
> agent/conf/environment.properties.in 7fcf570538fdc7de0e9b180ba1d35897c2001f3f
>
> Diff: https://reviews.apache.org/r/6200/diff/
>
>
> Testing
> -------
>
> tested with cloud-agent deb package
>
>
> Thanks,
>
> Tomoe Sugihara
>
>
Re: Review Request: Fix typo
Posted by John Kinsella <jl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6200/#review9592
-----------------------------------------------------------
Tomoe - is there a bug filed for this? If not, can you create one?
- John Kinsella
On July 30, 2012, 6:53 a.m., Tomoe Sugihara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6200/
> -----------------------------------------------------------
>
> (Updated July 30, 2012, 6:53 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Fix typo
>
> Agent would fail to run correctly as com.cloud.utils.script.Script#findScript
> looks for "paths.script" instead of "paths.scripts".
>
> Signed-off-by: Tomoe Sugihara <to...@midokura.com>
>
>
> Diffs
> -----
>
> agent/conf/environment.properties.in 7fcf570538fdc7de0e9b180ba1d35897c2001f3f
>
> Diff: https://reviews.apache.org/r/6200/diff/
>
>
> Testing
> -------
>
> tested with cloud-agent deb package
>
>
> Thanks,
>
> Tomoe Sugihara
>
>
Re: Review Request: Fix typo
Posted by Wido den Hollander <wi...@widodh.nl>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6200/#review9668
-----------------------------------------------------------
Ship it!
I didn't notice this review, but noticed the bug myself this morning, so I fixed it.
- Wido den Hollander
On July 30, 2012, 6:53 a.m., Tomoe Sugihara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6200/
> -----------------------------------------------------------
>
> (Updated July 30, 2012, 6:53 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Fix typo
>
> Agent would fail to run correctly as com.cloud.utils.script.Script#findScript
> looks for "paths.script" instead of "paths.scripts".
>
> Signed-off-by: Tomoe Sugihara <to...@midokura.com>
>
>
> Diffs
> -----
>
> agent/conf/environment.properties.in 7fcf570538fdc7de0e9b180ba1d35897c2001f3f
>
> Diff: https://reviews.apache.org/r/6200/diff/
>
>
> Testing
> -------
>
> tested with cloud-agent deb package
>
>
> Thanks,
>
> Tomoe Sugihara
>
>
Re: Review Request: Fix typo
Posted by edison su <ed...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6200/#review9663
-----------------------------------------------------------
fixed by Wido in da0db631d01e59b233da6da481eb8074c0f3891f
- edison su
On July 30, 2012, 6:53 a.m., Tomoe Sugihara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6200/
> -----------------------------------------------------------
>
> (Updated July 30, 2012, 6:53 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Fix typo
>
> Agent would fail to run correctly as com.cloud.utils.script.Script#findScript
> looks for "paths.script" instead of "paths.scripts".
>
> Signed-off-by: Tomoe Sugihara <to...@midokura.com>
>
>
> Diffs
> -----
>
> agent/conf/environment.properties.in 7fcf570538fdc7de0e9b180ba1d35897c2001f3f
>
> Diff: https://reviews.apache.org/r/6200/diff/
>
>
> Testing
> -------
>
> tested with cloud-agent deb package
>
>
> Thanks,
>
> Tomoe Sugihara
>
>