You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2021/06/18 20:58:40 UTC
[GitHub] [logging-log4j2] hpple opened a new pull request #521: Remove outdated comment from SystemClock
hpple opened a new pull request #521:
URL: https://github.com/apache/logging-log4j2/pull/521
Hi!
This comment looks outdated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] vy commented on pull request #521: Remove outdated comment from SystemClock
Posted by GitBox <gi...@apache.org>.
vy commented on pull request #521:
URL: https://github.com/apache/logging-log4j2/pull/521#issuecomment-864389997
@hpple, thanks for reminding us about that detail. Actually the comment still applies, though the wording needs to be improved indeed: _"The precise clock is not enabled by default, since access to it is not garbage free."_ And also the comment better be situated just above the `log4j2.usePreciseClock` variable. Would you mind updating your PR to adapt this, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] vy merged pull request #521: Rephrase outdated comment in SystemClock
Posted by GitBox <gi...@apache.org>.
vy merged pull request #521:
URL: https://github.com/apache/logging-log4j2/pull/521
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] hpple commented on pull request #521: Rephrase outdated comment in SystemClock
Posted by GitBox <gi...@apache.org>.
hpple commented on pull request #521:
URL: https://github.com/apache/logging-log4j2/pull/521#issuecomment-864412200
@vy
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] vy commented on pull request #521: Rephrase outdated comment in SystemClock
Posted by GitBox <gi...@apache.org>.
vy commented on pull request #521:
URL: https://github.com/apache/logging-log4j2/pull/521#issuecomment-864414040
@hpple, thanks so much for the contribution and the prompt response! Merging it right away.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org