You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by ab...@apache.org on 2022/11/22 13:33:07 UTC

[hive] branch master updated: HIVE-23754: LLAP, Add LoggingHandler in ShuffleHandler pipeline for better debuggability (#3669) (Dmitriy Fingerman reviewed by Laszlo Bodor)

This is an automated email from the ASF dual-hosted git repository.

abstractdog pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hive.git


The following commit(s) were added to refs/heads/master by this push:
     new cbaca7363c3 HIVE-23754: LLAP, Add LoggingHandler in ShuffleHandler pipeline for better debuggability (#3669) (Dmitriy Fingerman reviewed by Laszlo Bodor)
cbaca7363c3 is described below

commit cbaca7363c30b14929ac81d00e2c1f71c6eee8e6
Author: Dmitriy Fingerman <dm...@gmail.com>
AuthorDate: Tue Nov 22 08:32:56 2022 -0500

    HIVE-23754: LLAP, Add LoggingHandler in ShuffleHandler pipeline for better debuggability (#3669) (Dmitriy Fingerman reviewed by Laszlo Bodor)
---
 .../org/apache/hadoop/hive/llap/shufflehandler/ShuffleHandler.java   | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/llap-server/src/java/org/apache/hadoop/hive/llap/shufflehandler/ShuffleHandler.java b/llap-server/src/java/org/apache/hadoop/hive/llap/shufflehandler/ShuffleHandler.java
index f3859191e4c..70f568ee904 100644
--- a/llap-server/src/java/org/apache/hadoop/hive/llap/shufflehandler/ShuffleHandler.java
+++ b/llap-server/src/java/org/apache/hadoop/hive/llap/shufflehandler/ShuffleHandler.java
@@ -50,6 +50,8 @@ import java.util.regex.Pattern;
 
 import javax.crypto.SecretKey;
 
+import io.netty.handler.logging.LogLevel;
+import io.netty.handler.logging.LoggingHandler;
 import org.apache.hadoop.conf.Configuration;
 import org.apache.hadoop.fs.LocalDirAllocator;
 import org.apache.hadoop.fs.Path;
@@ -390,6 +392,9 @@ public class ShuffleHandler implements AttemptRegistrationListener {
         if (sslFactory != null) {
           pipeline.addLast("ssl", new SslHandler(sslFactory.createSSLEngine()));
         }
+        if (LOG.isDebugEnabled()) {
+          pipeline.addLast("loggingHandler", new LoggingHandler(LogLevel.DEBUG));
+        }
         pipeline.addLast("decoder", new HttpRequestDecoder());
         pipeline.addLast("aggregator", new HttpObjectAggregator(1 << 16));
         pipeline.addLast("encoder", new HttpResponseEncoder());