[GitHub] [doris] HappenLee commented on a diff in pull request #16102: [Bug](runtimefilter) Fix wrong runtime filter on datetime

[GitBox <gi...@apache.org>]

HappenLee commented on code in PR #16102:
URL: https://github.com/apache/doris/pull/16102#discussion_r1081229038


##########
be/src/exprs/bloomfilter_predicate.h:
##########
@@ -334,6 +334,12 @@ struct DateTimeFindOp : public CommonFindOp<DateTimeValue> {
         value.from_olap_datetime(*reinterpret_cast<const uint64_t*>(data));
         return bloom_filter.test(Slice((char*)&value, sizeof(DateTimeValue)));
     }
+    void insert(BloomFilterAdaptor& bloom_filter, const void* data) const {

Review Comment:
   we should do the unify job should in function `find_olap_engine`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org