auto-prop setting of eol-style on binary file?

[Kylo Ginsberg <ky...@gmail.com>]

I have two sets of tools which both produce (unrelated) files with the
.lib extension; one tool produces binary .lib files, one produces text
.lib files.  Oh joy. ;>

I am running subversion 1.4.3.  I have autoprops enabled and this
entry under [auto-props]
*.lib = svn:eol-style=native

I then add a binary foo.lib:
> svn add foo.lib
svn: File 'foo.lib' has binary mime type property

Note that it does *not* give me the expected output which would be
something like:
A (bin) foo.lib
Also, note that it exits with an error return code of 1, and that if
there were multiple files being added it would not get to the rest on
the command line.

*But* a svn stat shows that it *has* been added with the
(binary-appropriate) mime property, and without the svn:eol-style
setting.  (Exactly what I want actually.)

So from a property setting perspective it has done what I want, but
from an error code (and finishing the operation) perspective, it has
not.

My questions:
Is there a bug here? If so, is it that it has added the file, or is it
that it has exited early with an error?

If there is not a bug here, is this actually the spec'd behavior?
I.e. can I assume that future releases will behave the same way?

Thanks,
Kylo

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org

Re: auto-prop setting of eol-style on binary file?

[Ryan Schmidt <su...@ryandesign.com>]

On Mar 21, 2007, at 13:15, Kylo Ginsberg wrote:

> I have two sets of tools which both produce (unrelated) files with the
> .lib extension; one tool produces binary .lib files, one produces text
> .lib files.  Oh joy. ;>
>
> I am running subversion 1.4.3.  I have autoprops enabled and this
> entry under [auto-props]
> *.lib = svn:eol-style=native
>
> I then add a binary foo.lib:
>> svn add foo.lib
> svn: File 'foo.lib' has binary mime type property
>
> Note that it does *not* give me the expected output which would be
> something like:
> A (bin) foo.lib
> Also, note that it exits with an error return code of 1, and that if
> there were multiple files being added it would not get to the rest on
> the command line.
>
> *But* a svn stat shows that it *has* been added with the
> (binary-appropriate) mime property, and without the svn:eol-style
> setting.  (Exactly what I want actually.)
>
> So from a property setting perspective it has done what I want, but
> from an error code (and finishing the operation) perspective, it has
> not.
>
> My questions:
> Is there a bug here? If so, is it that it has added the file, or is it
> that it has exited early with an error?
>
> If there is not a bug here, is this actually the spec'd behavior?
> I.e. can I assume that future releases will behave the same way?

I would say it's this bug:

http://subversion.tigris.org/issues/show_bug.cgi?id=2713

I would say the bug is that the file was added at all; it should have  
printed an error and exited before doing so.


-- 

To reply to the mailing list, please use your mailer's Reply To All  
function


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org