You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jason810496 (via GitHub)" <gi...@apache.org> on 2026/07/01 03:45:35 UTC

[PR] Fix nil sdk.XComClient injected into Go SDK tasks [airflow]

jason810496 opened a new pull request, #69192:
URL: https://github.com/apache/airflow/pull/69192

   ## Why
   
   `sdk.XComClient` is documented as an injectable task parameter, but the dependency-injection matcher only recognised `sdk.Client`, `VariableClient`, and `ConnectionClient`. A task declaring an `sdk.XComClient` parameter received a nil interface and panicked on first use.
   
   ## What
   
   - Recognise sdk.XComClient in the DI matcher so the runtime injects a working client.
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [x] Yes, with help of Claude Code Opus 4.8 following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix nil sdk.XComClient injected into Go SDK tasks [airflow]

Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on PR #69192:
URL: https://github.com/apache/airflow/pull/69192#issuecomment-4850752596

   Is there a programmatic way to catch similar issues at compile (or pre-commit) time? Or is this not an issue in general so it’s fine to just fix this as a standalone issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix nil sdk.XComClient injected into Go SDK tasks [airflow]

Posted by "jason810496 (via GitHub)" <gi...@apache.org>.
jason810496 merged PR #69192:
URL: https://github.com/apache/airflow/pull/69192


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix nil sdk.XComClient injected into Go SDK tasks [airflow]

Posted by "jason810496 (via GitHub)" <gi...@apache.org>.
jason810496 commented on PR #69192:
URL: https://github.com/apache/airflow/pull/69192#issuecomment-4850884881

   > Is there a programmatic way to catch similar issues at compile (or pre-commit) time? Or is this not an issue in general so it’s fine to just fix this as a standalone issue?
   
   Good idea, I will create a follow-up to prevent drift automatically.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org