You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Gavin Baumanis <ga...@thespidernet.com> on 2009/07/11 05:23:08 UTC

Re: svn commit: r38410 - trunk/subversion/libsvn_auth_gnome_keyring

Just out of curiosity,

Am I wrong is the new text in this patch, the same as the deletions?

Gavin.


On 11/07/2009, at 1:46 PM, Arfrever Frehtes Taifersar Arahesis wrote:

> Author: arfrever
> Date: Fri Jul 10 20:46:13 2009
> New Revision: 38410
>
> Log:
> * subversion/libsvn_auth_gnome_keyring/gnome_keyring.c
>  (simple_gnome_keyring_first_creds, simple_gnome_keyring_save_creds,
>   ssl_client_cert_pw_gnome_keyring_first_creds,
>   ssl_client_cert_pw_gnome_keyring_save_creds): Fix some messages.
>
> Modified:
>   trunk/subversion/libsvn_auth_gnome_keyring/gnome_keyring.c
>
> Modified: trunk/subversion/libsvn_auth_gnome_keyring/gnome_keyring.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_auth_gnome_keyring/gnome_keyring.c?pathrev=38410&r1=38409&r2=38410
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- trunk/subversion/libsvn_auth_gnome_keyring/gnome_keyring.c	Fri  
> Jul 10 14:41:48 2009	(r38409)
> +++ trunk/subversion/libsvn_auth_gnome_keyring/gnome_keyring.c	Fri  
> Jul 10 20:46:13 2009	(r38410)
> @@ -411,7 +411,7 @@ simple_gnome_keyring_first_creds(void **
>     {
>       return svn_error_create(SVN_ERR_AUTHN_CREDS_UNAVAILABLE, NULL,
>                               _("GNOME Keyring is locked and "
> -                                " we are non-interactive"));
> +                                "we are non-interactive"));
>     }
>   else
>     {
> @@ -470,7 +470,7 @@ simple_gnome_keyring_save_creds(svn_bool
>     {
>       return svn_error_create(SVN_ERR_AUTHN_CREDS_NOT_SAVED, NULL,
>                               _("GNOME Keyring is locked and "
> -                                " we are non-interactive"));
> +                                "we are non-interactive"));
>     }
>   else
>     {
> @@ -566,7 +566,7 @@ ssl_client_cert_pw_gnome_keyring_first_c
>     {
>       return svn_error_create(SVN_ERR_AUTHN_CREDS_UNAVAILABLE, NULL,
>                               _("GNOME Keyring is locked and "
> -                                " we are non-interactive"));
> +                                "we are non-interactive"));
>     }
>   else
>     {
> @@ -626,7 +626,7 @@ ssl_client_cert_pw_gnome_keyring_save_cr
>     {
>       return svn_error_create(SVN_ERR_AUTHN_CREDS_UNAVAILABLE, NULL,
>                               _("GNOME Keyring is locked and "
> -                                " we are non-interactive"));
> +                                "we are non-interactive"));
>     }
>   else
>     {
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=495&dsMessageId=2370607

Gavin Baumanis
P: +61 438 545 586
E: gavinb@thespidernet.com

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2370613

Re: svn commit: r38410 - trunk/subversion/libsvn_auth_gnome_keyring

Posted by Arfrever Frehtes Taifersar Arahesis <Ar...@GMail.Com>.
2009-07-11 09:28:39 Lieven Govaerts napisał(a):
> On Sat, Jul 11, 2009 at 9:27 AM, Lieven Govaerts<sv...@mobsol.be> wrote:
> > On Sat, Jul 11, 2009 at 7:23 AM, Gavin Baumanis<ga...@thespidernet.com> wrote:
> >> Just out of curiosity,
> >>
> >> Am I wrong is the new text in this patch, the same as the deletions?
> >>
> > It's probably a whitespace only change, but since Arfrever didn't add
> > a log message you can't see that from this email.
> 
> Make that 'a clear log message'.

The messages contained some bugs ("  ") and I fixed them, so "Fix some messages." is relatively sufficient :) .
I added the sed command to the log message.

-- 
Arfrever Frehtes Taifersar Arahesis

Re: svn commit: r38410 - trunk/subversion/libsvn_auth_gnome_keyring

Posted by Lieven Govaerts <sv...@mobsol.be>.
On Sat, Jul 11, 2009 at 9:27 AM, Lieven Govaerts<sv...@mobsol.be> wrote:
> On Sat, Jul 11, 2009 at 7:23 AM, Gavin Baumanis<ga...@thespidernet.com> wrote:
>> Just out of curiosity,
>>
>> Am I wrong is the new text in this patch, the same as the deletions?
>>
> It's probably a whitespace only change, but since Arfrever didn't add
> a log message you can't see that from this email.

Make that 'a clear log message'.

>
> Lieven
>
>
>>
>>
>> On 11/07/2009, at 1:46 PM, Arfrever Frehtes Taifersar Arahesis wrote:
>>
>>> Author: arfrever
>>> Date: Fri Jul 10 20:46:13 2009
>>> New Revision: 38410
>>>
>>> Log:
>>> * subversion/libsvn_auth_gnome_keyring/gnome_keyring.c
>>>  (simple_gnome_keyring_first_creds, simple_gnome_keyring_save_creds,
>>>   ssl_client_cert_pw_gnome_keyring_first_creds,
>>>   ssl_client_cert_pw_gnome_keyring_save_creds): Fix some messages.
>>>
>>> Modified:
>>>   trunk/subversion/libsvn_auth_gnome_keyring/gnome_keyring.c
>>>
>>> Modified: trunk/subversion/libsvn_auth_gnome_keyring/gnome_keyring.c
>>> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_auth_gnome_keyring/gnome_keyring.c?pathrev=38410&r1=38409&r2=38410
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> ======================================================================
>>> --- trunk/subversion/libsvn_auth_gnome_keyring/gnome_keyring.c        Fri
>>> Jul 10 14:41:48 2009  (r38409)
>>> +++ trunk/subversion/libsvn_auth_gnome_keyring/gnome_keyring.c        Fri
>>> Jul 10 20:46:13 2009  (r38410)
>>> @@ -411,7 +411,7 @@ simple_gnome_keyring_first_creds(void **
>>>     {
>>>       return svn_error_create(SVN_ERR_AUTHN_CREDS_UNAVAILABLE, NULL,
>>>                               _("GNOME Keyring is locked and "
>>> -                                " we are non-interactive"));
>>> +                                "we are non-interactive"));
>>>     }
>>>   else
>>>     {
>>> @@ -470,7 +470,7 @@ simple_gnome_keyring_save_creds(svn_bool
>>>     {
>>>       return svn_error_create(SVN_ERR_AUTHN_CREDS_NOT_SAVED, NULL,
>>>                               _("GNOME Keyring is locked and "
>>> -                                " we are non-interactive"));
>>> +                                "we are non-interactive"));
>>>     }
>>>   else
>>>     {
>>> @@ -566,7 +566,7 @@ ssl_client_cert_pw_gnome_keyring_first_c
>>>     {
>>>       return svn_error_create(SVN_ERR_AUTHN_CREDS_UNAVAILABLE, NULL,
>>>                               _("GNOME Keyring is locked and "
>>> -                                " we are non-interactive"));
>>> +                                "we are non-interactive"));
>>>     }
>>>   else
>>>     {
>>> @@ -626,7 +626,7 @@ ssl_client_cert_pw_gnome_keyring_save_cr
>>>     {
>>>       return svn_error_create(SVN_ERR_AUTHN_CREDS_UNAVAILABLE, NULL,
>>>                               _("GNOME Keyring is locked and "
>>> -                                " we are non-interactive"));
>>> +                                "we are non-interactive"));
>>>     }
>>>   else
>>>     {
>>>
>>> ------------------------------------------------------
>>> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=495&dsMessageId=2370607
>>
>> Gavin Baumanis
>> P: +61 438 545 586
>> E: gavinb@thespidernet.com
>>
>> ------------------------------------------------------
>> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2370613
>>
>

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2370627


Re: svn commit: r38410 - trunk/subversion/libsvn_auth_gnome_keyring

Posted by Lieven Govaerts <sv...@mobsol.be>.
On Sat, Jul 11, 2009 at 7:23 AM, Gavin Baumanis<ga...@thespidernet.com> wrote:
> Just out of curiosity,
>
> Am I wrong is the new text in this patch, the same as the deletions?
>
It's probably a whitespace only change, but since Arfrever didn't add
a log message you can't see that from this email.

Lieven


>
>
> On 11/07/2009, at 1:46 PM, Arfrever Frehtes Taifersar Arahesis wrote:
>
>> Author: arfrever
>> Date: Fri Jul 10 20:46:13 2009
>> New Revision: 38410
>>
>> Log:
>> * subversion/libsvn_auth_gnome_keyring/gnome_keyring.c
>>  (simple_gnome_keyring_first_creds, simple_gnome_keyring_save_creds,
>>   ssl_client_cert_pw_gnome_keyring_first_creds,
>>   ssl_client_cert_pw_gnome_keyring_save_creds): Fix some messages.
>>
>> Modified:
>>   trunk/subversion/libsvn_auth_gnome_keyring/gnome_keyring.c
>>
>> Modified: trunk/subversion/libsvn_auth_gnome_keyring/gnome_keyring.c
>> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_auth_gnome_keyring/gnome_keyring.c?pathrev=38410&r1=38409&r2=38410
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> ======================================================================
>> --- trunk/subversion/libsvn_auth_gnome_keyring/gnome_keyring.c        Fri
>> Jul 10 14:41:48 2009  (r38409)
>> +++ trunk/subversion/libsvn_auth_gnome_keyring/gnome_keyring.c        Fri
>> Jul 10 20:46:13 2009  (r38410)
>> @@ -411,7 +411,7 @@ simple_gnome_keyring_first_creds(void **
>>     {
>>       return svn_error_create(SVN_ERR_AUTHN_CREDS_UNAVAILABLE, NULL,
>>                               _("GNOME Keyring is locked and "
>> -                                " we are non-interactive"));
>> +                                "we are non-interactive"));
>>     }
>>   else
>>     {
>> @@ -470,7 +470,7 @@ simple_gnome_keyring_save_creds(svn_bool
>>     {
>>       return svn_error_create(SVN_ERR_AUTHN_CREDS_NOT_SAVED, NULL,
>>                               _("GNOME Keyring is locked and "
>> -                                " we are non-interactive"));
>> +                                "we are non-interactive"));
>>     }
>>   else
>>     {
>> @@ -566,7 +566,7 @@ ssl_client_cert_pw_gnome_keyring_first_c
>>     {
>>       return svn_error_create(SVN_ERR_AUTHN_CREDS_UNAVAILABLE, NULL,
>>                               _("GNOME Keyring is locked and "
>> -                                " we are non-interactive"));
>> +                                "we are non-interactive"));
>>     }
>>   else
>>     {
>> @@ -626,7 +626,7 @@ ssl_client_cert_pw_gnome_keyring_save_cr
>>     {
>>       return svn_error_create(SVN_ERR_AUTHN_CREDS_UNAVAILABLE, NULL,
>>                               _("GNOME Keyring is locked and "
>> -                                " we are non-interactive"));
>> +                                "we are non-interactive"));
>>     }
>>   else
>>     {
>>
>> ------------------------------------------------------
>> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=495&dsMessageId=2370607
>
> Gavin Baumanis
> P: +61 438 545 586
> E: gavinb@thespidernet.com
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2370613
>

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2370625