You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/07/23 07:36:43 UTC
[GitHub] [druid] petermarshallio opened a new pull request #11489: Docs - clarify datasource API sources
petermarshallio opened a new pull request #11489:
URL: https://github.com/apache/druid/pull/11489
OTBO Druid Slack conversations, added clarification of the source of the information from the `datasources` APIs.
@jihoonson there seems to be an alternative view on which source is used by which API. I believe this is the right way round now (reflecting what you have posted previously) but if you could confirm this change I'd be grateful.
This PR has:
- [x] been self-reviewed.
- [ ] been tested in a test Druid cluster.
cc @sthetland @techdocsmith
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s merged pull request #11489: Docs - clarify datasource API sources
Posted by GitBox <gi...@apache.org>.
suneet-s merged pull request #11489:
URL: https://github.com/apache/druid/pull/11489
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on a change in pull request #11489: Docs - clarify datasource API sources
Posted by GitBox <gi...@apache.org>.
suneet-s commented on a change in pull request #11489:
URL: https://github.com/apache/druid/pull/11489#discussion_r677456483
##########
File path: docs/operations/api-reference.md
##########
@@ -241,6 +243,8 @@ Note that all _interval_ URL parameters are ISO 8601 strings delimited by a `_`
Returns a list of datasource names found in the cluster.
+This method reads from the server view held by the coordinator that is updated every [`druid.coordinator.period`](../configuration/index.html#coordinator-operation), whereas `/druid/coordinator/v1/metadata/datasources` reads from metadata database.
Review comment:
```suggestion
Returns a list of datasource names found in the cluster as seen by the coordinator. This view is updated every [`druid.coordinator.period`](../configuration/index.html#coordinator-operation).
```
##########
File path: docs/operations/api-reference.md
##########
@@ -189,6 +189,8 @@ Returns a list of all segments for one or more specific datasources with the ful
Returns a list of the names of datasources with at least one used segment in the cluster.
+This method reads from the metadata database, whereas `/druid/coordinator/v1/datasources` reads from the cached server view held by the coordinator that is updated every [`druid.coordinator.period`](../configuration/index.html#coordinator-operation).
Review comment:
nit: Instead of referring to another API in this description, we could talk about why someone would want to use this API. Similar comment below. What do you think?
```suggestion
Returns a list of the names of datasources with at least one used segment in the cluster, retrieved from the metadata database. Users should call this API to get the eventual state that the system will be in.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] petermarshallio commented on pull request #11489: Docs - clarify datasource API sources
Posted by GitBox <gi...@apache.org>.
petermarshallio commented on pull request #11489:
URL: https://github.com/apache/druid/pull/11489#issuecomment-889067303
These are great suggestions @suneet-s – like the further clarity of usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org