You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Eugene Chekanskiy <ec...@hortonworks.com> on 2017/08/28 17:14:33 UTC

Review Request 61951: Add keberos service for 3.0.0 stack

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61951/
-----------------------------------------------------------

Review request for Ambari, Dmitro Lisnichenko and Robert Levas.


Bugs: AMBARI-21833
    https://issues.apache.org/jira/browse/AMBARI-21833


Repository: ambari


Description
-------

add missing kerberos service for 3.0.0 stack


Diffs
-----

  ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/configuration/kerberos-env.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/configuration/krb5-conf.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/kerberos.json PRE-CREATION 
  ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/metainfo.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/package/scripts/kerberos_client.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/package/scripts/kerberos_common.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/package/scripts/params.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/package/scripts/service_check.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/package/scripts/status_params.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/package/scripts/utils.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/properties/krb5_conf.j2 PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/3.0/services/KERBEROS/metainfo.xml PRE-CREATION 


Diff: https://reviews.apache.org/r/61951/diff/1/


Testing
-------

mvn clean test, cluster deploy


Thanks,

Eugene Chekanskiy


Re: Review Request 61951: Add keberos service for 3.0.0 stack

Posted by Robert Levas <rl...@hortonworks.com>.

> On Aug. 28, 2017, 4:36 p.m., Robert Levas wrote:
> > Why is a new added - `1.10.3-30`?  The existing version is `1.10.3-10`?
> 
> Robert Levas wrote:
>     Oops....   Why is a new _version_ added - `1.10.3-30`?  The existing version is `1.10.3-10`?
> 
> Eugene Chekanskiy wrote:
>     3.0 is an independed stack and all code must be moved out to separate tree.

Thanks for the clarification


- Robert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61951/#review183983
-----------------------------------------------------------


On Aug. 28, 2017, 1:14 p.m., Eugene Chekanskiy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61951/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2017, 1:14 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Robert Levas.
> 
> 
> Bugs: AMBARI-21833
>     https://issues.apache.org/jira/browse/AMBARI-21833
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> add missing kerberos service for 3.0.0 stack
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/configuration/kerberos-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/configuration/krb5-conf.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/kerberos.json PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/metainfo.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/package/scripts/kerberos_client.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/package/scripts/kerberos_common.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/package/scripts/params.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/package/scripts/service_check.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/package/scripts/status_params.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/package/scripts/utils.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/properties/krb5_conf.j2 PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/3.0/services/KERBEROS/metainfo.xml PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61951/diff/1/
> 
> 
> Testing
> -------
> 
> mvn clean test, cluster deploy
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>


Re: Review Request 61951: Add keberos service for 3.0.0 stack

Posted by Robert Levas <rl...@hortonworks.com>.

> On Aug. 28, 2017, 4:36 p.m., Robert Levas wrote:
> > Why is a new added - `1.10.3-30`?  The existing version is `1.10.3-10`?

Oops....   Why is a new _version_ added - `1.10.3-30`?  The existing version is `1.10.3-10`?


- Robert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61951/#review183983
-----------------------------------------------------------


On Aug. 28, 2017, 1:14 p.m., Eugene Chekanskiy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61951/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2017, 1:14 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Robert Levas.
> 
> 
> Bugs: AMBARI-21833
>     https://issues.apache.org/jira/browse/AMBARI-21833
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> add missing kerberos service for 3.0.0 stack
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/configuration/kerberos-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/configuration/krb5-conf.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/kerberos.json PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/metainfo.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/package/scripts/kerberos_client.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/package/scripts/kerberos_common.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/package/scripts/params.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/package/scripts/service_check.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/package/scripts/status_params.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/package/scripts/utils.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/properties/krb5_conf.j2 PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/3.0/services/KERBEROS/metainfo.xml PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61951/diff/1/
> 
> 
> Testing
> -------
> 
> mvn clean test, cluster deploy
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>


Re: Review Request 61951: Add keberos service for 3.0.0 stack

Posted by Eugene Chekanskiy <ec...@hortonworks.com>.

> On Aug. 28, 2017, 8:36 p.m., Robert Levas wrote:
> > Why is a new added - `1.10.3-30`?  The existing version is `1.10.3-10`?
> 
> Robert Levas wrote:
>     Oops....   Why is a new _version_ added - `1.10.3-30`?  The existing version is `1.10.3-10`?

3.0 is an independed stack and all code must be moved out to separate tree.


- Eugene


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61951/#review183983
-----------------------------------------------------------


On Aug. 28, 2017, 5:14 p.m., Eugene Chekanskiy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61951/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2017, 5:14 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Robert Levas.
> 
> 
> Bugs: AMBARI-21833
>     https://issues.apache.org/jira/browse/AMBARI-21833
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> add missing kerberos service for 3.0.0 stack
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/configuration/kerberos-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/configuration/krb5-conf.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/kerberos.json PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/metainfo.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/package/scripts/kerberos_client.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/package/scripts/kerberos_common.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/package/scripts/params.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/package/scripts/service_check.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/package/scripts/status_params.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/package/scripts/utils.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/properties/krb5_conf.j2 PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/3.0/services/KERBEROS/metainfo.xml PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61951/diff/1/
> 
> 
> Testing
> -------
> 
> mvn clean test, cluster deploy
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>


Re: Review Request 61951: Add keberos service for 3.0.0 stack

Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61951/#review183983
-----------------------------------------------------------



Why is a new added - `1.10.3-30`?  The existing version is `1.10.3-10`?

- Robert Levas


On Aug. 28, 2017, 1:14 p.m., Eugene Chekanskiy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61951/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2017, 1:14 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Robert Levas.
> 
> 
> Bugs: AMBARI-21833
>     https://issues.apache.org/jira/browse/AMBARI-21833
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> add missing kerberos service for 3.0.0 stack
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/configuration/kerberos-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/configuration/krb5-conf.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/kerberos.json PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/metainfo.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/package/scripts/kerberos_client.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/package/scripts/kerberos_common.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/package/scripts/params.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/package/scripts/service_check.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/package/scripts/status_params.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/package/scripts/utils.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/properties/krb5_conf.j2 PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/3.0/services/KERBEROS/metainfo.xml PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61951/diff/1/
> 
> 
> Testing
> -------
> 
> mvn clean test, cluster deploy
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>


Re: Review Request 61951: Add keberos service for 3.0.0 stack

Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61951/#review184032
-----------------------------------------------------------


Ship it!




Ship It!

- Robert Levas


On Aug. 28, 2017, 1:14 p.m., Eugene Chekanskiy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61951/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2017, 1:14 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Robert Levas.
> 
> 
> Bugs: AMBARI-21833
>     https://issues.apache.org/jira/browse/AMBARI-21833
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> add missing kerberos service for 3.0.0 stack
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/configuration/kerberos-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/configuration/krb5-conf.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/kerberos.json PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/metainfo.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/package/scripts/kerberos_client.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/package/scripts/kerberos_common.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/package/scripts/params.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/package/scripts/service_check.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/package/scripts/status_params.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/package/scripts/utils.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/properties/krb5_conf.j2 PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/3.0/services/KERBEROS/metainfo.xml PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61951/diff/1/
> 
> 
> Testing
> -------
> 
> mvn clean test, cluster deploy
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>