[GitHub] [isis] bradh opened pull request #118: Finish sentence

["bradh (GitHub)" <gi...@apache.org>]

Lots of things could go in here. I also considered "...from an item that is not yet overdue"

[ Full content available at: https://github.com/apache/isis/pull/118 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [isis] andi-huber commented on issue #118: Finish sentence

["andi-huber (GitHub)" <gi...@apache.org>]

Ok, so why not ...
"or a library book that is `loaned out` might be distinguished from one that is `available`."

Do you want me to wait for you to update this PR, or shall I do a separate commit?


[ Full content available at: https://github.com/apache/isis/pull/118 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [isis] bradh commented on issue #118: Finish sentence

["bradh (GitHub)" <gi...@apache.org>]

Happy for you do do it.

[ Full content available at: https://github.com/apache/isis/pull/118 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [isis] bradh commented on issue #118: Finish sentence

["bradh (GitHub)" <gi...@apache.org>]

Works for me - I just want to avoid the incomplete sentence.
I actually thought of it as an item that had been loaned out (e.g. like a library book). English doesn't do very well at distinguishing nouns and verbs...

[ Full content available at: https://github.com/apache/isis/pull/118 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [isis] andi-huber commented on issue #118: Finish sentence

["andi-huber (GitHub)" <gi...@apache.org>]

how about this:
"... or an overdue `Loan` might be distinguished from one that is fully paid."


[ Full content available at: https://github.com/apache/isis/pull/118 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [isis] bradh closed pull request #118: Finish sentence

["bradh (GitHub)" <gi...@apache.org>]

[ pull request closed by bradh ]

[ Full content available at: https://github.com/apache/isis/pull/118 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [isis] andi-huber commented on issue #118: Finish sentence

["andi-huber (GitHub)" <gi...@apache.org>]

changes committed to `master`

Thanks for the contributions Brad!

[ Full content available at: https://github.com/apache/isis/pull/118 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org