[GitHub] [camel-k] realMartinez commented on a diff in pull request #4228: chore: keystore_test file path change

["realMartinez (via GitHub)" <gi...@apache.org>]

realMartinez commented on code in PR #4228:
URL: https://github.com/apache/camel-k/pull/4228#discussion_r1158122493


##########
pkg/util/jvm/keystore_test.go:
##########
@@ -29,15 +31,20 @@ func TestGenerateKeystore(t *testing.T) {
 	// No Data
 	var data [][]byte
 	ctx := context.Background()
-	err := GenerateKeystore(ctx, "", "name", NewKeystorePassword(), data)
+	err := GenerateKeystore(ctx, "", "/tmp/keystore", NewKeystorePassword(), data)
 	assert.Nil(t, err)
 
 	// Correct input
 	data = [][]byte{{0}, {1}}
-	err = GenerateKeystore(ctx, "", "name", NewKeystorePassword(), data)
+	err = GenerateKeystore(ctx, "", "/tmp/keystore", NewKeystorePassword(), data)
 	assert.NotNil(t, err)

Review Comment:
   I will take a look at that later this week, the comment is a leftover. Can create another PR with it rephrased



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org