Re: Deprecate the org.apache.sling.scripting.sightly.models.provider module?

[Radu Cotescu <ra...@apache.org>]

Hi,

I’m going to deprecate this module, now that its functionality has been merged into org.apache.sling.scripting.sightly and we already have two releases where the core HTL engine provides the Use-API UseProvider capable of loading Sling Models.

Thanks,
Radu

> On 16 Apr 2020, at 09:54, Konrad Windszus <ko...@gmx.de> wrote:
> 
> Yes, moving it to another module is totally fine. Still I would prefer to keep it in a dedicated class and not mix it with pojo java use provider. But that is your call...
> Konrad 
> 
>> Am 16.04.2020 um 09:18 schrieb Radu Cotescu <ra...@apache.org>:
>> 
>> Hi,
>> 
>> Ok, I’ll keep the implementation relying on the ModelFactory, but will move it to the JavaUseProvider, with an optional import of the org.apache.sling.models.factory package. I just don’t want a separate module any more for just one class, with a lot of duplication. Hope that’s fine for you, Konrad!
>> 
>> Thanks,
>> Radu
>> 
>>> On 15 Apr 2020, at 19:09, Konrad Windszus <ko...@gmx.de> wrote:
>>> 
>>> Wrapping the exception is ok as long as the old exception is still accessible. One can easily write a ServletFilter which catches (and unwraps) the exception to throw the 500!
>>> With the adaptTo approach the exception will never hit any servlet filter!
>>> 
>> 
>