You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/12 09:10:17 UTC
[GitHub] [flink] zhengcanbin opened a new pull request #11708:
[FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more
than 45 characters
zhengcanbin opened a new pull request #11708: [FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708
## What is the purpose of the change
Among all kinds of k8s components that we already introduced in Flink, the Deployment and the Service have length limitation on its name and they must be no more than 63 characters; therefore, this PR adds precheck on the config option of `kubernetes.cluster-id` to ensure that its value is no more than 45 characters.
## Brief change log
- Add length check for the config option of `kubernetes.cluster-id`.
- Remove `-` from the auto-generated UUID string and get prefix string(45 characters) of the final generaged cluster-id in `KubernetesClusterClientFactory#generateClusterId`.
## Verifying this change
This change added unit tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11708:
[FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more
than 45 characters
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11708: [FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708#issuecomment-612587571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7366",
"triggerID" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"triggerType" : "PUSH"
}, {
"hash" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159952156",
"triggerID" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5388c94a7b03072482dbab60eb8690d6a14abf1d Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/159952156) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7366)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhengcanbin commented on a change in pull request #11708:
[FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more
than 45 characters
Posted by GitBox <gi...@apache.org>.
zhengcanbin commented on a change in pull request #11708: [FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708#discussion_r410670093
##########
File path: flink-kubernetes/src/test/java/org/apache/flink/kubernetes/kubeclient/parameters/AbstractKubernetesParametersTest.java
##########
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.kubernetes.kubeclient.parameters;
+
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.kubernetes.configuration.KubernetesConfigOptions;
+import org.apache.flink.kubernetes.utils.Constants;
+import org.apache.flink.util.StringUtils;
+
+import org.junit.Test;
+
+import java.util.Map;
+import java.util.Random;
+
+import static org.apache.flink.core.testutils.CommonTestUtils.assertThrows;
+
+/**
+ * General tests for the {@link AbstractKubernetesParameters}.
+ */
+public class AbstractKubernetesParametersTest {
Review comment:
Thanks for pointing out this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #11708:
[FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more
than 45 characters
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #11708: [FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708#discussion_r410293510
##########
File path: flink-kubernetes/src/test/java/org/apache/flink/kubernetes/kubeclient/parameters/AbstractKubernetesParametersTest.java
##########
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.kubernetes.kubeclient.parameters;
+
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.kubernetes.configuration.KubernetesConfigOptions;
+import org.apache.flink.kubernetes.utils.Constants;
+import org.apache.flink.util.StringUtils;
+
+import org.junit.Test;
+
+import java.util.Map;
+import java.util.Random;
+
+import static org.apache.flink.core.testutils.CommonTestUtils.assertThrows;
+
+/**
+ * General tests for the {@link AbstractKubernetesParameters}.
+ */
+public class AbstractKubernetesParametersTest {
Review comment:
`extends TestLogger` is missing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhengcanbin edited a comment on issue #11708:
[FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more
than 45 characters
Posted by GitBox <gi...@apache.org>.
zhengcanbin edited a comment on issue #11708: [FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708#issuecomment-616018548
Thanks for your review @tillrohrmann! I have addressed your comments and look forward to your double-check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on a change in pull request #11708:
[FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more
than 45 characters
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #11708: [FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708#discussion_r407442490
##########
File path: flink-kubernetes/src/test/java/org/apache/flink/kubernetes/kubeclient/parameters/AbstractKubernetesParametersTest.java
##########
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.kubernetes.kubeclient.parameters;
+
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.kubernetes.configuration.KubernetesConfigOptions;
+import org.apache.flink.kubernetes.utils.Constants;
+import org.apache.flink.util.StringUtils;
+
+import org.junit.Test;
+
+import java.util.Map;
+import java.util.Random;
+
+import static org.apache.flink.core.testutils.CommonTestUtils.assertThrows;
+
+/**
+ * General tests for the {@link AbstractKubernetesParameters}.
+ */
+public class AbstractKubernetesParametersTest {
+
+ private Configuration flinkConfig = new Configuration();
+ private MockKubernetesParameters mockKubernetesParameters = new MockKubernetesParameters(flinkConfig);
+
+ @Test
+ public void testClusterIdMustNotBeBlank() {
+ flinkConfig.set(KubernetesConfigOptions.CLUSTER_ID, " ");
+ assertThrows(
+ "must not be blank",
+ IllegalArgumentException.class,
+ () -> mockKubernetesParameters.getClusterId()
+ );
+ }
+
+ @Test
+ public void testClusterIdLengthLimitation() {
+ final String stringWithIllegalLength =
+ StringUtils.generateRandomAlphanumericString(new Random(), Constants.MAXIMUM_CHARACTERS_OF_CLUSTER_ID + 1);
+ flinkConfig.set(KubernetesConfigOptions.CLUSTER_ID, stringWithIllegalLength);
+ assertThrows(
+ "must be no more than " + Constants.MAXIMUM_CHARACTERS_OF_CLUSTER_ID + " characters",
+ IllegalArgumentException.class,
+ () -> mockKubernetesParameters.getClusterId()
+ );
+ }
+
+ private class MockKubernetesParameters extends AbstractKubernetesParameters {
Review comment:
Maybe `TestingKubernetesParameters` is better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11708:
[FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more
than 45 characters
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11708: [FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708#issuecomment-612587571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"status" : "CANCELED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7366",
"triggerID" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"triggerType" : "PUSH"
}, {
"hash" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159952156",
"triggerID" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"triggerType" : "PUSH"
}, {
"hash" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5388c94a7b03072482dbab60eb8690d6a14abf1d Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159952156) Azure: [CANCELED](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7366)
* 55e7e81335d9fd83ce378e141f22c9ae9985b144 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11708:
[FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more
than 45 characters
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11708: [FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708#issuecomment-612587571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"status" : "CANCELED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7366",
"triggerID" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"triggerType" : "PUSH"
}, {
"hash" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159952156",
"triggerID" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5388c94a7b03072482dbab60eb8690d6a14abf1d Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159952156) Azure: [CANCELED](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7366)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11708:
[FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more
than 45 characters
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11708: [FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708#issuecomment-612587571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7366",
"triggerID" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"triggerType" : "PUSH"
}, {
"hash" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159952156",
"triggerID" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"triggerType" : "PUSH"
}, {
"hash" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160143986",
"triggerID" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"triggerType" : "PUSH"
}, {
"hash" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7419",
"triggerID" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"triggerType" : "PUSH"
}, {
"hash" : "77fea16c342424d8b0ce3950d5738bfc43dcb3cc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "77fea16c342424d8b0ce3950d5738bfc43dcb3cc",
"triggerType" : "PUSH"
}, {
"hash" : "7dbe26f634078832f148a79be1d50681b3072566",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160826668",
"triggerID" : "7dbe26f634078832f148a79be1d50681b3072566",
"triggerType" : "PUSH"
}, {
"hash" : "7dbe26f634078832f148a79be1d50681b3072566",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7701",
"triggerID" : "7dbe26f634078832f148a79be1d50681b3072566",
"triggerType" : "PUSH"
}, {
"hash" : "288ddcae06c47b8286524f8a62786f14b0887c28",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "288ddcae06c47b8286524f8a62786f14b0887c28",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 77fea16c342424d8b0ce3950d5738bfc43dcb3cc UNKNOWN
* 7dbe26f634078832f148a79be1d50681b3072566 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/160826668) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7701)
* 288ddcae06c47b8286524f8a62786f14b0887c28 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on a change in pull request #11708:
[FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more
than 45 characters
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #11708: [FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708#discussion_r407437003
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesClusterClientFactory.java
##########
@@ -66,6 +67,7 @@ public String getClusterId(Configuration configuration) {
}
private String generateClusterId() {
Review comment:
The default schema of UUID is `e4225fc5-e4a1-4a81-b9b5-0b48baeea7a1`. Maybe it already meets our requirements. Also leaving the dash `-` could help to keep the name in a human readable pattern.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhengcanbin commented on a change in pull request #11708:
[FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more
than 45 characters
Posted by GitBox <gi...@apache.org>.
zhengcanbin commented on a change in pull request #11708: [FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708#discussion_r410670682
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesClusterClientFactory.java
##########
@@ -66,6 +67,7 @@ public String getClusterId(Configuration configuration) {
}
private String generateClusterId() {
- return CLUSTER_ID_PREFIX + UUID.randomUUID();
+ final String randomUUID = UUID.randomUUID().toString().replaceAll("-", "");
Review comment:
> Instead of doing the string replacement, we could also use
>
> this would be a bit simpler.
I agree that the suggested solution would be a bit simpler. The newest commit has adopted it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhengcanbin commented on a change in pull request #11708:
[FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more
than 45 characters
Posted by GitBox <gi...@apache.org>.
zhengcanbin commented on a change in pull request #11708: [FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708#discussion_r407818673
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesClusterClientFactory.java
##########
@@ -66,6 +67,7 @@ public String getClusterId(Configuration configuration) {
}
private String generateClusterId() {
Review comment:
Hi @wangyang0918! The previous pattern is `flink-cluster-c7ce2409-1542-42d7-9843-ecd64277ea9e`, after this change, the pattern will be something like `flink-cluster-c7ce2409154242d79843ecd64277ea9`, which seems more human-readable. Personally I think it does not make too much sense to obey the default schema of UUID.
But if you insist on the previous pattern, I think we could add the `-` back.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on a change in pull request #11708:
[FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more
than 45 characters
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #11708: [FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708#discussion_r407438510
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java
##########
@@ -133,8 +133,8 @@
key("kubernetes.cluster-id")
.stringType()
.noDefaultValue()
- .withDescription("The cluster id used for identifying the unique flink cluster. If it's not set, " +
- "the client will generate a random UUID name.");
+ .withDescription("The cluster-id, which should be no more than 45 characters, is used for identifying " +
Review comment:
I am not sure why do we only allow `45` characters here? Do you mean to leave some possible prefix/suffix for the future?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11708: [FLINK-15816][k8s]
Limit the value of kubernetes.cluster-id to have no more than 45 characters
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11708: [FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708#issuecomment-612586178
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 98bcfafdd5a9517b41ff69e890a2253ace8dfda9 (Sun Apr 12 09:13:03 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11708:
[FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more
than 45 characters
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11708: [FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708#issuecomment-612587571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7366",
"triggerID" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"triggerType" : "PUSH"
}, {
"hash" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159952156",
"triggerID" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"triggerType" : "PUSH"
}, {
"hash" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160143986",
"triggerID" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"triggerType" : "PUSH"
}, {
"hash" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7419",
"triggerID" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 55e7e81335d9fd83ce378e141f22c9ae9985b144 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160143986) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7419)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #11708:
[FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more
than 45 characters
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #11708: [FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708#discussion_r410299043
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesClusterClientFactory.java
##########
@@ -66,6 +67,7 @@ public String getClusterId(Configuration configuration) {
}
private String generateClusterId() {
- return CLUSTER_ID_PREFIX + UUID.randomUUID();
+ final String randomUUID = UUID.randomUUID().toString().replaceAll("-", "");
Review comment:
Instead of doing the string replacement, we could also use
```suggestion
final String randomID = new AbstractID().toString();
```
this would be a bit simpler.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11708:
[FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more
than 45 characters
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11708: [FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708#issuecomment-612587571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"status" : "CANCELED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7366",
"triggerID" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"triggerType" : "PUSH"
}, {
"hash" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159952156",
"triggerID" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"triggerType" : "PUSH"
}, {
"hash" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160143986",
"triggerID" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"triggerType" : "PUSH"
}, {
"hash" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7419",
"triggerID" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5388c94a7b03072482dbab60eb8690d6a14abf1d Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159952156) Azure: [CANCELED](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7366)
* 55e7e81335d9fd83ce378e141f22c9ae9985b144 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160143986) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7419)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhengcanbin commented on a change in pull request #11708:
[FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more
than 45 characters
Posted by GitBox <gi...@apache.org>.
zhengcanbin commented on a change in pull request #11708: [FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708#discussion_r407819735
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java
##########
@@ -133,8 +133,8 @@
key("kubernetes.cluster-id")
.stringType()
.noDefaultValue()
- .withDescription("The cluster id used for identifying the unique flink cluster. If it's not set, " +
- "the client will generate a random UUID name.");
+ .withDescription("The cluster-id, which should be no more than 45 characters, is used for identifying " +
Review comment:
Yes. The external Service has a suffix in its name now, and I used to file another ticket [FLINK-17032](https://issues.apache.org/jira/browse/FLINK-17032) to unify the naming convention of all the K8s components we created now, so I think it would be better to leave room for that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11708:
[FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more
than 45 characters
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11708: [FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708#issuecomment-612587571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7366",
"triggerID" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"triggerType" : "PUSH"
}, {
"hash" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159952156",
"triggerID" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"triggerType" : "PUSH"
}, {
"hash" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160143986",
"triggerID" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"triggerType" : "PUSH"
}, {
"hash" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7419",
"triggerID" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"triggerType" : "PUSH"
}, {
"hash" : "77fea16c342424d8b0ce3950d5738bfc43dcb3cc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "77fea16c342424d8b0ce3950d5738bfc43dcb3cc",
"triggerType" : "PUSH"
}, {
"hash" : "7dbe26f634078832f148a79be1d50681b3072566",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7dbe26f634078832f148a79be1d50681b3072566",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 55e7e81335d9fd83ce378e141f22c9ae9985b144 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160143986) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7419)
* 77fea16c342424d8b0ce3950d5738bfc43dcb3cc UNKNOWN
* 7dbe26f634078832f148a79be1d50681b3072566 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhengcanbin commented on a change in pull request #11708:
[FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more
than 45 characters
Posted by GitBox <gi...@apache.org>.
zhengcanbin commented on a change in pull request #11708: [FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708#discussion_r410670057
##########
File path: flink-kubernetes/src/test/java/org/apache/flink/kubernetes/kubeclient/parameters/AbstractKubernetesParametersTest.java
##########
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.kubernetes.kubeclient.parameters;
+
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.kubernetes.configuration.KubernetesConfigOptions;
+import org.apache.flink.kubernetes.utils.Constants;
+import org.apache.flink.util.StringUtils;
+
+import org.junit.Test;
+
+import java.util.Map;
+import java.util.Random;
+
+import static org.apache.flink.core.testutils.CommonTestUtils.assertThrows;
+
+/**
+ * General tests for the {@link AbstractKubernetesParameters}.
+ */
+public class AbstractKubernetesParametersTest {
+
+ private Configuration flinkConfig = new Configuration();
+ private MockKubernetesParameters mockKubernetesParameters = new MockKubernetesParameters(flinkConfig);
+
+ @Test
+ public void testClusterIdMustNotBeBlank() {
+ flinkConfig.set(KubernetesConfigOptions.CLUSTER_ID, " ");
+ assertThrows(
+ "must not be blank",
+ IllegalArgumentException.class,
+ () -> mockKubernetesParameters.getClusterId()
+ );
+ }
+
+ @Test
+ public void testClusterIdLengthLimitation() {
+ final String stringWithIllegalLength =
+ StringUtils.generateRandomAlphanumericString(new Random(), Constants.MAXIMUM_CHARACTERS_OF_CLUSTER_ID + 1);
+ flinkConfig.set(KubernetesConfigOptions.CLUSTER_ID, stringWithIllegalLength);
+ assertThrows(
+ "must be no more than " + Constants.MAXIMUM_CHARACTERS_OF_CLUSTER_ID + " characters",
+ IllegalArgumentException.class,
+ () -> mockKubernetesParameters.getClusterId()
+ );
+ }
+
+ private class MockKubernetesParameters extends AbstractKubernetesParameters {
Review comment:
Nice tip
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on a change in pull request #11708:
[FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more
than 45 characters
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #11708: [FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708#discussion_r410264361
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesClusterClientFactory.java
##########
@@ -66,6 +67,7 @@ public String getClusterId(Configuration configuration) {
}
private String generateClusterId() {
Review comment:
It is just my personal preference. You could keep the current schema if other reviews have no suggestion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhengcanbin commented on issue #11708: [FLINK-15816][k8s]
Limit the value of kubernetes.cluster-id to have no more than 45 characters
Posted by GitBox <gi...@apache.org>.
zhengcanbin commented on issue #11708: [FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708#issuecomment-612813653
@TisonKun @tillrohrmann @wangyang0918 Could you help review this PR? Thanks a lot in advance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11708:
[FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more
than 45 characters
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11708: [FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708#issuecomment-612587571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7366",
"triggerID" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"triggerType" : "PUSH"
}, {
"hash" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159952156",
"triggerID" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"triggerType" : "PUSH"
}, {
"hash" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160143986",
"triggerID" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"triggerType" : "PUSH"
}, {
"hash" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7419",
"triggerID" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 55e7e81335d9fd83ce378e141f22c9ae9985b144 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160143986) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7419)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhengcanbin commented on issue #11708: [FLINK-15816][k8s]
Limit the value of kubernetes.cluster-id to have no more than 45 characters
Posted by GitBox <gi...@apache.org>.
zhengcanbin commented on issue #11708: [FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708#issuecomment-612723755
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhengcanbin commented on issue #11708: [FLINK-15816][k8s]
Limit the value of kubernetes.cluster-id to have no more than 45 characters
Posted by GitBox <gi...@apache.org>.
zhengcanbin commented on issue #11708: [FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708#issuecomment-613186568
@wangyang0918 Thanks for your comments. I have addressed them, appreciate it if you review it again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11708:
[FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more
than 45 characters
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11708: [FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708#issuecomment-612587571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7366",
"triggerID" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"triggerType" : "PUSH"
}, {
"hash" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159952156",
"triggerID" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"triggerType" : "PUSH"
}, {
"hash" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160143986",
"triggerID" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"triggerType" : "PUSH"
}, {
"hash" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7419",
"triggerID" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"triggerType" : "PUSH"
}, {
"hash" : "77fea16c342424d8b0ce3950d5738bfc43dcb3cc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "77fea16c342424d8b0ce3950d5738bfc43dcb3cc",
"triggerType" : "PUSH"
}, {
"hash" : "7dbe26f634078832f148a79be1d50681b3072566",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160826668",
"triggerID" : "7dbe26f634078832f148a79be1d50681b3072566",
"triggerType" : "PUSH"
}, {
"hash" : "7dbe26f634078832f148a79be1d50681b3072566",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7701",
"triggerID" : "7dbe26f634078832f148a79be1d50681b3072566",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 77fea16c342424d8b0ce3950d5738bfc43dcb3cc UNKNOWN
* 7dbe26f634078832f148a79be1d50681b3072566 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/160826668) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7701)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhengcanbin commented on a change in pull request #11708:
[FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more
than 45 characters
Posted by GitBox <gi...@apache.org>.
zhengcanbin commented on a change in pull request #11708: [FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708#discussion_r410670049
##########
File path: flink-kubernetes/src/test/java/org/apache/flink/kubernetes/kubeclient/parameters/AbstractKubernetesParametersTest.java
##########
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.kubernetes.kubeclient.parameters;
+
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.kubernetes.configuration.KubernetesConfigOptions;
+import org.apache.flink.kubernetes.utils.Constants;
+import org.apache.flink.util.StringUtils;
+
+import org.junit.Test;
+
+import java.util.Map;
+import java.util.Random;
+
+import static org.apache.flink.core.testutils.CommonTestUtils.assertThrows;
+
+/**
+ * General tests for the {@link AbstractKubernetesParameters}.
+ */
+public class AbstractKubernetesParametersTest {
+
+ private Configuration flinkConfig = new Configuration();
Review comment:
True
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11708:
[FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more
than 45 characters
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11708: [FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708#issuecomment-612587571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7366",
"triggerID" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"triggerType" : "PUSH"
}, {
"hash" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159952156",
"triggerID" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5388c94a7b03072482dbab60eb8690d6a14abf1d Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159952156) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7366)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11708:
[FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more
than 45 characters
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11708: [FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708#issuecomment-612587571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7366",
"triggerID" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"triggerType" : "PUSH"
}, {
"hash" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159952156",
"triggerID" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"triggerType" : "PUSH"
}, {
"hash" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160143986",
"triggerID" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"triggerType" : "PUSH"
}, {
"hash" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7419",
"triggerID" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"triggerType" : "PUSH"
}, {
"hash" : "77fea16c342424d8b0ce3950d5738bfc43dcb3cc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "77fea16c342424d8b0ce3950d5738bfc43dcb3cc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 55e7e81335d9fd83ce378e141f22c9ae9985b144 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160143986) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7419)
* 77fea16c342424d8b0ce3950d5738bfc43dcb3cc UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11708: [FLINK-15816][k8s]
Limit the value of kubernetes.cluster-id to have no more than 45 characters
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11708: [FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708#issuecomment-612587571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5388c94a7b03072482dbab60eb8690d6a14abf1d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on a change in pull request #11708:
[FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more
than 45 characters
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #11708: [FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708#discussion_r407439569
##########
File path: flink-kubernetes/src/test/java/org/apache/flink/kubernetes/kubeclient/parameters/AbstractKubernetesParametersTest.java
##########
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.kubernetes.kubeclient.parameters;
+
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.kubernetes.configuration.KubernetesConfigOptions;
+import org.apache.flink.kubernetes.utils.Constants;
+import org.apache.flink.util.StringUtils;
+
+import org.junit.Test;
+
+import java.util.Map;
+import java.util.Random;
+
+import static org.apache.flink.core.testutils.CommonTestUtils.assertThrows;
+
+/**
+ * General tests for the {@link AbstractKubernetesParameters}.
+ */
+public class AbstractKubernetesParametersTest {
+
+ private Configuration flinkConfig = new Configuration();
Review comment:
nit: The variables could be `final`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11708:
[FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more
than 45 characters
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11708: [FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708#issuecomment-612587571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7366",
"triggerID" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"triggerType" : "PUSH"
}, {
"hash" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159952156",
"triggerID" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"triggerType" : "PUSH"
}, {
"hash" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160143986",
"triggerID" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"triggerType" : "PUSH"
}, {
"hash" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7419",
"triggerID" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"triggerType" : "PUSH"
}, {
"hash" : "77fea16c342424d8b0ce3950d5738bfc43dcb3cc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "77fea16c342424d8b0ce3950d5738bfc43dcb3cc",
"triggerType" : "PUSH"
}, {
"hash" : "7dbe26f634078832f148a79be1d50681b3072566",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160826668",
"triggerID" : "7dbe26f634078832f148a79be1d50681b3072566",
"triggerType" : "PUSH"
}, {
"hash" : "7dbe26f634078832f148a79be1d50681b3072566",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7701",
"triggerID" : "7dbe26f634078832f148a79be1d50681b3072566",
"triggerType" : "PUSH"
}, {
"hash" : "288ddcae06c47b8286524f8a62786f14b0887c28",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160836060",
"triggerID" : "288ddcae06c47b8286524f8a62786f14b0887c28",
"triggerType" : "PUSH"
}, {
"hash" : "288ddcae06c47b8286524f8a62786f14b0887c28",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7703",
"triggerID" : "288ddcae06c47b8286524f8a62786f14b0887c28",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 77fea16c342424d8b0ce3950d5738bfc43dcb3cc UNKNOWN
* 7dbe26f634078832f148a79be1d50681b3072566 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/160826668) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7701)
* 288ddcae06c47b8286524f8a62786f14b0887c28 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160836060) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7703)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11708:
[FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more
than 45 characters
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11708: [FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708#issuecomment-612587571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7366",
"triggerID" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"triggerType" : "PUSH"
}, {
"hash" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159952156",
"triggerID" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"triggerType" : "PUSH"
}, {
"hash" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160143986",
"triggerID" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"triggerType" : "PUSH"
}, {
"hash" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7419",
"triggerID" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"triggerType" : "PUSH"
}, {
"hash" : "77fea16c342424d8b0ce3950d5738bfc43dcb3cc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "77fea16c342424d8b0ce3950d5738bfc43dcb3cc",
"triggerType" : "PUSH"
}, {
"hash" : "7dbe26f634078832f148a79be1d50681b3072566",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160826668",
"triggerID" : "7dbe26f634078832f148a79be1d50681b3072566",
"triggerType" : "PUSH"
}, {
"hash" : "7dbe26f634078832f148a79be1d50681b3072566",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7701",
"triggerID" : "7dbe26f634078832f148a79be1d50681b3072566",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 77fea16c342424d8b0ce3950d5738bfc43dcb3cc UNKNOWN
* 7dbe26f634078832f148a79be1d50681b3072566 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160826668) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7701)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11708:
[FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more
than 45 characters
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11708: [FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708#issuecomment-612587571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7366",
"triggerID" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"triggerType" : "PUSH"
}, {
"hash" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159952156",
"triggerID" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"triggerType" : "PUSH"
}, {
"hash" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160143986",
"triggerID" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"triggerType" : "PUSH"
}, {
"hash" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7419",
"triggerID" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"triggerType" : "PUSH"
}, {
"hash" : "77fea16c342424d8b0ce3950d5738bfc43dcb3cc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "77fea16c342424d8b0ce3950d5738bfc43dcb3cc",
"triggerType" : "PUSH"
}, {
"hash" : "7dbe26f634078832f148a79be1d50681b3072566",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160826668",
"triggerID" : "7dbe26f634078832f148a79be1d50681b3072566",
"triggerType" : "PUSH"
}, {
"hash" : "7dbe26f634078832f148a79be1d50681b3072566",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7701",
"triggerID" : "7dbe26f634078832f148a79be1d50681b3072566",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 55e7e81335d9fd83ce378e141f22c9ae9985b144 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160143986) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7419)
* 77fea16c342424d8b0ce3950d5738bfc43dcb3cc UNKNOWN
* 7dbe26f634078832f148a79be1d50681b3072566 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160826668) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7701)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11708:
[FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more
than 45 characters
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11708: [FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708#issuecomment-612587571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7366",
"triggerID" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"triggerType" : "PUSH"
}, {
"hash" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159952156",
"triggerID" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"triggerType" : "PUSH"
}, {
"hash" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160143986",
"triggerID" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"triggerType" : "PUSH"
}, {
"hash" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7419",
"triggerID" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"triggerType" : "PUSH"
}, {
"hash" : "77fea16c342424d8b0ce3950d5738bfc43dcb3cc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "77fea16c342424d8b0ce3950d5738bfc43dcb3cc",
"triggerType" : "PUSH"
}, {
"hash" : "7dbe26f634078832f148a79be1d50681b3072566",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160826668",
"triggerID" : "7dbe26f634078832f148a79be1d50681b3072566",
"triggerType" : "PUSH"
}, {
"hash" : "7dbe26f634078832f148a79be1d50681b3072566",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7701",
"triggerID" : "7dbe26f634078832f148a79be1d50681b3072566",
"triggerType" : "PUSH"
}, {
"hash" : "288ddcae06c47b8286524f8a62786f14b0887c28",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160836060",
"triggerID" : "288ddcae06c47b8286524f8a62786f14b0887c28",
"triggerType" : "PUSH"
}, {
"hash" : "288ddcae06c47b8286524f8a62786f14b0887c28",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7703",
"triggerID" : "288ddcae06c47b8286524f8a62786f14b0887c28",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 77fea16c342424d8b0ce3950d5738bfc43dcb3cc UNKNOWN
* 288ddcae06c47b8286524f8a62786f14b0887c28 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160836060) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7703)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11708:
[FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more
than 45 characters
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11708: [FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708#issuecomment-612587571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7366",
"triggerID" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"triggerType" : "PUSH"
}, {
"hash" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159952156",
"triggerID" : "5388c94a7b03072482dbab60eb8690d6a14abf1d",
"triggerType" : "PUSH"
}, {
"hash" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160143986",
"triggerID" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"triggerType" : "PUSH"
}, {
"hash" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7419",
"triggerID" : "55e7e81335d9fd83ce378e141f22c9ae9985b144",
"triggerType" : "PUSH"
}, {
"hash" : "77fea16c342424d8b0ce3950d5738bfc43dcb3cc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "77fea16c342424d8b0ce3950d5738bfc43dcb3cc",
"triggerType" : "PUSH"
}, {
"hash" : "7dbe26f634078832f148a79be1d50681b3072566",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160826668",
"triggerID" : "7dbe26f634078832f148a79be1d50681b3072566",
"triggerType" : "PUSH"
}, {
"hash" : "7dbe26f634078832f148a79be1d50681b3072566",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7701",
"triggerID" : "7dbe26f634078832f148a79be1d50681b3072566",
"triggerType" : "PUSH"
}, {
"hash" : "288ddcae06c47b8286524f8a62786f14b0887c28",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160836060",
"triggerID" : "288ddcae06c47b8286524f8a62786f14b0887c28",
"triggerType" : "PUSH"
}, {
"hash" : "288ddcae06c47b8286524f8a62786f14b0887c28",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7703",
"triggerID" : "288ddcae06c47b8286524f8a62786f14b0887c28",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 77fea16c342424d8b0ce3950d5738bfc43dcb3cc UNKNOWN
* 288ddcae06c47b8286524f8a62786f14b0887c28 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160836060) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7703)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhengcanbin commented on issue #11708: [FLINK-15816][k8s]
Limit the value of kubernetes.cluster-id to have no more than 45 characters
Posted by GitBox <gi...@apache.org>.
zhengcanbin commented on issue #11708: [FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708#issuecomment-616018548
Thanks for your comments @tillrohrmann! I have addressed your comments and look forward to your double-check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhengcanbin commented on a change in pull request #11708:
[FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more
than 45 characters
Posted by GitBox <gi...@apache.org>.
zhengcanbin commented on a change in pull request #11708: [FLINK-15816][k8s] Limit the value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708#discussion_r410670093
##########
File path: flink-kubernetes/src/test/java/org/apache/flink/kubernetes/kubeclient/parameters/AbstractKubernetesParametersTest.java
##########
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.kubernetes.kubeclient.parameters;
+
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.kubernetes.configuration.KubernetesConfigOptions;
+import org.apache.flink.kubernetes.utils.Constants;
+import org.apache.flink.util.StringUtils;
+
+import org.junit.Test;
+
+import java.util.Map;
+import java.util.Random;
+
+import static org.apache.flink.core.testutils.CommonTestUtils.assertThrows;
+
+/**
+ * General tests for the {@link AbstractKubernetesParameters}.
+ */
+public class AbstractKubernetesParametersTest {
Review comment:
Thanks for pointing this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services