You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/04/21 19:13:37 UTC
[GitHub] [trafficcontrol] ocket8888 opened a new pull request, #6768: Add E2E tests for the users table
ocket8888 opened a new pull request, #6768:
URL: https://github.com/apache/trafficcontrol/pull/6768
Adds some pretty minimal e2e tests to TPv2 for its users table. Also I added something to the TO API integration test .gitignore files, which I'm hoping to sneak in as an innocuous change that's too small to warrant its own PR.
There is a test currently commented-out that can't pass until the user details page is implemented.
<hr/>
## Which Traffic Control components are affected by this PR?
- Traffic Portal (experimental v2)
## What is the best way to verify this PR?
Make sure the new test passes, verify that its coverage is... adequate. Currently, the users table doesn't do a whole lot that isn't directly provided by ag-grid - which has its own tests I'm sure that we need not duplicate within our project.
## PR submission checklist
- [x] This PR has tests
- [ ] This PR has documentation
- [ ] This PR has a CHANGELOG.md entry
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] shamrickus commented on a diff in pull request #6768: Add E2E tests for the users table
Posted by GitBox <gi...@apache.org>.
shamrickus commented on code in PR #6768:
URL: https://github.com/apache/trafficcontrol/pull/6768#discussion_r855693563
##########
experimental/traffic-portal/nightwatch/tests/users.spec.ts:
##########
@@ -0,0 +1,71 @@
+/*
+* Licensed under the Apache License, Version 2.0 (the "License");
+* you may not use this file except in compliance with the License.
+* You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+import type { NightwatchBrowser } from "nightwatch";
+import { LoginPageObject } from "nightwatch/page_objects/login";
+
+import type { GlobalConfig } from "../globals/globals";
+import type { UsersPageObject } from "../page_objects/users";
+
+/**
+ * A test suite is a mapping of test descriptions to the functions that
+ * implement the thereby described test.
+ */
+interface TestSuite {
+ [description: string]: (browser: NightwatchBrowser) => (void | Promise<void>);
+};
Review Comment:
Unnecessary semicolon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] shamrickus merged pull request #6768: Add E2E tests for the users table
Posted by GitBox <gi...@apache.org>.
shamrickus merged PR #6768:
URL: https://github.com/apache/trafficcontrol/pull/6768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org