You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/02 14:39:05 UTC
[GitHub] [pulsar] ivankelly opened a new pull request #11901: [Issue #11799][logging] Base implementation of structured logging
ivankelly opened a new pull request #11901:
URL: https://github.com/apache/pulsar/pull/11901
Includes the most simple parts of slf4j structured logging. timed(),
sampled() and enum logging to follow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ivankelly merged pull request #11901: [Issue #11799][logging] Base implementation of structured logging
Posted by GitBox <gi...@apache.org>.
ivankelly merged pull request #11901:
URL: https://github.com/apache/pulsar/pull/11901
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on a change in pull request #11901: [Issue #11799][logging] Base implementation of structured logging
Posted by GitBox <gi...@apache.org>.
merlimat commented on a change in pull request #11901:
URL: https://github.com/apache/pulsar/pull/11901#discussion_r701179333
##########
File path: structured-event-log/src/main/java/org/apache/pulsar/structuredeventlog/slf4j/Slf4jEvent.java
##########
@@ -0,0 +1,206 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.structuredeventlog.slf4j;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.concurrent.ThreadLocalRandom;
+import java.util.concurrent.TimeUnit;
+import java.util.function.Supplier;
+
+import org.apache.pulsar.structuredeventlog.Event;
+import org.apache.pulsar.structuredeventlog.EventResources;
+import org.apache.pulsar.structuredeventlog.EventResourcesImpl;
+
+import org.slf4j.MDC;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+class Slf4jEvent implements Event {
+ private final String id;
+ private String traceId = null;
+ private String parentId = null;
+ private List<Object> attributes = null;
+ private Level level = Level.INFO;
+ private Throwable throwable = null;
+ private final EventResourcesImpl resources;
+
+ Slf4jEvent(EventResourcesImpl parentResources) {
+ this.id = randomId();
+ this.resources = new EventResourcesImpl(parentResources);
+ }
+
+ @Override
+ public Event newChildEvent() {
+ return new Slf4jEvent(resources).traceId(traceId).parentId(id);
+ }
+
+ @Override
+ public Event traceId(String traceId) {
+ this.traceId = traceId;
+ return this;
+ }
+
+ @Override
+ public Event parentId(String parentId) {
+ this.parentId = parentId;
+ return this;
+ }
+
+ @Override
+ public Event timed() {
+ throw new UnsupportedOperationException("TODO");
+ }
+
+ @Override
+ public Event sampled(Object samplingKey, int duration, TimeUnit unit) {
+ throw new UnsupportedOperationException("TODO");
+ }
+
+ @Override
+ public Event resources(EventResources other) {
+ if (other instanceof EventResourcesImpl) {
+ this.resources.copyFrom((EventResourcesImpl)other);
+ }
+ return this;
+ }
+
+ @Override
+ public Event resource(String key, Object value) {
+ resources.resource(key, value);
+ return this;
+ }
+
+ @Override
+ public Event resource(String key, Supplier<String> value) {
+ resources.resource(key, value);
+ return this;
+ }
+
+ @Override
+ public Event attr(String key, Object value) {
+ getAttributes().add(key);
+ getAttributes().add(value);
+ return this;
+ }
+
+ @Override
+ public Event attr(String key, Supplier<String> value) {
+ this.attr(key, (Object)value);
+ return this;
+ }
+
+ @Override
+ public Event exception(Throwable t) {
+ this.throwable = t;
+ return this;
+ }
+
+ @Override
+ public Event atError() {
+ this.level = Level.ERROR;
+ return this;
+ }
+
+ @Override
+ public Event atInfo() {
+ this.level = Level.INFO;
+ return this;
+ }
+
+ @Override
+ public Event atWarn() {
+ this.level = Level.WARN;
+ return this;
+ }
+
+ @Override
+ public void log(Enum<?> event) {
+ throw new UnsupportedOperationException("TODO");
+ }
+
+ @Override
+ public void log(String event) {
+ try {
+ MDC.put("id", id);
+ if (traceId != null) {
+ MDC.put("traceId", traceId);
+ }
+ if (parentId != null) {
+ MDC.put("parentId", parentId);
+ }
+ resources.forEach(MDC::put);
+ if (attributes != null) {
+ EventResourcesImpl.forEach(attributes, MDC::put);
+ }
+ Logger logger = LoggerFactory.getLogger("stevlog");
+ switch (level) {
+ case ERROR:
+ if (throwable != null) {
+ logger.error(event, throwable);
+ } else {
+ logger.error(event);
+ }
+ break;
+ case WARN:
+ if (throwable != null) {
+ logger.warn(event, throwable);
+ } else {
+ logger.warn(event);
+ }
+ break;
+ case INFO:
+ default:
+ if (throwable != null) {
+ logger.info(event, throwable);
+ } else {
+ logger.info(event);
+ }
+ break;
+ }
+ } finally {
+ MDC.clear();
+ }
+ }
+
+ @Override
+ public void stash() {
+ throw new UnsupportedOperationException("TODO");
+ }
+
+ private List<Object> getAttributes() {
+ if (attributes == null) {
+ attributes = new ArrayList<>();
+ }
+ return attributes;
+ }
+
+ static String randomId() {
+ return Long.toString(
+ ThreadLocalRandom.current().nextLong(0x100000000000000L,
+ 0xFFFFFFFFFFFFFFFL),
+ 16);
+ }
+
+ enum Level {
+ INFO,
Review comment:
We can also give the option to do structured debug logs, if someone choses to
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ivankelly commented on a change in pull request #11901: [Issue #11799][logging] Base implementation of structured logging
Posted by GitBox <gi...@apache.org>.
ivankelly commented on a change in pull request #11901:
URL: https://github.com/apache/pulsar/pull/11901#discussion_r701185846
##########
File path: structured-event-log/src/main/java/org/apache/pulsar/structuredeventlog/slf4j/Slf4jEvent.java
##########
@@ -0,0 +1,206 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.structuredeventlog.slf4j;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.concurrent.ThreadLocalRandom;
+import java.util.concurrent.TimeUnit;
+import java.util.function.Supplier;
+
+import org.apache.pulsar.structuredeventlog.Event;
+import org.apache.pulsar.structuredeventlog.EventResources;
+import org.apache.pulsar.structuredeventlog.EventResourcesImpl;
+
+import org.slf4j.MDC;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+class Slf4jEvent implements Event {
+ private final String id;
+ private String traceId = null;
+ private String parentId = null;
+ private List<Object> attributes = null;
+ private Level level = Level.INFO;
+ private Throwable throwable = null;
+ private final EventResourcesImpl resources;
+
+ Slf4jEvent(EventResourcesImpl parentResources) {
+ this.id = randomId();
+ this.resources = new EventResourcesImpl(parentResources);
+ }
+
+ @Override
+ public Event newChildEvent() {
+ return new Slf4jEvent(resources).traceId(traceId).parentId(id);
+ }
+
+ @Override
+ public Event traceId(String traceId) {
+ this.traceId = traceId;
+ return this;
+ }
+
+ @Override
+ public Event parentId(String parentId) {
+ this.parentId = parentId;
+ return this;
+ }
+
+ @Override
+ public Event timed() {
+ throw new UnsupportedOperationException("TODO");
+ }
+
+ @Override
+ public Event sampled(Object samplingKey, int duration, TimeUnit unit) {
+ throw new UnsupportedOperationException("TODO");
+ }
+
+ @Override
+ public Event resources(EventResources other) {
+ if (other instanceof EventResourcesImpl) {
+ this.resources.copyFrom((EventResourcesImpl)other);
+ }
+ return this;
+ }
+
+ @Override
+ public Event resource(String key, Object value) {
+ resources.resource(key, value);
+ return this;
+ }
+
+ @Override
+ public Event resource(String key, Supplier<String> value) {
+ resources.resource(key, value);
+ return this;
+ }
+
+ @Override
+ public Event attr(String key, Object value) {
+ getAttributes().add(key);
+ getAttributes().add(value);
+ return this;
+ }
+
+ @Override
+ public Event attr(String key, Supplier<String> value) {
+ this.attr(key, (Object)value);
+ return this;
+ }
+
+ @Override
+ public Event exception(Throwable t) {
+ this.throwable = t;
+ return this;
+ }
+
+ @Override
+ public Event atError() {
+ this.level = Level.ERROR;
+ return this;
+ }
+
+ @Override
+ public Event atInfo() {
+ this.level = Level.INFO;
+ return this;
+ }
+
+ @Override
+ public Event atWarn() {
+ this.level = Level.WARN;
+ return this;
+ }
+
+ @Override
+ public void log(Enum<?> event) {
+ throw new UnsupportedOperationException("TODO");
+ }
+
+ @Override
+ public void log(String event) {
+ try {
+ MDC.put("id", id);
+ if (traceId != null) {
+ MDC.put("traceId", traceId);
+ }
+ if (parentId != null) {
+ MDC.put("parentId", parentId);
+ }
+ resources.forEach(MDC::put);
+ if (attributes != null) {
+ EventResourcesImpl.forEach(attributes, MDC::put);
+ }
+ Logger logger = LoggerFactory.getLogger("stevlog");
+ switch (level) {
+ case ERROR:
+ if (throwable != null) {
+ logger.error(event, throwable);
+ } else {
+ logger.error(event);
+ }
+ break;
+ case WARN:
+ if (throwable != null) {
+ logger.warn(event, throwable);
+ } else {
+ logger.warn(event);
+ }
+ break;
+ case INFO:
+ default:
+ if (throwable != null) {
+ logger.info(event, throwable);
+ } else {
+ logger.info(event);
+ }
+ break;
+ }
+ } finally {
+ MDC.clear();
+ }
+ }
+
+ @Override
+ public void stash() {
+ throw new UnsupportedOperationException("TODO");
+ }
+
+ private List<Object> getAttributes() {
+ if (attributes == null) {
+ attributes = new ArrayList<>();
+ }
+ return attributes;
+ }
+
+ static String randomId() {
+ return Long.toString(
+ ThreadLocalRandom.current().nextLong(0x100000000000000L,
+ 0xFFFFFFFFFFFFFFFL),
+ 16);
+ }
+
+ enum Level {
+ INFO,
Review comment:
created a JIRA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org