You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/07 22:57:12 UTC
[GitHub] [arrow] ianmcook opened a new pull request #9942: ARROW-12283: [R] Bindings for basic type convert functions in dplyr verbs
ianmcook opened a new pull request #9942:
URL: https://github.com/apache/arrow/pull/9942
This adds support for `as.character()`, `as.double()`, `as.integer()`, `bit64::as.integer64()`, `as.logical()`, and `as.numeric()` in dplyr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9942: ARROW-12283: [R] Bindings for basic type convert functions in dplyr verbs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9942:
URL: https://github.com/apache/arrow/pull/9942#issuecomment-815335150
https://issues.apache.org/jira/browse/ARROW-12283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #9942: ARROW-12283: [R] Bindings for basic type convert functions in dplyr verbs
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #9942:
URL: https://github.com/apache/arrow/pull/9942#issuecomment-815315840
On the one hand, this is helpful and if nothing else may prevent some cryptic errors. On the other hand, it's a little inconsistent because they don't actually yield character (e.g.) vectors, and I wonder if that will cause other unexpected behavior. It's also different (FWIW) from the same methods on Array defined outside of dplyr (which may or may not be very useful): https://github.com/apache/arrow/blob/master/r/R/arrow-datum.R#L138-L145
Do dbplyr backends typically include these?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ianmcook commented on pull request #9942: ARROW-12283: [R] Bindings for basic type convert functions in dplyr verbs
Posted by GitBox <gi...@apache.org>.
ianmcook commented on pull request #9942:
URL: https://github.com/apache/arrow/pull/9942#issuecomment-815327156
I think these are important for basic usability of any dplyr backend. dbplyr defines them for all of the major databases (https://github.com/tidyverse/dbplyr/search?q=%22as.numeric%22) and many other dplyr backends do too. I hear your qualms about mixing R and Arrow paradigms, but I think practically speaking these are too important not to implement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ianmcook edited a comment on pull request #9942: ARROW-12283: [R] Bindings for basic type convert functions in dplyr verbs
Posted by GitBox <gi...@apache.org>.
ianmcook edited a comment on pull request #9942:
URL: https://github.com/apache/arrow/pull/9942#issuecomment-815327156
I think these are important for basic usability of any dplyr backend. dbplyr defines them for all of the major databases (https://github.com/tidyverse/dbplyr/search?q=%22as.numeric%22+backend) and many other dplyr backends do too. I hear your qualms about mixing R and Arrow paradigms, but I think practically speaking these are too important not to implement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson closed pull request #9942: ARROW-12283: [R] Bindings for basic type convert functions in dplyr verbs
Posted by GitBox <gi...@apache.org>.
nealrichardson closed pull request #9942:
URL: https://github.com/apache/arrow/pull/9942
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ianmcook commented on pull request #9942: ARROW-12283: [R] Bindings for basic type convert functions in dplyr verbs
Posted by GitBox <gi...@apache.org>.
ianmcook commented on pull request #9942:
URL: https://github.com/apache/arrow/pull/9942#issuecomment-815426047
I created ARROW-12292 for us to reconsider whether the `ArrowDatum` methods of the same names should perhaps behave differently
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org