You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Yusaku Sako <yu...@hortonworks.com> on 2017/04/20 22:43:39 UTC
Review Request 58596: AMBARI-20813. Convert ambari-web build process
to use
yarn package manager to fix dependencies and to make the process faster
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58596/
-----------------------------------------------------------
Review request for Ambari, Jaimin Jetly and Vivek Ratnavel Subramanian.
Repository: ambari
Description
-------
See https://issues.apache.org/jira/browse/AMBARI-20813
Diffs
-----
ambari-web/pom.xml 6182a60
Diff: https://reviews.apache.org/r/58596/diff/1/
Testing
-------
Tested locally to make sure that "mvn package" builds Ambari Web successfully.
Ran ambari-web unit tests:
30380 passing (19s)
157 pending
Thanks,
Yusaku Sako
Re: Review Request 58596: AMBARI-20813. Convert ambari-web build
process to
use yarn package manager to fix dependencies and to make the process faster
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58596/#review172567
-----------------------------------------------------------
Ship it!
Ship It!
- Jaimin Jetly
On April 21, 2017, 12:09 a.m., Yusaku Sako wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58596/
> -----------------------------------------------------------
>
> (Updated April 21, 2017, 12:09 a.m.)
>
>
> Review request for Ambari, Jaimin Jetly and Vivek Ratnavel Subramanian.
>
>
> Bugs: AMBARI-20813
> https://issues.apache.org/jira/browse/AMBARI-20813
>
>
> Repository: ambari
>
>
> Description
> -------
>
> See https://issues.apache.org/jira/browse/AMBARI-20813
>
>
> Diffs
> -----
>
> ambari-web/pom.xml 6182a60
>
>
> Diff: https://reviews.apache.org/r/58596/diff/2/
>
>
> Testing
> -------
>
> Tested locally to make sure that "mvn package" builds Ambari Web successfully.
>
> Ran ambari-web unit tests:
> 30380 passing (19s)
> 157 pending
>
>
> Thanks,
>
> Yusaku Sako
>
>
Re: Review Request 58596: AMBARI-20813. Convert ambari-web build
process to
use yarn package manager to fix dependencies and to make the process faster
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58596/
-----------------------------------------------------------
(Updated April 21, 2017, 12:09 a.m.)
Review request for Ambari, Jaimin Jetly and Vivek Ratnavel Subramanian.
Changes
-------
While testing on a Jenkins build machine, I've encountered https://github.com/Medium/phantomjs/issues/673. So I've included a workaround.
Bugs: AMBARI-20813
https://issues.apache.org/jira/browse/AMBARI-20813
Repository: ambari
Description
-------
See https://issues.apache.org/jira/browse/AMBARI-20813
Diffs (updated)
-----
ambari-web/pom.xml 6182a60
Diff: https://reviews.apache.org/r/58596/diff/2/
Changes: https://reviews.apache.org/r/58596/diff/1-2/
Testing
-------
Tested locally to make sure that "mvn package" builds Ambari Web successfully.
Ran ambari-web unit tests:
30380 passing (19s)
157 pending
Thanks,
Yusaku Sako
Re: Review Request 58596: AMBARI-20813. Convert ambari-web build
process to
use yarn package manager to fix dependencies and to make the process faster
Posted by Vivek Ratnavel Subramanian <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58596/#review172560
-----------------------------------------------------------
Ship it!
Ship It!
- Vivek Ratnavel Subramanian
On April 20, 2017, 10:43 p.m., Yusaku Sako wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58596/
> -----------------------------------------------------------
>
> (Updated April 20, 2017, 10:43 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly and Vivek Ratnavel Subramanian.
>
>
> Bugs: AMBARI-20813
> https://issues.apache.org/jira/browse/AMBARI-20813
>
>
> Repository: ambari
>
>
> Description
> -------
>
> See https://issues.apache.org/jira/browse/AMBARI-20813
>
>
> Diffs
> -----
>
> ambari-web/pom.xml 6182a60
>
>
> Diff: https://reviews.apache.org/r/58596/diff/1/
>
>
> Testing
> -------
>
> Tested locally to make sure that "mvn package" builds Ambari Web successfully.
>
> Ran ambari-web unit tests:
> 30380 passing (19s)
> 157 pending
>
>
> Thanks,
>
> Yusaku Sako
>
>
Re: Review Request 58596: AMBARI-20813. Convert ambari-web build
process to
use yarn package manager to fix dependencies and to make the process faster
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58596/
-----------------------------------------------------------
(Updated April 20, 2017, 10:43 p.m.)
Review request for Ambari, Jaimin Jetly and Vivek Ratnavel Subramanian.
Bugs: AMBARI-20813
https://issues.apache.org/jira/browse/AMBARI-20813
Repository: ambari
Description
-------
See https://issues.apache.org/jira/browse/AMBARI-20813
Diffs
-----
ambari-web/pom.xml 6182a60
Diff: https://reviews.apache.org/r/58596/diff/1/
Testing
-------
Tested locally to make sure that "mvn package" builds Ambari Web successfully.
Ran ambari-web unit tests:
30380 passing (19s)
157 pending
Thanks,
Yusaku Sako