You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by ma...@apache.org on 2022/02/04 08:02:21 UTC

[flink] 03/10: [hotfix] Refactors nested if statements

This is an automated email from the ASF dual-hosted git repository.

mapohl pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git

commit 12fb98ebe15ab8e1e18d270eb771b1b04c645639
Author: Matthias Pohl <ma...@ververica.com>
AuthorDate: Wed Dec 8 12:30:41 2021 +0100

    [hotfix] Refactors nested if statements
---
 .../org/apache/flink/runtime/dispatcher/Dispatcher.java  | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java b/flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
index d875be5..240ced5 100644
--- a/flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
+++ b/flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
@@ -497,17 +497,13 @@ public abstract class Dispatcher extends PermanentlyFencedRpcEndpoint<Dispatcher
 
     private CleanupJobState handleJobManagerRunnerResult(
             JobManagerRunnerResult jobManagerRunnerResult, ExecutionType executionType) {
-        if (jobManagerRunnerResult.isInitializationFailure()) {
-            if (executionType == ExecutionType.RECOVERY) {
-                return jobManagerRunnerFailed(
-                        jobManagerRunnerResult.getExecutionGraphInfo().getJobId(),
-                        jobManagerRunnerResult.getInitializationFailure());
-            } else {
-                return jobReachedTerminalState(jobManagerRunnerResult.getExecutionGraphInfo());
-            }
-        } else {
-            return jobReachedTerminalState(jobManagerRunnerResult.getExecutionGraphInfo());
+        if (jobManagerRunnerResult.isInitializationFailure()
+                && executionType == ExecutionType.RECOVERY) {
+            return jobManagerRunnerFailed(
+                    jobManagerRunnerResult.getExecutionGraphInfo().getJobId(),
+                    jobManagerRunnerResult.getInitializationFailure());
         }
+        return jobReachedTerminalState(jobManagerRunnerResult.getExecutionGraphInfo());
     }
 
     enum CleanupJobState {