[jira] [Commented] (RATIS-42) Shade netty in ratis

["Jing Zhao (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RATIS-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15930429#comment-15930429 ] 

Jing Zhao commented on RATIS-42:
--------------------------------

The patch looks good to me. One minor: the following change seems unnecessary:
{code}
-    <!-- dependency versions -->
-    <commons-io.version>2.4</commons-io.version>
-    <commons-lang.version>2.6</commons-lang.version>
....

-        <version>${commons-io.version}</version>
+        <version>2.4</version>
       </dependency>
 
       <dependency>
         <groupId>commons-lang</groupId>
         <artifactId>commons-lang</artifactId>
-        <version>${commons-lang.version}</version>
+        <version>2.6</version>
{code}



> Shade netty in ratis
> --------------------
>
>                 Key: RATIS-42
>                 URL: https://issues.apache.org/jira/browse/RATIS-42
>             Project: Ratis
>          Issue Type: Improvement
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>         Attachments: r42_20170315.patch, r42_20170316.patch
>
>
> We need to shade netty so that the user application can use a different version of netty.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)