You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-dev@incubator.apache.org by Gabrielle Crawford <ga...@oracle.com> on 2006/11/17 03:15:40 UTC
jsp mojo changes
Hi,
We are using the Trin Tag generator class GenerateJspTaglibsMojo.
However we want to add some custom code in the tag and tld.
I would like to make the following changes to GenerateJspTaglibsMojo,
does anyone have any objections
1] add 2 protected methods which are no-ops in Trinidad. These are each
called once in the class.
// hook for custom component tag java content
protected void writeCustomComponentTagHandlerContent(
PrettyWriter out,
ComponentBean component) throws IOException
{
}
// hook for custom component descriptor content
protected void writeCustomComponentTagDescriptorContent(
XMLStreamWriter stream,
ComponentBean component) throws IOException
{
}
2] Change _writeTagAttribute to be protected
3] All the injected property params are null when subclassing, so I need
to make them protected instead of private and set them from my subclass.
Thanks,
Gabrielle
Re: jsp mojo changes
Posted by Matthias Wessendorf <ma...@apache.org>.
I saw that,
just passed through your commit message.
On 11/17/06, Gabrielle Crawford <ga...@oracle.com> wrote:
> Thanks Matthias,
>
> This is issue 296.
>
> https://issues.apache.org/jira/browse/ADFFACES-296
>
> Thanks,
>
> Gab
>
> Matthias Wessendorf wrote:
>
> > I have no concerns in putting changes to the mojo file.
> >
> > -M
> >
> > On 11/17/06, Gabrielle Crawford <ga...@oracle.com> wrote:
> >
> >> Darn, found one more. Sorry this isn't more organized. There's actually
> >> one additional hook I need.
> >>
> >> // hook for custom component tag java imports
> >> protected void addCustomComponentTagHandlerImports(
> >> Set imports,
> >> ComponentBean component)
> >> {
> >> }
> >>
> >> Thanks,
> >>
> >> Gab
> >>
> >> Gabrielle Crawford wrote:
> >>
> >> > minor correction below.
> >> >
> >> > Gabrielle Crawford wrote:
> >> >
> >> >> Hi,
> >> >>
> >> >> We are using the Trin Tag generator class GenerateJspTaglibsMojo.
> >> >> However we want to add some custom code in the tag and tld.
> >> >>
> >> >> I would like to make the following changes to GenerateJspTaglibsMojo,
> >> >> does anyone have any objections
> >> >>
> >> >> 1] add 2 protected methods which are no-ops in Trinidad. These are
> >> >> each called once in the class.
> >> >>
> >> >> // hook for custom component tag java content
> >> >> protected void writeCustomComponentTagHandlerContent(
> >> >> PrettyWriter out,
> >> >> ComponentBean component) throws IOException
> >> >> {
> >> >> }
> >> >>
> >> >> // hook for custom component descriptor content
> >> >> protected void writeCustomComponentTagDescriptorContent(
> >> >> XMLStreamWriter stream,
> >> >> ComponentBean component) throws IOException
> >> >> {
> >> >> }
> >> >
> >> >
> >> > oops, that should say XMLStreamException, not IOException
> >> >
> >> >>
> >> >> 2] Change _writeTagAttribute to be protected
> >> >>
> >> >>
> >> >> 3] All the injected property params are null when subclassing, so I
> >> >> need to make them protected instead of private and set them from my
> >> >> subclass.
> >> >>
> >> >>
> >> >> Thanks,
> >> >>
> >> >> Gabrielle
> >> >>
> >> >>
> >> >
> >>
> >>
> >
> >
>
>
--
Matthias Wessendorf
http://tinyurl.com/fmywh
further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com
Re: jsp mojo changes
Posted by Gabrielle Crawford <ga...@oracle.com>.
Thanks Matthias,
This is issue 296.
https://issues.apache.org/jira/browse/ADFFACES-296
Thanks,
Gab
Matthias Wessendorf wrote:
> I have no concerns in putting changes to the mojo file.
>
> -M
>
> On 11/17/06, Gabrielle Crawford <ga...@oracle.com> wrote:
>
>> Darn, found one more. Sorry this isn't more organized. There's actually
>> one additional hook I need.
>>
>> // hook for custom component tag java imports
>> protected void addCustomComponentTagHandlerImports(
>> Set imports,
>> ComponentBean component)
>> {
>> }
>>
>> Thanks,
>>
>> Gab
>>
>> Gabrielle Crawford wrote:
>>
>> > minor correction below.
>> >
>> > Gabrielle Crawford wrote:
>> >
>> >> Hi,
>> >>
>> >> We are using the Trin Tag generator class GenerateJspTaglibsMojo.
>> >> However we want to add some custom code in the tag and tld.
>> >>
>> >> I would like to make the following changes to GenerateJspTaglibsMojo,
>> >> does anyone have any objections
>> >>
>> >> 1] add 2 protected methods which are no-ops in Trinidad. These are
>> >> each called once in the class.
>> >>
>> >> // hook for custom component tag java content
>> >> protected void writeCustomComponentTagHandlerContent(
>> >> PrettyWriter out,
>> >> ComponentBean component) throws IOException
>> >> {
>> >> }
>> >>
>> >> // hook for custom component descriptor content
>> >> protected void writeCustomComponentTagDescriptorContent(
>> >> XMLStreamWriter stream,
>> >> ComponentBean component) throws IOException
>> >> {
>> >> }
>> >
>> >
>> > oops, that should say XMLStreamException, not IOException
>> >
>> >>
>> >> 2] Change _writeTagAttribute to be protected
>> >>
>> >>
>> >> 3] All the injected property params are null when subclassing, so I
>> >> need to make them protected instead of private and set them from my
>> >> subclass.
>> >>
>> >>
>> >> Thanks,
>> >>
>> >> Gabrielle
>> >>
>> >>
>> >
>>
>>
>
>
Re: jsp mojo changes
Posted by Matthias Wessendorf <ma...@apache.org>.
I have no concerns in putting changes to the mojo file.
-M
On 11/17/06, Gabrielle Crawford <ga...@oracle.com> wrote:
> Darn, found one more. Sorry this isn't more organized. There's actually
> one additional hook I need.
>
> // hook for custom component tag java imports
> protected void addCustomComponentTagHandlerImports(
> Set imports,
> ComponentBean component)
> {
> }
>
> Thanks,
>
> Gab
>
> Gabrielle Crawford wrote:
>
> > minor correction below.
> >
> > Gabrielle Crawford wrote:
> >
> >> Hi,
> >>
> >> We are using the Trin Tag generator class GenerateJspTaglibsMojo.
> >> However we want to add some custom code in the tag and tld.
> >>
> >> I would like to make the following changes to GenerateJspTaglibsMojo,
> >> does anyone have any objections
> >>
> >> 1] add 2 protected methods which are no-ops in Trinidad. These are
> >> each called once in the class.
> >>
> >> // hook for custom component tag java content
> >> protected void writeCustomComponentTagHandlerContent(
> >> PrettyWriter out,
> >> ComponentBean component) throws IOException
> >> {
> >> }
> >>
> >> // hook for custom component descriptor content
> >> protected void writeCustomComponentTagDescriptorContent(
> >> XMLStreamWriter stream,
> >> ComponentBean component) throws IOException
> >> {
> >> }
> >
> >
> > oops, that should say XMLStreamException, not IOException
> >
> >>
> >> 2] Change _writeTagAttribute to be protected
> >>
> >>
> >> 3] All the injected property params are null when subclassing, so I
> >> need to make them protected instead of private and set them from my
> >> subclass.
> >>
> >>
> >> Thanks,
> >>
> >> Gabrielle
> >>
> >>
> >
>
>
--
Matthias Wessendorf
http://tinyurl.com/fmywh
further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com
Re: jsp mojo changes
Posted by Gabrielle Crawford <ga...@oracle.com>.
Darn, found one more. Sorry this isn't more organized. There's actually
one additional hook I need.
// hook for custom component tag java imports
protected void addCustomComponentTagHandlerImports(
Set imports,
ComponentBean component)
{
}
Thanks,
Gab
Gabrielle Crawford wrote:
> minor correction below.
>
> Gabrielle Crawford wrote:
>
>> Hi,
>>
>> We are using the Trin Tag generator class GenerateJspTaglibsMojo.
>> However we want to add some custom code in the tag and tld.
>>
>> I would like to make the following changes to GenerateJspTaglibsMojo,
>> does anyone have any objections
>>
>> 1] add 2 protected methods which are no-ops in Trinidad. These are
>> each called once in the class.
>>
>> // hook for custom component tag java content
>> protected void writeCustomComponentTagHandlerContent(
>> PrettyWriter out,
>> ComponentBean component) throws IOException
>> {
>> }
>>
>> // hook for custom component descriptor content
>> protected void writeCustomComponentTagDescriptorContent(
>> XMLStreamWriter stream,
>> ComponentBean component) throws IOException
>> {
>> }
>
>
> oops, that should say XMLStreamException, not IOException
>
>>
>> 2] Change _writeTagAttribute to be protected
>>
>>
>> 3] All the injected property params are null when subclassing, so I
>> need to make them protected instead of private and set them from my
>> subclass.
>>
>>
>> Thanks,
>>
>> Gabrielle
>>
>>
>
Re: jsp mojo changes
Posted by Gabrielle Crawford <ga...@oracle.com>.
minor correction below.
Gabrielle Crawford wrote:
> Hi,
>
> We are using the Trin Tag generator class GenerateJspTaglibsMojo.
> However we want to add some custom code in the tag and tld.
>
> I would like to make the following changes to GenerateJspTaglibsMojo,
> does anyone have any objections
>
> 1] add 2 protected methods which are no-ops in Trinidad. These are
> each called once in the class.
>
> // hook for custom component tag java content
> protected void writeCustomComponentTagHandlerContent(
> PrettyWriter out,
> ComponentBean component) throws IOException
> {
> }
>
> // hook for custom component descriptor content
> protected void writeCustomComponentTagDescriptorContent(
> XMLStreamWriter stream,
> ComponentBean component) throws IOException
> {
> }
oops, that should say XMLStreamException, not IOException
>
> 2] Change _writeTagAttribute to be protected
>
>
> 3] All the injected property params are null when subclassing, so I
> need to make them protected instead of private and set them from my
> subclass.
>
>
> Thanks,
>
> Gabrielle
>
>