You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Viknes B <vi...@msn.com> on 2012/10/01 23:21:07 UTC
Re: Review Request: Allow all openid users to login to Rave
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7175/
-----------------------------------------------------------
(Updated Oct. 1, 2012, 9:21 p.m.)
Review request for rave.
Changes
-------
Changed the authentication failure handling mechanism
Description
-------
OpenID users user their URL to login into Rave. Get a username from the user and register the user when he logs in for the first time.
This addresses bug Rave-775.
https://issues.apache.org/jira/browse/Rave-775
Diffs (updated)
-----
https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/pom.xml 1391513
https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/UserRepository.java 1391513
https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/UserService.java 1391513
https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultNewAccountService.java 1391513
https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultUserService.java 1391513
https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultUserServiceTest.java 1391513
https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaUser.java 1391513
https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/repository/impl/JpaUserRepository.java 1391513
https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/repository/impl/JpaUserRepositoryTest.java 1391513
https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/test/resources/test_data.sql 1391513
https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/NewAccountController.java 1391513
https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/OpenIDAuthenticationFailureHandler.java PRE-CREATION
https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ViewNames.java 1391513
https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/NewAccountControllerTest.java 1391513
https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/resources/messages.properties 1391513
https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/applicationContext-security.xml 1391513
https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/db/initial_data.sql 1391513
https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/includes/new_user_form.jsp 1391513
Diff: https://reviews.apache.org/r/7175/diff/
Testing
-------
Thanks,
Viknes B
Re: Review Request: Allow all openid users to login to Rave
Posted by Raminder Singh <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7175/#review12149
-----------------------------------------------------------
Ship it!
Patch is working well for me. Thanks Viknes.
- Raminder Singh
On Oct. 3, 2012, 7:13 p.m., Viknes B wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7175/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2012, 7:13 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> OpenID users user their URL to login into Rave. Get a username from the user and register the user when he logs in for the first time.
>
>
> This addresses bug Rave-775.
> https://issues.apache.org/jira/browse/Rave-775
>
>
> Diffs
> -----
>
> https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/pom.xml 1392555
> https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/UserRepository.java 1392555
> https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/UserService.java 1392555
> https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultNewAccountService.java 1392555
> https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultUserService.java 1392555
> https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultUserServiceTest.java 1392555
> https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaUser.java 1392555
> https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/repository/impl/JpaUserRepository.java 1392555
> https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/repository/impl/JpaUserRepositoryTest.java 1392555
> https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/test/resources/test_data.sql 1392555
> https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/NewAccountController.java 1392555
> https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/handler/OpenIDAuthenticationFailureHandler.java PRE-CREATION
> https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ViewNames.java 1392555
> https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/NewAccountControllerTest.java 1392555
> https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/handler/OpenIDAuthenticationFailureHandlerTest.java PRE-CREATION
> https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/resources/messages.properties 1392555
> https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/applicationContext-security.xml 1392555
> https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/db/initial_data.sql 1392555
> https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/includes/new_user_form.jsp 1392555
>
> Diff: https://reviews.apache.org/r/7175/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Viknes B
>
>
Re: Review Request: Allow all openid users to login to Rave
Posted by Viknes B <vi...@msn.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7175/
-----------------------------------------------------------
(Updated Oct. 3, 2012, 7:13 p.m.)
Review request for rave.
Changes
-------
Added more test cases
Description
-------
OpenID users user their URL to login into Rave. Get a username from the user and register the user when he logs in for the first time.
This addresses bug Rave-775.
https://issues.apache.org/jira/browse/Rave-775
Diffs (updated)
-----
https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/pom.xml 1392555
https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/UserRepository.java 1392555
https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/UserService.java 1392555
https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultNewAccountService.java 1392555
https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultUserService.java 1392555
https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultUserServiceTest.java 1392555
https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaUser.java 1392555
https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/repository/impl/JpaUserRepository.java 1392555
https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/repository/impl/JpaUserRepositoryTest.java 1392555
https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/test/resources/test_data.sql 1392555
https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/NewAccountController.java 1392555
https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/handler/OpenIDAuthenticationFailureHandler.java PRE-CREATION
https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ViewNames.java 1392555
https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/NewAccountControllerTest.java 1392555
https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/handler/OpenIDAuthenticationFailureHandlerTest.java PRE-CREATION
https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/resources/messages.properties 1392555
https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/applicationContext-security.xml 1392555
https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/db/initial_data.sql 1392555
https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/includes/new_user_form.jsp 1392555
Diff: https://reviews.apache.org/r/7175/diff/
Testing
-------
Thanks,
Viknes B