You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "Superskyyy (via GitHub)" <gi...@apache.org> on 2023/04/27 02:27:27 UTC
[GitHub] [skywalking] Superskyyy opened a new issue, #10737: [CI] Migrate from paths-filter to changed-files
Superskyyy opened a new issue, #10737:
URL: https://github.com/apache/skywalking/issues/10737
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
The dorny/paths-filter project we use in our CI to skip workflow steps is no longer actively maintained and @kezhenxu94 [suggested ](https://github.com/apache/skywalking/discussions/10604.) that we should replace it given its excessive warnings. Now I just found out a better alternative that can achieve the same but beyond simple filtering >>> https://github.com/tj-actions/changed-files
With this one we can save hours of wait time every week:
1. Omit unncessary CI runs within a single PR, i.e. doc polishing commits **since last successful workflow run**
2. build checkers to enforce the change of certain files (e.g. changelog.md) in some cases.
I believe we only got two repos to refactor for now, correct me if I'm wrong @kezhenxu94 and let me know if there are other repos that would benefit from this upgrade (maybe java agent?):
- [ ] OAP repo
- [ ] Python agent repo
### Use case
Unnecessary CI workflows will no longer execute.
### Related issues
_No response_
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] Nageshbansal commented on issue #10737: [CI] Migrate from paths-filter to changed-files
Posted by "Nageshbansal (via GitHub)" <gi...@apache.org>.
Nageshbansal commented on issue #10737:
URL: https://github.com/apache/skywalking/issues/10737#issuecomment-1555871604
Hey @Superskyyy @kezhenxu94 , has this issue been resolved? If not, I would like to give it a try and see if I can help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] Superskyyy commented on issue #10737: [CI] Migrate from paths-filter to changed-files
Posted by "Superskyyy (via GitHub)" <gi...@apache.org>.
Superskyyy commented on issue #10737:
URL: https://github.com/apache/skywalking/issues/10737#issuecomment-1541224556
> > This will be done before 18th, the settled date where GitHub starts to enforce node16.
> > [github.blog/changelog/2023-05-04-github-actions-all-actions-will-run-on-node16-instead-of-node12](https://github.blog/changelog/2023-05-04-github-actions-all-actions-will-run-on-node16-instead-of-node12)
>
> Do you have time to do that before 18th? I can help if needed
I'm very busy this week but I'm pretty sure I can do this over weekend. I will let you know if I cannot make it in time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #10737: [CI] Migrate from paths-filter to changed-files
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on issue #10737:
URL: https://github.com/apache/skywalking/issues/10737#issuecomment-1524499403
Added CLI to the list, though it uses getsentry/paths-filter, a forked of the GHA in problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] Superskyyy commented on issue #10737: [CI] Migrate from paths-filter to changed-files
Posted by "Superskyyy (via GitHub)" <gi...@apache.org>.
Superskyyy commented on issue #10737:
URL: https://github.com/apache/skywalking/issues/10737#issuecomment-1555951273
> Hey @Superskyyy @kezhenxu94 , has this issue been resolved? If not, I would like to give it a try and see if I can help.
Hi, the main repo is already migrated as you can see the draft PR is there.
And this issue is a mission critical migration that we have to do very carefully, so it's not open for contribution. Please feel free to find other issues labeled with good first issue if you would like.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #10737: [CI] Migrate from paths-filter to changed-files
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on issue #10737:
URL: https://github.com/apache/skywalking/issues/10737#issuecomment-1541162274
> This will be done before 18th, the settled date where GitHub starts to enforce node16.
> https://github.blog/changelog/2023-05-04-github-actions-all-actions-will-run-on-node16-instead-of-node12
Do you have time to do that before 18th? I can help if needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] Superskyyy commented on issue #10737: [CI] Migrate from paths-filter to changed-files
Posted by "Superskyyy (via GitHub)" <gi...@apache.org>.
Superskyyy commented on issue #10737:
URL: https://github.com/apache/skywalking/issues/10737#issuecomment-1538957550
This will be done before 17th, the settled date where GitHub starts to enforce node16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 closed issue #10737: [CI] Migrate from paths-filter to changed-files
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 closed issue #10737: [CI] Migrate from paths-filter to changed-files
URL: https://github.com/apache/skywalking/issues/10737
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org