You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/07/31 05:39:02 UTC

[GitHub] [tvm] junrushao1994 commented on a diff in pull request #12245: [Fix] Fix some errors in unittests

junrushao1994 commented on code in PR #12245:
URL: https://github.com/apache/tvm/pull/12245#discussion_r933928686


##########
tests/python/unittest/test_tir_transform_hoist_expression.py:
##########
@@ -448,7 +448,8 @@ class TestHoistLetExpr(BaseBeforeAfter):
     def before(A: T.Buffer[(4, 4), "float32"]):
         for i, j in T.grid(4, 4):
             x = T.var("float32")
-            A[i, j] = tir.Let(x, T.cast(i + 1, "float32"), 5.0 * x + T.cast(j, "float32"))
+            with T.let(x, T.cast(i + 1, "float32")):
+                A[i, j] = 5.0 * x + T.cast(j, "float32")

Review Comment:
   Are we changing the original let expression to TIR's let stmt?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org