[2/5] mesos git commit: Added UNREACHABLE() macro to __cxa_pure_virtual.

[bb...@apache.org]

Added UNREACHABLE() macro to __cxa_pure_virtual.

The function __cxa_pure_virtual must not return,
but newer versions of clang detect that the expansion
of the RAW_LOG() macro contains returning code paths
for arguments other than FATAL.

Review: https://reviews.apache.org/r/62444/


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/cd2774ef
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/cd2774ef
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/cd2774ef

Branch: refs/heads/master
Commit: cd2774efde5e55cc027721086af14fbc78688849
Parents: a892a2e
Author: Benno Evers <be...@mesosphere.com>
Authored: Tue Jan 23 14:47:28 2018 +0100
Committer: Benjamin Bannier <bb...@apache.org>
Committed: Tue Jan 23 14:47:28 2018 +0100

----------------------------------------------------------------------
 src/logging/logging.cpp | 2 ++
 1 file changed, 2 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/cd2774ef/src/logging/logging.cpp
----------------------------------------------------------------------
diff --git a/src/logging/logging.cpp b/src/logging/logging.cpp
index 19dba7f..8e03ac6 100644
--- a/src/logging/logging.cpp
+++ b/src/logging/logging.cpp
@@ -30,6 +30,7 @@
 #include <stout/path.hpp>
 #include <stout/stringify.hpp>
 #include <stout/try.hpp>
+#include <stout/unreachable.hpp>
 
 #ifndef __WINDOWS__
 #include <stout/os/signals.hpp>
@@ -66,6 +67,7 @@ using std::string;
 extern "C" void __cxa_pure_virtual()
 {
   RAW_LOG(FATAL, "Pure virtual method called");
+  UNREACHABLE();
 }