You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org> on 2008/10/14 12:07:44 UTC

[jira] Created: (HADOOP-4410) TestMiniMRDebugScript fails on trunk

TestMiniMRDebugScript fails on trunk
------------------------------------

                 Key: HADOOP-4410
                 URL: https://issues.apache.org/jira/browse/HADOOP-4410
             Project: Hadoop Core
          Issue Type: Bug
          Components: mapred
            Reporter: Amareshwari Sriramadasu
            Priority: Blocker


TestMiniMRDebugScript fails with following assertion error:
junit.framework.ComparisonFailure: expected:<Test Script
Bailing out> but was:<bash: /zonestorage/hudson/home/hudson/hudson/jobs/Hadoop-Patch/workspace/trunk/testscript: No such file or directory
bash: line 0: exec: /zonestorage/hudson/home/hudson/hudson/jobs/Hadoop-Patch/workspace/trunk/testscript: cannot execute: No such file or directory>
	at org.apache.hadoop.mapred.TestMiniMRMapRedDebugScript.testMapDebugScript(TestMiniMRMapRedDebugScript.java:207)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4410) TestMiniMRDebugScript fails on trunk

Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Devaraj Das updated HADOOP-4410:
--------------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

I just committed this. Thanks, Amareshwari!

> TestMiniMRDebugScript fails on trunk
> ------------------------------------
>
>                 Key: HADOOP-4410
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4410
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.19.0
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Amareshwari Sriramadasu
>            Priority: Blocker
>             Fix For: 0.19.0
>
>         Attachments: patch-4410.txt
>
>
> TestMiniMRDebugScript fails with following assertion error:
> junit.framework.ComparisonFailure: expected:<Test Script
> Bailing out> but was:<bash: /zonestorage/hudson/home/hudson/hudson/jobs/Hadoop-Patch/workspace/trunk/testscript: No such file or directory
> bash: line 0: exec: /zonestorage/hudson/home/hudson/hudson/jobs/Hadoop-Patch/workspace/trunk/testscript: cannot execute: No such file or directory>
> 	at org.apache.hadoop.mapred.TestMiniMRMapRedDebugScript.testMapDebugScript(TestMiniMRMapRedDebugScript.java:207)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4410) TestMiniMRDebugScript fails on trunk

Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639725#action_12639725 ] 

Amareshwari Sriramadasu commented on HADOOP-4410:
-------------------------------------------------

HADOOP-4014 changed the api FileUtil.makeShellPath(File) to consider the CanonicalPath for the File passed. TestMiniMRMapredDebugScript passes "./testscript" which should be expanded by the bash later. But the new api resolves the path earlier. 
The same problem can occur in streaming, with -mapper/-reducer commands given as relative path (relative to the working directory), which should be expanded later by the bash. 

One solution is to pass a boolean to the api to consider canonical path or not. And pass false by default. 
Then, the api looks like:
{noformat}
  public static String makeShellPath(File file) throws IOException {
    return makeShellPath(file, false);
  }
  public static String makeShellPath(File file, boolean makeCanonicalPath) throws IOException {
    if (makeCanonicalPath) {
      return makeShellPath(file.getCanonicalPath());
    } else {
      return makeShellPath(file.toString());
    }
  }
{noformat}

Thoughts?

> TestMiniMRDebugScript fails on trunk
> ------------------------------------
>
>                 Key: HADOOP-4410
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4410
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.19.0
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Amareshwari Sriramadasu
>            Priority: Blocker
>             Fix For: 0.19.0
>
>
> TestMiniMRDebugScript fails with following assertion error:
> junit.framework.ComparisonFailure: expected:<Test Script
> Bailing out> but was:<bash: /zonestorage/hudson/home/hudson/hudson/jobs/Hadoop-Patch/workspace/trunk/testscript: No such file or directory
> bash: line 0: exec: /zonestorage/hudson/home/hudson/hudson/jobs/Hadoop-Patch/workspace/trunk/testscript: cannot execute: No such file or directory>
> 	at org.apache.hadoop.mapred.TestMiniMRMapRedDebugScript.testMapDebugScript(TestMiniMRMapRedDebugScript.java:207)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4410) TestMiniMRDebugScript fails on trunk

Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639718#action_12639718 ] 

Devaraj Das commented on HADOOP-4410:
-------------------------------------

It looks like this is broken due to HADOOP-4014 commit. Actually, the test failed even in the hudson build of that patch. But I guess that was overlooked..

> TestMiniMRDebugScript fails on trunk
> ------------------------------------
>
>                 Key: HADOOP-4410
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4410
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.19.0
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Amareshwari Sriramadasu
>            Priority: Blocker
>             Fix For: 0.19.0
>
>
> TestMiniMRDebugScript fails with following assertion error:
> junit.framework.ComparisonFailure: expected:<Test Script
> Bailing out> but was:<bash: /zonestorage/hudson/home/hudson/hudson/jobs/Hadoop-Patch/workspace/trunk/testscript: No such file or directory
> bash: line 0: exec: /zonestorage/hudson/home/hudson/hudson/jobs/Hadoop-Patch/workspace/trunk/testscript: cannot execute: No such file or directory>
> 	at org.apache.hadoop.mapred.TestMiniMRMapRedDebugScript.testMapDebugScript(TestMiniMRMapRedDebugScript.java:207)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4410) TestMiniMRDebugScript fails on trunk

Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amareshwari Sriramadasu updated HADOOP-4410:
--------------------------------------------

    Attachment: patch-4410.txt

Patch modyfing the api as suggested.

> TestMiniMRDebugScript fails on trunk
> ------------------------------------
>
>                 Key: HADOOP-4410
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4410
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.19.0
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Amareshwari Sriramadasu
>            Priority: Blocker
>             Fix For: 0.19.0
>
>         Attachments: patch-4410.txt
>
>
> TestMiniMRDebugScript fails with following assertion error:
> junit.framework.ComparisonFailure: expected:<Test Script
> Bailing out> but was:<bash: /zonestorage/hudson/home/hudson/hudson/jobs/Hadoop-Patch/workspace/trunk/testscript: No such file or directory
> bash: line 0: exec: /zonestorage/hudson/home/hudson/hudson/jobs/Hadoop-Patch/workspace/trunk/testscript: cannot execute: No such file or directory>
> 	at org.apache.hadoop.mapred.TestMiniMRMapRedDebugScript.testMapDebugScript(TestMiniMRMapRedDebugScript.java:207)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4410) TestMiniMRDebugScript fails on trunk

Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amareshwari Sriramadasu updated HADOOP-4410:
--------------------------------------------

    Status: Patch Available  (was: Open)

test-patch result:
{noformat}
     [exec] -1 overall.
     [exec]
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec]
     [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
     [exec]                         Please justify why no tests are needed for this patch.
     [exec]
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec]
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec]
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec]
     [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
     [exec]
{noformat}

All core and contrib tests passed on machine.

    [junit] Running org.apache.hadoop.mapred.TestMiniMRMapRedDebugScript
    [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 41.46 sec


> TestMiniMRDebugScript fails on trunk
> ------------------------------------
>
>                 Key: HADOOP-4410
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4410
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.19.0
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Amareshwari Sriramadasu
>            Priority: Blocker
>             Fix For: 0.19.0
>
>         Attachments: patch-4410.txt
>
>
> TestMiniMRDebugScript fails with following assertion error:
> junit.framework.ComparisonFailure: expected:<Test Script
> Bailing out> but was:<bash: /zonestorage/hudson/home/hudson/hudson/jobs/Hadoop-Patch/workspace/trunk/testscript: No such file or directory
> bash: line 0: exec: /zonestorage/hudson/home/hudson/hudson/jobs/Hadoop-Patch/workspace/trunk/testscript: cannot execute: No such file or directory>
> 	at org.apache.hadoop.mapred.TestMiniMRMapRedDebugScript.testMapDebugScript(TestMiniMRMapRedDebugScript.java:207)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4410) TestMiniMRDebugScript fails on trunk

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639858#action_12639858 ] 

Hudson commented on HADOOP-4410:
--------------------------------

Integrated in Hadoop-trunk #634 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/634/])
    . Adds an extra arg to the API FileUtil.makeShellPath to determine whether to canonicalize file paths or not. Contributed by Amareshwari Sriramadasu.


> TestMiniMRDebugScript fails on trunk
> ------------------------------------
>
>                 Key: HADOOP-4410
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4410
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.19.0
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Amareshwari Sriramadasu
>            Priority: Blocker
>             Fix For: 0.19.0
>
>         Attachments: patch-4410.txt
>
>
> TestMiniMRDebugScript fails with following assertion error:
> junit.framework.ComparisonFailure: expected:<Test Script
> Bailing out> but was:<bash: /zonestorage/hudson/home/hudson/hudson/jobs/Hadoop-Patch/workspace/trunk/testscript: No such file or directory
> bash: line 0: exec: /zonestorage/hudson/home/hudson/hudson/jobs/Hadoop-Patch/workspace/trunk/testscript: cannot execute: No such file or directory>
> 	at org.apache.hadoop.mapred.TestMiniMRMapRedDebugScript.testMapDebugScript(TestMiniMRMapRedDebugScript.java:207)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HADOOP-4410) TestMiniMRDebugScript fails on trunk

Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Devaraj Das reassigned HADOOP-4410:
-----------------------------------

    Assignee: Amareshwari Sriramadasu

> TestMiniMRDebugScript fails on trunk
> ------------------------------------
>
>                 Key: HADOOP-4410
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4410
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.19.0
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Amareshwari Sriramadasu
>            Priority: Blocker
>             Fix For: 0.19.0
>
>
> TestMiniMRDebugScript fails with following assertion error:
> junit.framework.ComparisonFailure: expected:<Test Script
> Bailing out> but was:<bash: /zonestorage/hudson/home/hudson/hudson/jobs/Hadoop-Patch/workspace/trunk/testscript: No such file or directory
> bash: line 0: exec: /zonestorage/hudson/home/hudson/hudson/jobs/Hadoop-Patch/workspace/trunk/testscript: cannot execute: No such file or directory>
> 	at org.apache.hadoop.mapred.TestMiniMRMapRedDebugScript.testMapDebugScript(TestMiniMRMapRedDebugScript.java:207)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4410) TestMiniMRDebugScript fails on trunk

Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amareshwari Sriramadasu updated HADOOP-4410:
--------------------------------------------

    Affects Version/s: 0.19.0
        Fix Version/s: 0.19.0

Fails in 0.19 also.

> TestMiniMRDebugScript fails on trunk
> ------------------------------------
>
>                 Key: HADOOP-4410
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4410
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.19.0
>            Reporter: Amareshwari Sriramadasu
>            Priority: Blocker
>             Fix For: 0.19.0
>
>
> TestMiniMRDebugScript fails with following assertion error:
> junit.framework.ComparisonFailure: expected:<Test Script
> Bailing out> but was:<bash: /zonestorage/hudson/home/hudson/hudson/jobs/Hadoop-Patch/workspace/trunk/testscript: No such file or directory
> bash: line 0: exec: /zonestorage/hudson/home/hudson/hudson/jobs/Hadoop-Patch/workspace/trunk/testscript: cannot execute: No such file or directory>
> 	at org.apache.hadoop.mapred.TestMiniMRMapRedDebugScript.testMapDebugScript(TestMiniMRMapRedDebugScript.java:207)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.