You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "pseudo-nymous (via GitHub)" <gi...@apache.org> on 2025/01/04 13:55:05 UTC
[PR] Use github wf to add module labels for PR based on file changes [lucene]
pseudo-nymous opened a new pull request, #14101:
URL: https://github.com/apache/lucene/pull/14101
### Description
Adds a new bot to automate labelling of pull requests based file changes on the module.
This bot uses `.github/labeler.yml` file to maintain mapping for module tags to corresponding regex path to track.
This workflow is triggered using `pull_request_target` event which provides necessary write permission for adding labels to PRs. More details around this event: [StackOverflow](https://stackoverflow.com/questions/74957218/what-is-the-difference-between-pull-request-and-pull-request-target-event-in-git)
### Testing
Tested changes by creating pr on my own fork. https://github.com/pseudo-nymous/lucene/pull/2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Use github wf to add module labels for PR based on file changes [lucene]
Posted by "pseudo-nymous (via GitHub)" <gi...@apache.org>.
pseudo-nymous commented on code in PR #14101:
URL: https://github.com/apache/lucene/pull/14101#discussion_r1935130586
##########
.github/labeler.yml:
##########
@@ -0,0 +1,134 @@
+# This file defines module label mappings for the Lucene project.
+# Each module is associated with a set of file globs that, when matched,
+# will trigger the corresponding label to be applied to pull requests.
+#
+# This configuration is used by the workflow defined in .github/workflows/label-pull-request.yml.
+# If we are adding new labels or refactoring modules, we will need to modify this file globs here to ensure that the correct labels are applied.
+
+# For more information on how to use the `actions/checkout` action, visit:
Review Comment:
It's not relevant anymore. I'll remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Use github wf to add module labels for PR based on file changes [lucene]
Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss commented on PR #14101:
URL: https://github.com/apache/lucene/pull/14101#issuecomment-2910623550
I have a question - I have a fork of Lucene and create a pull request against that fork (not against the primary repo). This labeler action then fails because it - for some reason - lacks permissions (even though it's a pull request within the same fork...)
https://github.com/dweiss/lucene/actions/runs/15261679734/job/42920533660?pr=46
Is there any way to stop this workflow from running on forks or at least make it behave?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Use github wf to add module labels for PR based on file changes [lucene]
Posted by "pseudo-nymous (via GitHub)" <gi...@apache.org>.
pseudo-nymous commented on PR #14101:
URL: https://github.com/apache/lucene/pull/14101#issuecomment-2623829618
Did further testing with new sync flag, change is working as expected.
Ref: https://github.com/pseudo-nymous/lucene/pull/3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Use github wf to add module labels for PR based on file changes [lucene]
Posted by "mikemccand (via GitHub)" <gi...@apache.org>.
mikemccand commented on PR #14101:
URL: https://github.com/apache/lucene/pull/14101#issuecomment-2624467638
Wow, this looks really awesome! I wish we could retroactively apply it to PRs missing their module labels ... but let's start with this change (so new PRs are labeled).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Use github wf to add module labels for PR based on file changes [lucene]
Posted by "pseudo-nymous (via GitHub)" <gi...@apache.org>.
pseudo-nymous commented on PR #14101:
URL: https://github.com/apache/lucene/pull/14101#issuecomment-2629507768
Thanks.
I checked if same script could be used to label older PRs but there is no such event corresponding to already closed PR.
Maybe we can write an individual script which could process already closed PRs and label them. I will further explore on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Use github wf to add module labels for PR based on file changes [lucene]
Posted by "stefanvodita (via GitHub)" <gi...@apache.org>.
stefanvodita commented on PR #14101:
URL: https://github.com/apache/lucene/pull/14101#issuecomment-2629513783
Brilliant! Let us know if you find anything. If you're interesting in this area of GitHub workflows / community tools, there are a few others that would be great to do:
1. #13898
2. #14190
3. #13896
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Use github wf to add module labels for PR based on file changes [lucene]
Posted by "pseudo-nymous (via GitHub)" <gi...@apache.org>.
pseudo-nymous commented on PR #14101:
URL: https://github.com/apache/lucene/pull/14101#issuecomment-2629515885
I'll be happy to work on these. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Use github wf to add module labels for PR based on file changes [lucene]
Posted by "pseudo-nymous (via GitHub)" <gi...@apache.org>.
pseudo-nymous commented on code in PR #14101:
URL: https://github.com/apache/lucene/pull/14101#discussion_r1935132629
##########
.github/workflows/label-pull-request.yml:
##########
@@ -0,0 +1,21 @@
+# This file defines the workflow for labeling pull requests with module tags based on the changed files in the PR.
+# It uses the `actions/labeler` GitHub Action to achieve the same.
+#
+# The workflow is triggered on the `pull_request_target` event which ensures workflow is only run from the master branch.
+# The job `labeler` runs on `ubuntu-latest` and has permissions to read contents and write pull requests.
+#
+# For more information on the `actions/labeler` GitHub Action, refer to https://github.com/actions/labeler
+
+name: "Pull Request Labeler"
+run-name: Labelling pull request with module tags based on changed files in the PR
+on:
+ - pull_request_target
+
+jobs:
+ labeler:
Review Comment:
Great suggestion! I'll update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Use github wf to add module labels for PR based on file changes [lucene]
Posted by "pseudo-nymous (via GitHub)" <gi...@apache.org>.
pseudo-nymous commented on PR #14101:
URL: https://github.com/apache/lucene/pull/14101#issuecomment-2623844525
> This is great @pseudo-nymous! I left minor comments that I would like to see addressed, but this is very good already. I retract my concern about the action budget. This is running when a PR is created or updated, which is not that often.
Thanks.
Yes, this bot is only triggered when when pr is created or updated.
I have addressed all the comments. Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Use github wf to add module labels for PR based on file changes [lucene]
Posted by "stefanvodita (via GitHub)" <gi...@apache.org>.
stefanvodita commented on code in PR #14101:
URL: https://github.com/apache/lucene/pull/14101#discussion_r1934819611
##########
.github/workflows/label-pull-request.yml:
##########
@@ -0,0 +1,21 @@
+# This file defines the workflow for labeling pull requests with module tags based on the changed files in the PR.
+# It uses the `actions/labeler` GitHub Action to achieve the same.
+#
+# The workflow is triggered on the `pull_request_target` event which ensures workflow is only run from the master branch.
+# The job `labeler` runs on `ubuntu-latest` and has permissions to read contents and write pull requests.
+#
+# For more information on the `actions/labeler` GitHub Action, refer to https://github.com/actions/labeler
+
+name: "Pull Request Labeler"
+run-name: Labelling pull request with module tags based on changed files in the PR
+on:
+ - pull_request_target
+
+jobs:
+ labeler:
Review Comment:
Can we add `sync-labels` to make it so labels get removed when they are no longer valid after an update to the PR?
##########
.github/labeler.yml:
##########
@@ -0,0 +1,134 @@
+# This file defines module label mappings for the Lucene project.
+# Each module is associated with a set of file globs that, when matched,
+# will trigger the corresponding label to be applied to pull requests.
+#
+# This configuration is used by the workflow defined in .github/workflows/label-pull-request.yml.
+# If we are adding new labels or refactoring modules, we will need to modify this file globs here to ensure that the correct labels are applied.
+
+# For more information on how to use the `actions/checkout` action, visit:
Review Comment:
Is this relevant? I don't see us using `checkout` here.
##########
.github/labeler.yml:
##########
@@ -0,0 +1,134 @@
+# This file defines module label mappings for the Lucene project.
+# Each module is associated with a set of file globs that, when matched,
+# will trigger the corresponding label to be applied to pull requests.
+#
+# This configuration is used by the workflow defined in .github/workflows/label-pull-request.yml.
+# If we are adding new labels or refactoring modules, we will need to modify this file globs here to ensure that the correct labels are applied.
+
+# For more information on how to use the `actions/checkout` action, visit:
+# https://github.com/actions/checkout
+
+module:analysis:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/analysis/**'
+
+module:benchmark:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/benchmark/**'
+
+module:classification:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/classification/**'
+
+module:core/codecs:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/core/src/java/org/apache/lucene/codecs/**', 'lucene/core/src/test/org/apache/lucene/codecs/**']
+
+module:core/FSTs:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/core/src/java/org/apache/lucene/util/fst/**', 'lucene/core/src/test/org/apache/lucene/util/fst/**']
+
+module:core/hnsw:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/core/src/java/org/apache/lucene/util/hnsw/**', 'lucene/core/src/test/org/apache/lucene/util/hnsw/**']
+
+module:core/index:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/core/src/java/org/apache/lucene/index/**', 'lucene/core/src/test/org/apache/lucene/index/**']
+
+module:core/search:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/core/src/java/org/apache/lucene/search/**', 'lucene/core/src/test/org/apache/lucene/search/**']
+
+module:core/store:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/core/src/java/org/apache/lucene/store/**', 'lucene/core/src/test/org/apache/lucene/store/**']
+
+module:core/other:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/core/**']
+ - all-globs-to-all-files:
+ - '!lucene/core/src/java/org/apache/lucene/codecs/**'
+ - '!lucene/core/src/test/org/apache/lucene/codecs/**'
+ - '!lucene/core/src/java/org/apache/lucene/util/fst/**'
+ - '!lucene/core/src/test/org/apache/lucene/util/fst/**'
+ - '!lucene/core/src/java/org/apache/lucene/util/hnsw/**'
+ - '!lucene/core/src/test/org/apache/lucene/util/hnsw/**'
+ - '!lucene/core/src/java/org/apache/lucene/index/**'
+ - '!lucene/core/src/test/org/apache/lucene/index/**'
+ - '!lucene/core/src/java/org/apache/lucene/search/**'
+ - '!lucene/core/src/test/org/apache/lucene/search/**'
+ - '!lucene/core/src/java/org/apache/lucene/store/**'
+ - '!lucene/core/src/test/org/apache/lucene/store/**'
+
+module:demo:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/demo/**'
+
+module:expressions:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/expressions/**'
+
+module:facet:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/facet/**'
+
+module:grouping:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/grouping/**'
+
+module:highlighter:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/highlighter/**'
+
+module:join:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/join/**'
+
+module:luke:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/luke/**'
+
+module:misc:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/misc/**'
+
+module:monitor:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/monitor/**'
+
+module:queries:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/queries/**'
+
+module:queryparser:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/queryparser/**'
+
+module:replicator:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/replicator/**'
+
+module:sandbox:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/sandbox/**'
+
+module:spatial:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/spatial-extras/**', 'lucene/spatial-test-fixtures/**']
+
+module:spatial3d:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/spatial3d/**'
+
+module:spatial-extras:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/spatial-extras/**'
Review Comment:
Curious - why give this its own label and the `module:spatial` label as well?
##########
.github/labeler.yml:
##########
@@ -0,0 +1,134 @@
+# This file defines module label mappings for the Lucene project.
+# Each module is associated with a set of file globs that, when matched,
+# will trigger the corresponding label to be applied to pull requests.
+#
+# This configuration is used by the workflow defined in .github/workflows/label-pull-request.yml.
+# If we are adding new labels or refactoring modules, we will need to modify this file globs here to ensure that the correct labels are applied.
+
+# For more information on how to use the `actions/checkout` action, visit:
+# https://github.com/actions/checkout
+
+module:analysis:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/analysis/**'
+
+module:benchmark:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/benchmark/**'
+
+module:classification:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/classification/**'
+
+module:core/codecs:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/core/src/java/org/apache/lucene/codecs/**', 'lucene/core/src/test/org/apache/lucene/codecs/**']
+
+module:core/FSTs:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/core/src/java/org/apache/lucene/util/fst/**', 'lucene/core/src/test/org/apache/lucene/util/fst/**']
+
+module:core/hnsw:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/core/src/java/org/apache/lucene/util/hnsw/**', 'lucene/core/src/test/org/apache/lucene/util/hnsw/**']
+
+module:core/index:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/core/src/java/org/apache/lucene/index/**', 'lucene/core/src/test/org/apache/lucene/index/**']
+
+module:core/search:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/core/src/java/org/apache/lucene/search/**', 'lucene/core/src/test/org/apache/lucene/search/**']
+
+module:core/store:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/core/src/java/org/apache/lucene/store/**', 'lucene/core/src/test/org/apache/lucene/store/**']
+
+module:core/other:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/core/**']
+ - all-globs-to-all-files:
Review Comment:
Cool!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Use github wf to add module labels for PR based on file changes [lucene]
Posted by "stefanvodita (via GitHub)" <gi...@apache.org>.
stefanvodita commented on PR #14101:
URL: https://github.com/apache/lucene/pull/14101#issuecomment-2622114022
@pseudo-nymous, I'm only seeing this now, sorry! At first glance, it matches what I had in mind - thank you for addressing that issue! I'll do an in-depth review soon, but I'd appreciate others' thoughts as well. One potential concern is our GitHub action budget - do you have a sense of the cost of this workflow?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Use github wf to add module labels for PR based on file changes [lucene]
Posted by "stefanvodita (via GitHub)" <gi...@apache.org>.
stefanvodita commented on PR #14101:
URL: https://github.com/apache/lucene/pull/14101#issuecomment-2918941880
Linking the PR related to the question above: #14721.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Use github wf to add module labels for PR based on file changes [lucene]
Posted by "pseudo-nymous (via GitHub)" <gi...@apache.org>.
pseudo-nymous commented on code in PR #14101:
URL: https://github.com/apache/lucene/pull/14101#discussion_r1935129051
##########
.github/labeler.yml:
##########
@@ -0,0 +1,134 @@
+# This file defines module label mappings for the Lucene project.
+# Each module is associated with a set of file globs that, when matched,
+# will trigger the corresponding label to be applied to pull requests.
+#
+# This configuration is used by the workflow defined in .github/workflows/label-pull-request.yml.
+# If we are adding new labels or refactoring modules, we will need to modify this file globs here to ensure that the correct labels are applied.
+
+# For more information on how to use the `actions/checkout` action, visit:
+# https://github.com/actions/checkout
+
+module:analysis:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/analysis/**'
+
+module:benchmark:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/benchmark/**'
+
+module:classification:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/classification/**'
+
+module:core/codecs:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/core/src/java/org/apache/lucene/codecs/**', 'lucene/core/src/test/org/apache/lucene/codecs/**']
+
+module:core/FSTs:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/core/src/java/org/apache/lucene/util/fst/**', 'lucene/core/src/test/org/apache/lucene/util/fst/**']
+
+module:core/hnsw:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/core/src/java/org/apache/lucene/util/hnsw/**', 'lucene/core/src/test/org/apache/lucene/util/hnsw/**']
+
+module:core/index:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/core/src/java/org/apache/lucene/index/**', 'lucene/core/src/test/org/apache/lucene/index/**']
+
+module:core/search:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/core/src/java/org/apache/lucene/search/**', 'lucene/core/src/test/org/apache/lucene/search/**']
+
+module:core/store:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/core/src/java/org/apache/lucene/store/**', 'lucene/core/src/test/org/apache/lucene/store/**']
+
+module:core/other:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/core/**']
+ - all-globs-to-all-files:
+ - '!lucene/core/src/java/org/apache/lucene/codecs/**'
+ - '!lucene/core/src/test/org/apache/lucene/codecs/**'
+ - '!lucene/core/src/java/org/apache/lucene/util/fst/**'
+ - '!lucene/core/src/test/org/apache/lucene/util/fst/**'
+ - '!lucene/core/src/java/org/apache/lucene/util/hnsw/**'
+ - '!lucene/core/src/test/org/apache/lucene/util/hnsw/**'
+ - '!lucene/core/src/java/org/apache/lucene/index/**'
+ - '!lucene/core/src/test/org/apache/lucene/index/**'
+ - '!lucene/core/src/java/org/apache/lucene/search/**'
+ - '!lucene/core/src/test/org/apache/lucene/search/**'
+ - '!lucene/core/src/java/org/apache/lucene/store/**'
+ - '!lucene/core/src/test/org/apache/lucene/store/**'
+
+module:demo:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/demo/**'
+
+module:expressions:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/expressions/**'
+
+module:facet:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/facet/**'
+
+module:grouping:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/grouping/**'
+
+module:highlighter:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/highlighter/**'
+
+module:join:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/join/**'
+
+module:luke:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/luke/**'
+
+module:misc:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/misc/**'
+
+module:monitor:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/monitor/**'
+
+module:queries:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/queries/**'
+
+module:queryparser:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/queryparser/**'
+
+module:replicator:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/replicator/**'
+
+module:sandbox:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/sandbox/**'
+
+module:spatial:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/spatial-extras/**', 'lucene/spatial-test-fixtures/**']
+
+module:spatial3d:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/spatial3d/**'
+
+module:spatial-extras:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/spatial-extras/**'
Review Comment:
It was a miss. I'll remove `lucene/spatial-extras/**` from `module:spatial` label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Use github wf to add module labels for PR based on file changes [lucene]
Posted by "pseudo-nymous (via GitHub)" <gi...@apache.org>.
pseudo-nymous commented on code in PR #14101:
URL: https://github.com/apache/lucene/pull/14101#discussion_r1935416351
##########
.github/labeler.yml:
##########
@@ -0,0 +1,134 @@
+# This file defines module label mappings for the Lucene project.
+# Each module is associated with a set of file globs that, when matched,
+# will trigger the corresponding label to be applied to pull requests.
+#
+# This configuration is used by the workflow defined in .github/workflows/label-pull-request.yml.
+# If we are adding new labels or refactoring modules, we will need to modify this file globs here to ensure that the correct labels are applied.
+
+# For more information on how to use the `actions/checkout` action, visit:
+# https://github.com/actions/checkout
+
+module:analysis:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/analysis/**'
+
+module:benchmark:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/benchmark/**'
+
+module:classification:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/classification/**'
+
+module:core/codecs:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/core/src/java/org/apache/lucene/codecs/**', 'lucene/core/src/test/org/apache/lucene/codecs/**']
+
+module:core/FSTs:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/core/src/java/org/apache/lucene/util/fst/**', 'lucene/core/src/test/org/apache/lucene/util/fst/**']
+
+module:core/hnsw:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/core/src/java/org/apache/lucene/util/hnsw/**', 'lucene/core/src/test/org/apache/lucene/util/hnsw/**']
+
+module:core/index:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/core/src/java/org/apache/lucene/index/**', 'lucene/core/src/test/org/apache/lucene/index/**']
+
+module:core/search:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/core/src/java/org/apache/lucene/search/**', 'lucene/core/src/test/org/apache/lucene/search/**']
+
+module:core/store:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/core/src/java/org/apache/lucene/store/**', 'lucene/core/src/test/org/apache/lucene/store/**']
+
+module:core/other:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/core/**']
+ - all-globs-to-all-files:
+ - '!lucene/core/src/java/org/apache/lucene/codecs/**'
+ - '!lucene/core/src/test/org/apache/lucene/codecs/**'
+ - '!lucene/core/src/java/org/apache/lucene/util/fst/**'
+ - '!lucene/core/src/test/org/apache/lucene/util/fst/**'
+ - '!lucene/core/src/java/org/apache/lucene/util/hnsw/**'
+ - '!lucene/core/src/test/org/apache/lucene/util/hnsw/**'
+ - '!lucene/core/src/java/org/apache/lucene/index/**'
+ - '!lucene/core/src/test/org/apache/lucene/index/**'
+ - '!lucene/core/src/java/org/apache/lucene/search/**'
+ - '!lucene/core/src/test/org/apache/lucene/search/**'
+ - '!lucene/core/src/java/org/apache/lucene/store/**'
+ - '!lucene/core/src/test/org/apache/lucene/store/**'
+
+module:demo:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/demo/**'
+
+module:expressions:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/expressions/**'
+
+module:facet:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/facet/**'
+
+module:grouping:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/grouping/**'
+
+module:highlighter:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/highlighter/**'
+
+module:join:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/join/**'
+
+module:luke:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/luke/**'
+
+module:misc:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/misc/**'
+
+module:monitor:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/monitor/**'
+
+module:queries:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/queries/**'
+
+module:queryparser:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/queryparser/**'
+
+module:replicator:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/replicator/**'
+
+module:sandbox:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/sandbox/**'
+
+module:spatial:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/spatial-extras/**', 'lucene/spatial-test-fixtures/**']
+
+module:spatial3d:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/spatial3d/**'
+
+module:spatial-extras:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/spatial-extras/**'
Review Comment:
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Use github wf to add module labels for PR based on file changes [lucene]
Posted by "stefanvodita (via GitHub)" <gi...@apache.org>.
stefanvodita commented on PR #14101:
URL: https://github.com/apache/lucene/pull/14101#issuecomment-2629498867
Thank you for this contribution @pseudo-nymous, I merged it just now and I'm really looking forward to see the first PR using it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Use github wf to add module labels for PR based on file changes [lucene]
Posted by "stefanvodita (via GitHub)" <gi...@apache.org>.
stefanvodita merged PR #14101:
URL: https://github.com/apache/lucene/pull/14101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Use github wf to add module labels for PR based on file changes [lucene]
Posted by "pseudo-nymous (via GitHub)" <gi...@apache.org>.
pseudo-nymous commented on code in PR #14101:
URL: https://github.com/apache/lucene/pull/14101#discussion_r1935253167
##########
.github/labeler.yml:
##########
@@ -0,0 +1,134 @@
+# This file defines module label mappings for the Lucene project.
+# Each module is associated with a set of file globs that, when matched,
+# will trigger the corresponding label to be applied to pull requests.
+#
+# This configuration is used by the workflow defined in .github/workflows/label-pull-request.yml.
+# If we are adding new labels or refactoring modules, we will need to modify this file globs here to ensure that the correct labels are applied.
+
+# For more information on how to use the `actions/checkout` action, visit:
+# https://github.com/actions/checkout
+
+module:analysis:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/analysis/**'
+
+module:benchmark:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/benchmark/**'
+
+module:classification:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/classification/**'
+
+module:core/codecs:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/core/src/java/org/apache/lucene/codecs/**', 'lucene/core/src/test/org/apache/lucene/codecs/**']
+
+module:core/FSTs:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/core/src/java/org/apache/lucene/util/fst/**', 'lucene/core/src/test/org/apache/lucene/util/fst/**']
+
+module:core/hnsw:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/core/src/java/org/apache/lucene/util/hnsw/**', 'lucene/core/src/test/org/apache/lucene/util/hnsw/**']
+
+module:core/index:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/core/src/java/org/apache/lucene/index/**', 'lucene/core/src/test/org/apache/lucene/index/**']
+
+module:core/search:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/core/src/java/org/apache/lucene/search/**', 'lucene/core/src/test/org/apache/lucene/search/**']
+
+module:core/store:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/core/src/java/org/apache/lucene/store/**', 'lucene/core/src/test/org/apache/lucene/store/**']
+
+module:core/other:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/core/**']
+ - all-globs-to-all-files:
+ - '!lucene/core/src/java/org/apache/lucene/codecs/**'
+ - '!lucene/core/src/test/org/apache/lucene/codecs/**'
+ - '!lucene/core/src/java/org/apache/lucene/util/fst/**'
+ - '!lucene/core/src/test/org/apache/lucene/util/fst/**'
+ - '!lucene/core/src/java/org/apache/lucene/util/hnsw/**'
+ - '!lucene/core/src/test/org/apache/lucene/util/hnsw/**'
+ - '!lucene/core/src/java/org/apache/lucene/index/**'
+ - '!lucene/core/src/test/org/apache/lucene/index/**'
+ - '!lucene/core/src/java/org/apache/lucene/search/**'
+ - '!lucene/core/src/test/org/apache/lucene/search/**'
+ - '!lucene/core/src/java/org/apache/lucene/store/**'
+ - '!lucene/core/src/test/org/apache/lucene/store/**'
+
+module:demo:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/demo/**'
+
+module:expressions:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/expressions/**'
+
+module:facet:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/facet/**'
+
+module:grouping:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/grouping/**'
+
+module:highlighter:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/highlighter/**'
+
+module:join:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/join/**'
+
+module:luke:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/luke/**'
+
+module:misc:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/misc/**'
+
+module:monitor:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/monitor/**'
+
+module:queries:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/queries/**'
+
+module:queryparser:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/queryparser/**'
+
+module:replicator:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/replicator/**'
+
+module:sandbox:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/sandbox/**'
+
+module:spatial:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/spatial-extras/**', 'lucene/spatial-test-fixtures/**']
+
+module:spatial3d:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/spatial3d/**'
+
+module:spatial-extras:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/spatial-extras/**'
Review Comment:
I see. It makes sense to have it in `module:spatial` label itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Use github wf to add module labels for PR based on file changes [lucene]
Posted by "stefanvodita (via GitHub)" <gi...@apache.org>.
stefanvodita commented on code in PR #14101:
URL: https://github.com/apache/lucene/pull/14101#discussion_r1935220020
##########
.github/labeler.yml:
##########
@@ -0,0 +1,134 @@
+# This file defines module label mappings for the Lucene project.
+# Each module is associated with a set of file globs that, when matched,
+# will trigger the corresponding label to be applied to pull requests.
+#
+# This configuration is used by the workflow defined in .github/workflows/label-pull-request.yml.
+# If we are adding new labels or refactoring modules, we will need to modify this file globs here to ensure that the correct labels are applied.
+
+# For more information on how to use the `actions/checkout` action, visit:
+# https://github.com/actions/checkout
+
+module:analysis:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/analysis/**'
+
+module:benchmark:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/benchmark/**'
+
+module:classification:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/classification/**'
+
+module:core/codecs:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/core/src/java/org/apache/lucene/codecs/**', 'lucene/core/src/test/org/apache/lucene/codecs/**']
+
+module:core/FSTs:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/core/src/java/org/apache/lucene/util/fst/**', 'lucene/core/src/test/org/apache/lucene/util/fst/**']
+
+module:core/hnsw:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/core/src/java/org/apache/lucene/util/hnsw/**', 'lucene/core/src/test/org/apache/lucene/util/hnsw/**']
+
+module:core/index:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/core/src/java/org/apache/lucene/index/**', 'lucene/core/src/test/org/apache/lucene/index/**']
+
+module:core/search:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/core/src/java/org/apache/lucene/search/**', 'lucene/core/src/test/org/apache/lucene/search/**']
+
+module:core/store:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/core/src/java/org/apache/lucene/store/**', 'lucene/core/src/test/org/apache/lucene/store/**']
+
+module:core/other:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/core/**']
+ - all-globs-to-all-files:
+ - '!lucene/core/src/java/org/apache/lucene/codecs/**'
+ - '!lucene/core/src/test/org/apache/lucene/codecs/**'
+ - '!lucene/core/src/java/org/apache/lucene/util/fst/**'
+ - '!lucene/core/src/test/org/apache/lucene/util/fst/**'
+ - '!lucene/core/src/java/org/apache/lucene/util/hnsw/**'
+ - '!lucene/core/src/test/org/apache/lucene/util/hnsw/**'
+ - '!lucene/core/src/java/org/apache/lucene/index/**'
+ - '!lucene/core/src/test/org/apache/lucene/index/**'
+ - '!lucene/core/src/java/org/apache/lucene/search/**'
+ - '!lucene/core/src/test/org/apache/lucene/search/**'
+ - '!lucene/core/src/java/org/apache/lucene/store/**'
+ - '!lucene/core/src/test/org/apache/lucene/store/**'
+
+module:demo:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/demo/**'
+
+module:expressions:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/expressions/**'
+
+module:facet:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/facet/**'
+
+module:grouping:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/grouping/**'
+
+module:highlighter:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/highlighter/**'
+
+module:join:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/join/**'
+
+module:luke:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/luke/**'
+
+module:misc:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/misc/**'
+
+module:monitor:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/monitor/**'
+
+module:queries:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/queries/**'
+
+module:queryparser:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/queryparser/**'
+
+module:replicator:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/replicator/**'
+
+module:sandbox:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/sandbox/**'
+
+module:spatial:
+ - changed-files:
+ - any-glob-to-any-file: ['lucene/spatial-extras/**', 'lucene/spatial-test-fixtures/**']
+
+module:spatial3d:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/spatial3d/**'
+
+module:spatial-extras:
+ - changed-files:
+ - any-glob-to-any-file: 'lucene/spatial-extras/**'
Review Comment:
Sorry, I should have made a recommendation. I think it would be better to list both paths under `module:spatial` and not have `module:spatial-extras` at all. `spatial-extras` is really the core spatial module ([overview](https://github.com/apache/lucene/blob/main/lucene/spatial-extras/src/java/overview.html)).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Use github wf to add module labels for PR based on file changes [lucene]
Posted by "stefanvodita (via GitHub)" <gi...@apache.org>.
stefanvodita commented on PR #14101:
URL: https://github.com/apache/lucene/pull/14101#issuecomment-2636455151
I've seen new PRs get labels assigned. I like how it's working!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org