[GitHub] [httpcomponents-core] ok2c commented on a change in pull request #274: HTTPCORE-671: URIBuilder does not precent-encode bracketed IPv6 addre…

[GitBox <gi...@apache.org>]

ok2c commented on a change in pull request #274:
URL: https://github.com/apache/httpcomponents-core/pull/274#discussion_r600588526



##########
File path: httpcore5/src/main/java/org/apache/hc/core5/net/InetAddressUtils.java
##########
@@ -137,6 +137,18 @@ public static boolean isIPv6Address(final String input) {
         return isIPv6StdAddress(input) || isIPv6HexCompressedAddress(input);
     }
 
+    /**
+     * Checks whether the parameter is a valid rfc2732 url formatted bracketed IPv6 address (including compressed).

Review comment:
       @carterkozak I would rather avoid referencing RFCs in class names and in javadocs at all. RFCs can get superseded by a newer version and one would have to scan the source for references to outdated documents.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org