You are viewing a plain text version of this content. The canonical link for it is here.
Posted to axis-cvs@ws.apache.org by di...@apache.org on 2008/01/23 21:43:25 UTC

svn commit: r614657 - in /webservices/axis2/trunk/java/modules/clustering/src/org/apache/axis2/clustering/tribes: TribesClusterManager.java TribesUtil.java

Author: dims
Date: Wed Jan 23 12:43:23 2008
New Revision: 614657

URL: http://svn.apache.org/viewvc?rev=614657&view=rev
Log:
fix trailing . in the ip address, add a log.info as well

Modified:
    webservices/axis2/trunk/java/modules/clustering/src/org/apache/axis2/clustering/tribes/TribesClusterManager.java
    webservices/axis2/trunk/java/modules/clustering/src/org/apache/axis2/clustering/tribes/TribesUtil.java

Modified: webservices/axis2/trunk/java/modules/clustering/src/org/apache/axis2/clustering/tribes/TribesClusterManager.java
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/clustering/src/org/apache/axis2/clustering/tribes/TribesClusterManager.java?rev=614657&r1=614656&r2=614657&view=diff
==============================================================================
--- webservices/axis2/trunk/java/modules/clustering/src/org/apache/axis2/clustering/tribes/TribesClusterManager.java (original)
+++ webservices/axis2/trunk/java/modules/clustering/src/org/apache/axis2/clustering/tribes/TribesClusterManager.java Wed Jan 23 12:43:23 2008
@@ -276,6 +276,7 @@
                             membershipManager.getLongestLivingMember() : // First try to get from the longest member alive
                             membershipManager.getRandomMember(); // Else get from a random member
             String memberHost = TribesUtil.getHost(member);
+            log.info("Trying to send to : [" + member.getName() + "][" + memberHost + "]");
             try {
                 if (!sentMembersList.contains(memberHost)) {
                     Response[] responses = rpcChannel.send(new Member[]{member},

Modified: webservices/axis2/trunk/java/modules/clustering/src/org/apache/axis2/clustering/tribes/TribesUtil.java
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/clustering/src/org/apache/axis2/clustering/tribes/TribesUtil.java?rev=614657&r1=614656&r2=614657&view=diff
==============================================================================
--- webservices/axis2/trunk/java/modules/clustering/src/org/apache/axis2/clustering/tribes/TribesUtil.java (original)
+++ webservices/axis2/trunk/java/modules/clustering/src/org/apache/axis2/clustering/tribes/TribesUtil.java Wed Jan 23 12:43:23 2008
@@ -49,7 +49,10 @@
         if (hostBytes != null) {
             for (int i = 0; i < hostBytes.length; i++) {
                 int hostByte = hostBytes[i] >= 0 ? (int) hostBytes[i] : (int) hostBytes[i] + 256;
-                host.append(hostByte).append(".");
+                host.append(hostByte);
+                if(i < hostBytes.length-1) {
+                    host.append(".");
+                }
             }
         }
         return host.append(":").append(member.getPort()).toString();



---------------------------------------------------------------------
To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-cvs-help@ws.apache.org


Re: svn commit: r614657 - in /webservices/axis2/trunk/java/modules/clustering/src/org/apache/axis2/clustering/tribes: TribesClusterManager.java TribesUtil.java

Posted by Afkham Azeez <af...@gmail.com>.
Hi Dims,
member.getName()  in Tribes tries to do a reverse DNS lookup. On some boxes
which this is not properly configured, this causes the instance to hang. You
will see this when you have no NW connectivity and are doing a multicast
using the local interface i.e. "route add -net 224.0.0.0 netmask
240.0.0.0dev lo"

See Filip's commit to Tribes,
http://svn.apache.org/viewvc?view=rev&revision=612192

Thanks
Azeez

On Jan 24, 2008 2:13 AM, <di...@apache.org> wrote:

> Author: dims
> Date: Wed Jan 23 12:43:23 2008
> New Revision: 614657
>
> URL: http://svn.apache.org/viewvc?rev=614657&view=rev
> Log:
> fix trailing . in the ip address, add a log.info as well
>
> Modified:
>
>  webservices/axis2/trunk/java/modules/clustering/src/org/apache/axis2/clustering/tribes/TribesClusterManager.java
>
>  webservices/axis2/trunk/java/modules/clustering/src/org/apache/axis2/clustering/tribes/TribesUtil.java
>
> Modified:
> webservices/axis2/trunk/java/modules/clustering/src/org/apache/axis2/clustering/tribes/TribesClusterManager.java
> URL:
> http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/clustering/src/org/apache/axis2/clustering/tribes/TribesClusterManager.java?rev=614657&r1=614656&r2=614657&view=diff
>
> ==============================================================================
> ---
> webservices/axis2/trunk/java/modules/clustering/src/org/apache/axis2/clustering/tribes/TribesClusterManager.java
> (original)
> +++
> webservices/axis2/trunk/java/modules/clustering/src/org/apache/axis2/clustering/tribes/TribesClusterManager.java
> Wed Jan 23 12:43:23 2008
> @@ -276,6 +276,7 @@
>                             membershipManager.getLongestLivingMember() :
> // First try to get from the longest member alive
>                             membershipManager.getRandomMember(); // Else
> get from a random member
>             String memberHost = TribesUtil.getHost(member);
> +            log.info("Trying to send to : [" + member.getName() + "][" +
> memberHost + "]");
>             try {
>                 if (!sentMembersList.contains(memberHost)) {
>                     Response[] responses = rpcChannel.send(new
> Member[]{member},
>
> Modified:
> webservices/axis2/trunk/java/modules/clustering/src/org/apache/axis2/clustering/tribes/TribesUtil.java
> URL:
> http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/clustering/src/org/apache/axis2/clustering/tribes/TribesUtil.java?rev=614657&r1=614656&r2=614657&view=diff
>
> ==============================================================================
> ---
> webservices/axis2/trunk/java/modules/clustering/src/org/apache/axis2/clustering/tribes/TribesUtil.java
> (original)
> +++
> webservices/axis2/trunk/java/modules/clustering/src/org/apache/axis2/clustering/tribes/TribesUtil.java
> Wed Jan 23 12:43:23 2008
> @@ -49,7 +49,10 @@
>         if (hostBytes != null) {
>             for (int i = 0; i < hostBytes.length; i++) {
>                 int hostByte = hostBytes[i] >= 0 ? (int) hostBytes[i] :
> (int) hostBytes[i] + 256;
> -                host.append(hostByte).append(".");
> +                host.append(hostByte);
> +                if(i < hostBytes.length-1) {
> +                    host.append(".");
> +                }
>             }
>         }
>         return host.append(":").append(member.getPort()).toString();
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
> For additional commands, e-mail: axis-cvs-help@ws.apache.org
>
>


-- 
Thanks
Afkham Azeez

http://azeez78.blogspot.com
http://www.wso2.org
GPG Fingerprint: 643F C2AF EB78 F886 40C9  B2A2 4AE2 C887 665E 0760