You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by MaxGekk <gi...@git.apache.org> on 2018/05/23 21:29:24 UTC

[GitHub] spark pull request #20929: [SPARK-23772][SQL] Provide an option to ignore co...

Github user MaxGekk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20929#discussion_r190397868
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ---
    @@ -379,6 +379,8 @@ class DataFrameReader private[sql](sparkSession: SparkSession) extends Logging {
        * that should be used for parsing.</li>
        * <li>`samplingRatio` (default is 1.0): defines fraction of input JSON objects used
        * for schema inferring.</li>
    +   * <li>`dropFieldIfAllNull` (default `false`): whether to ignore column of all null values or
    --- End diff --
    
    How about [DataStreamReader](https://github.com/maropu/spark/blob/SPARK-23772/sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamReader.scala#L277)? I guess the description should be added to it too.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org