You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Veena Basavaraj <vb...@cloudera.com> on 2014/11/06 15:31:47 UTC
Review Request 27679: SQOOP-1687:Single resource in JSON should not
be a list
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27679/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SOOOP-1687
https://issues.apache.org/jira/browse/SOOOP-1687
Repository: sqoop-sqoop2
Description
-------
see jira
Diffs
-----
common/src/main/java/org/apache/sqoop/json/ConnectorBean.java 845cafa
common/src/main/java/org/apache/sqoop/json/JobBean.java efc2efc
common/src/main/java/org/apache/sqoop/json/LinkBean.java ae3a4ff
common/src/main/java/org/apache/sqoop/json/SubmissionBean.java b7bdaad
common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java 308e17e
common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 7c3c921
Diff: https://reviews.apache.org/r/27679/diff/
Testing
-------
yes, all tests including integ pass
Thanks,
Veena Basavaraj
Re: Review Request 27679: SQOOP-1687:Single resource in JSON should
not be a list
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Nov. 6, 2014, 11:03 a.m., Abraham Elmahrek wrote:
> > Tests for SubmissionBean and JobBean?
done
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27679/#review60202
-----------------------------------------------------------
On Nov. 6, 2014, 6:53 a.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27679/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2014, 6:53 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SOOOP-1687
> https://issues.apache.org/jira/browse/SOOOP-1687
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/json/ConnectorBean.java 845cafa
> common/src/main/java/org/apache/sqoop/json/JobBean.java efc2efc
> common/src/main/java/org/apache/sqoop/json/LinkBean.java ae3a4ff
> common/src/main/java/org/apache/sqoop/json/SubmissionBean.java b7bdaad
> common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java 308e17e
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 7c3c921
>
> Diff: https://reviews.apache.org/r/27679/diff/
>
>
> Testing
> -------
>
> yes, all tests including integ pass
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27679: SQOOP-1687:Single resource in JSON should
not be a list
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Nov. 6, 2014, 11:03 a.m., Abraham Elmahrek wrote:
> > Tests for SubmissionBean and JobBean?
>
> Veena Basavaraj wrote:
> done
the submission bean tests are entangled with submiison and submisisons, there are already tests, its bette to create a ticket for it if you want them separated
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27679/#review60202
-----------------------------------------------------------
On Nov. 6, 2014, 6:53 a.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27679/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2014, 6:53 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SOOOP-1687
> https://issues.apache.org/jira/browse/SOOOP-1687
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/json/ConnectorBean.java 845cafa
> common/src/main/java/org/apache/sqoop/json/JobBean.java efc2efc
> common/src/main/java/org/apache/sqoop/json/LinkBean.java ae3a4ff
> common/src/main/java/org/apache/sqoop/json/SubmissionBean.java b7bdaad
> common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java 308e17e
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 7c3c921
>
> Diff: https://reviews.apache.org/r/27679/diff/
>
>
> Testing
> -------
>
> yes, all tests including integ pass
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27679: SQOOP-1687:Single resource in JSON should
not be a list
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27679/#review60202
-----------------------------------------------------------
Ship it!
Tests for SubmissionBean and JobBean?
common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java
<https://reviews.apache.org/r/27679/#comment101580>
Should probably have TestConnectorsBean as well.
common/src/test/java/org/apache/sqoop/json/TestLinkBean.java
<https://reviews.apache.org/r/27679/#comment101577>
Should probably have TestLinksBean as well.
common/src/test/java/org/apache/sqoop/json/TestLinkBean.java
<https://reviews.apache.org/r/27679/#comment101567>
add new line to separate the two.
- Abraham Elmahrek
On Nov. 6, 2014, 2:53 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27679/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2014, 2:53 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SOOOP-1687
> https://issues.apache.org/jira/browse/SOOOP-1687
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/json/ConnectorBean.java 845cafa
> common/src/main/java/org/apache/sqoop/json/JobBean.java efc2efc
> common/src/main/java/org/apache/sqoop/json/LinkBean.java ae3a4ff
> common/src/main/java/org/apache/sqoop/json/SubmissionBean.java b7bdaad
> common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java 308e17e
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 7c3c921
>
> Diff: https://reviews.apache.org/r/27679/diff/
>
>
> Testing
> -------
>
> yes, all tests including integ pass
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27679: SQOOP-1687:Single resource in JSON should
not be a list
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Nov. 6, 2014, 1:34 p.m., Abraham Elmahrek wrote:
> > ``BeanTestUtil`` is missing license header. Otherwise, looks good.
roger that.
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27679/#review60247
-----------------------------------------------------------
On Nov. 6, 2014, 12:22 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27679/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2014, 12:22 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SOOOP-1687
> https://issues.apache.org/jira/browse/SOOOP-1687
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d7e0cea
> common/src/main/java/org/apache/sqoop/json/DriverBean.java 0e3f872
> common/src/main/java/org/apache/sqoop/json/JobBean.java 0c258aa
> common/src/main/java/org/apache/sqoop/json/JsonBean.java 8797015
> common/src/main/java/org/apache/sqoop/json/LinkBean.java 368a56c
> common/src/main/java/org/apache/sqoop/json/SubmissionBean.java b7bdaad
> common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java 30778f5
> common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java 308e17e
> common/src/test/java/org/apache/sqoop/json/TestConnectorsBean.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/json/TestDriverBean.java 8c92aef
> common/src/test/java/org/apache/sqoop/json/TestJobBean.java 923ad47
> common/src/test/java/org/apache/sqoop/json/TestJobsBean.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 7c7d2ab
> common/src/test/java/org/apache/sqoop/json/TestLinksBean.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java c5b8781
> common/src/test/java/org/apache/sqoop/json/util/BeanTestUtil.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/json/util/ConfigTestUtil.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27679/diff/
>
>
> Testing
> -------
>
> yes, all tests including integ pass
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27679: SQOOP-1687:Single resource in JSON should
not be a list
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27679/#review60247
-----------------------------------------------------------
Ship it!
``BeanTestUtil`` is missing license header. Otherwise, looks good.
- Abraham Elmahrek
On Nov. 6, 2014, 8:22 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27679/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2014, 8:22 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SOOOP-1687
> https://issues.apache.org/jira/browse/SOOOP-1687
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d7e0cea
> common/src/main/java/org/apache/sqoop/json/DriverBean.java 0e3f872
> common/src/main/java/org/apache/sqoop/json/JobBean.java 0c258aa
> common/src/main/java/org/apache/sqoop/json/JsonBean.java 8797015
> common/src/main/java/org/apache/sqoop/json/LinkBean.java 368a56c
> common/src/main/java/org/apache/sqoop/json/SubmissionBean.java b7bdaad
> common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java 30778f5
> common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java 308e17e
> common/src/test/java/org/apache/sqoop/json/TestConnectorsBean.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/json/TestDriverBean.java 8c92aef
> common/src/test/java/org/apache/sqoop/json/TestJobBean.java 923ad47
> common/src/test/java/org/apache/sqoop/json/TestJobsBean.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 7c7d2ab
> common/src/test/java/org/apache/sqoop/json/TestLinksBean.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java c5b8781
> common/src/test/java/org/apache/sqoop/json/util/BeanTestUtil.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/json/util/ConfigTestUtil.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27679/diff/
>
>
> Testing
> -------
>
> yes, all tests including integ pass
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27679: SQOOP-1687:Single resource in JSON should
not be a list
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27679/
-----------------------------------------------------------
(Updated Nov. 6, 2014, 1:39 p.m.)
Review request for Sqoop.
Bugs: SOOOP-1687
https://issues.apache.org/jira/browse/SOOOP-1687
Repository: sqoop-sqoop2
Description
-------
see jira
Diffs (updated)
-----
common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d7e0cea
common/src/main/java/org/apache/sqoop/json/DriverBean.java 0e3f872
common/src/main/java/org/apache/sqoop/json/JobBean.java 0c258aa
common/src/main/java/org/apache/sqoop/json/JsonBean.java 8797015
common/src/main/java/org/apache/sqoop/json/LinkBean.java 368a56c
common/src/main/java/org/apache/sqoop/json/SubmissionBean.java b7bdaad
common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java 30778f5
common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java 308e17e
common/src/test/java/org/apache/sqoop/json/TestConnectorsBean.java PRE-CREATION
common/src/test/java/org/apache/sqoop/json/TestDriverBean.java 8c92aef
common/src/test/java/org/apache/sqoop/json/TestJobBean.java 923ad47
common/src/test/java/org/apache/sqoop/json/TestJobsBean.java PRE-CREATION
common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 7c7d2ab
common/src/test/java/org/apache/sqoop/json/TestLinksBean.java PRE-CREATION
common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java c5b8781
common/src/test/java/org/apache/sqoop/json/util/BeanTestUtil.java PRE-CREATION
common/src/test/java/org/apache/sqoop/json/util/ConfigTestUtil.java PRE-CREATION
Diff: https://reviews.apache.org/r/27679/diff/
Testing
-------
yes, all tests including integ pass
Thanks,
Veena Basavaraj
Re: Review Request 27679: SQOOP-1687:Single resource in JSON should
not be a list
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27679/
-----------------------------------------------------------
(Updated Nov. 6, 2014, 12:22 p.m.)
Review request for Sqoop.
Bugs: SOOOP-1687
https://issues.apache.org/jira/browse/SOOOP-1687
Repository: sqoop-sqoop2
Description
-------
see jira
Diffs (updated)
-----
common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d7e0cea
common/src/main/java/org/apache/sqoop/json/DriverBean.java 0e3f872
common/src/main/java/org/apache/sqoop/json/JobBean.java 0c258aa
common/src/main/java/org/apache/sqoop/json/JsonBean.java 8797015
common/src/main/java/org/apache/sqoop/json/LinkBean.java 368a56c
common/src/main/java/org/apache/sqoop/json/SubmissionBean.java b7bdaad
common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java 30778f5
common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java 308e17e
common/src/test/java/org/apache/sqoop/json/TestConnectorsBean.java PRE-CREATION
common/src/test/java/org/apache/sqoop/json/TestDriverBean.java 8c92aef
common/src/test/java/org/apache/sqoop/json/TestJobBean.java 923ad47
common/src/test/java/org/apache/sqoop/json/TestJobsBean.java PRE-CREATION
common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 7c7d2ab
common/src/test/java/org/apache/sqoop/json/TestLinksBean.java PRE-CREATION
common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java c5b8781
common/src/test/java/org/apache/sqoop/json/util/BeanTestUtil.java PRE-CREATION
common/src/test/java/org/apache/sqoop/json/util/ConfigTestUtil.java PRE-CREATION
Diff: https://reviews.apache.org/r/27679/diff/
Testing
-------
yes, all tests including integ pass
Thanks,
Veena Basavaraj
Re: Review Request 27679: SQOOP-1687:Single resource in JSON should
not be a list
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27679/
-----------------------------------------------------------
(Updated Nov. 6, 2014, 12:17 p.m.)
Review request for Sqoop.
Bugs: SOOOP-1687
https://issues.apache.org/jira/browse/SOOOP-1687
Repository: sqoop-sqoop2
Description
-------
see jira
Diffs (updated)
-----
common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d7e0cea
common/src/main/java/org/apache/sqoop/json/DriverBean.java 0e3f872
common/src/main/java/org/apache/sqoop/json/JobBean.java 0c258aa
common/src/main/java/org/apache/sqoop/json/JsonBean.java 8797015
common/src/main/java/org/apache/sqoop/json/LinkBean.java 368a56c
common/src/main/java/org/apache/sqoop/json/SubmissionBean.java b7bdaad
common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java 30778f5
common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java 308e17e
common/src/test/java/org/apache/sqoop/json/TestConnectorsBean.java PRE-CREATION
common/src/test/java/org/apache/sqoop/json/TestDriverBean.java 8c92aef
common/src/test/java/org/apache/sqoop/json/TestJobBean.java 923ad47
common/src/test/java/org/apache/sqoop/json/TestJobsBean.java PRE-CREATION
common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 7c7d2ab
common/src/test/java/org/apache/sqoop/json/TestLinksBean.java PRE-CREATION
common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java c5b8781
common/src/test/java/org/apache/sqoop/json/util/BeanTestUtil.java PRE-CREATION
common/src/test/java/org/apache/sqoop/json/util/ConfigTestUtil.java PRE-CREATION
Diff: https://reviews.apache.org/r/27679/diff/
Testing
-------
yes, all tests including integ pass
Thanks,
Veena Basavaraj
Re: Review Request 27679: SQOOP-1687:Single resource in JSON should
not be a list
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27679/
-----------------------------------------------------------
(Updated Nov. 6, 2014, 6:53 a.m.)
Review request for Sqoop.
Changes
-------
added some unit tests for links/ link and connectors/connector use case that was missed earlier.
Bugs: SOOOP-1687
https://issues.apache.org/jira/browse/SOOOP-1687
Repository: sqoop-sqoop2
Description
-------
see jira
Diffs (updated)
-----
common/src/main/java/org/apache/sqoop/json/ConnectorBean.java 845cafa
common/src/main/java/org/apache/sqoop/json/JobBean.java efc2efc
common/src/main/java/org/apache/sqoop/json/LinkBean.java ae3a4ff
common/src/main/java/org/apache/sqoop/json/SubmissionBean.java b7bdaad
common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java 308e17e
common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 7c3c921
Diff: https://reviews.apache.org/r/27679/diff/
Testing
-------
yes, all tests including integ pass
Thanks,
Veena Basavaraj