You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Ivan Lyutov <iv...@gmail.com> on 2014/04/04 18:27:29 UTC
Review Request 20030: Patch for KAFKA-1352
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20030/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1352
https://issues.apache.org/jira/browse/KAFKA-1352
Repository: kafka
Description
-------
KAFKA-1352 - Reduce logging on the server
Merge remote-tracking branch 'apache/trunk' into trunk
Merge branch 'trunk' of git://git.apache.org/kafka into trunk
[KAFKA-1344] - comment edits. Minor refactoring.
[KAFKA-1344] - removed --compress option since it's redundant. Added --compression-codec argument support to OldProducer as well.
[KAFKA-1344] - Added compression codec option feature for ConsoleProducer
Diffs
-----
core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala ff5e81943e10ef37de16f657aeecc25e17d3e83a
core/src/main/scala/kafka/server/AbstractFetcherThread.scala db7017b8a8ff06384674f36792053e4bc68419f1
core/src/main/scala/kafka/server/KafkaApis.scala c068ef69207c351eec413a595f1747c59f8b3983
Diff: https://reviews.apache.org/r/20030/diff/
Testing
-------
Thanks,
Ivan Lyutov
Re: Review Request 20030: Patch for KAFKA-1352
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20030/#review39714
-----------------------------------------------------------
Ship it!
Ship It!
- Guozhang Wang
On April 4, 2014, 6:20 p.m., Ivan Lyutov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20030/
> -----------------------------------------------------------
>
> (Updated April 4, 2014, 6:20 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1352
> https://issues.apache.org/jira/browse/KAFKA-1352
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1352 - Reduce logging on the server. Logging improvement.
>
>
> KAFKA-1352 - Reduce logging on the server
>
>
> Merge remote-tracking branch 'apache/trunk' into trunk
>
>
> Merge branch 'trunk' of git://git.apache.org/kafka into trunk
>
>
> [KAFKA-1344] - comment edits. Minor refactoring.
>
>
> [KAFKA-1344] - removed --compress option since it's redundant. Added --compression-codec argument support to OldProducer as well.
>
>
> [KAFKA-1344] - Added compression codec option feature for ConsoleProducer
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala ff5e81943e10ef37de16f657aeecc25e17d3e83a
> core/src/main/scala/kafka/server/AbstractFetcherThread.scala db7017b8a8ff06384674f36792053e4bc68419f1
> core/src/main/scala/kafka/server/KafkaApis.scala c068ef69207c351eec413a595f1747c59f8b3983
>
> Diff: https://reviews.apache.org/r/20030/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ivan Lyutov
>
>
Re: Review Request 20030: Patch for KAFKA-1352
Posted by Ivan Lyutov <iv...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20030/
-----------------------------------------------------------
(Updated April 4, 2014, 6:20 p.m.)
Review request for kafka.
Bugs: KAFKA-1352
https://issues.apache.org/jira/browse/KAFKA-1352
Repository: kafka
Description (updated)
-------
KAFKA-1352 - Reduce logging on the server. Logging improvement.
KAFKA-1352 - Reduce logging on the server
Merge remote-tracking branch 'apache/trunk' into trunk
Merge branch 'trunk' of git://git.apache.org/kafka into trunk
[KAFKA-1344] - comment edits. Minor refactoring.
[KAFKA-1344] - removed --compress option since it's redundant. Added --compression-codec argument support to OldProducer as well.
[KAFKA-1344] - Added compression codec option feature for ConsoleProducer
Diffs (updated)
-----
core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala ff5e81943e10ef37de16f657aeecc25e17d3e83a
core/src/main/scala/kafka/server/AbstractFetcherThread.scala db7017b8a8ff06384674f36792053e4bc68419f1
core/src/main/scala/kafka/server/KafkaApis.scala c068ef69207c351eec413a595f1747c59f8b3983
Diff: https://reviews.apache.org/r/20030/diff/
Testing
-------
Thanks,
Ivan Lyutov
Re: Review Request 20030: Patch for KAFKA-1352
Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20030/#review39555
-----------------------------------------------------------
Thanks for the patch. Some comments below.
core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala
<https://reviews.apache.org/r/20030/#comment71967>
We don't need to log the stacktrace, but it will still be useful to log e.getMessage().
This probably should be warn instead of error.
core/src/main/scala/kafka/server/AbstractFetcherThread.scala
<https://reviews.apache.org/r/20030/#comment71961>
We don't need to log the stacktrace, but it will still be useful to log t.getMessage().
Also, this can be in warn, instead of error.
core/src/main/scala/kafka/server/KafkaApis.scala
<https://reviews.apache.org/r/20030/#comment71962>
We don't need to log the stacktrace, but it will still be useful to log t.getMessage().
core/src/main/scala/kafka/server/KafkaApis.scala
<https://reviews.apache.org/r/20030/#comment71963>
We don't need to log the stacktrace, but it will still be useful to log t.getMessage().
Also, I think this can be in debug instead of error.
- Jun Rao
On April 4, 2014, 4:27 p.m., Ivan Lyutov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20030/
> -----------------------------------------------------------
>
> (Updated April 4, 2014, 4:27 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1352
> https://issues.apache.org/jira/browse/KAFKA-1352
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1352 - Reduce logging on the server
>
>
> Merge remote-tracking branch 'apache/trunk' into trunk
>
>
> Merge branch 'trunk' of git://git.apache.org/kafka into trunk
>
>
> [KAFKA-1344] - comment edits. Minor refactoring.
>
>
> [KAFKA-1344] - removed --compress option since it's redundant. Added --compression-codec argument support to OldProducer as well.
>
>
> [KAFKA-1344] - Added compression codec option feature for ConsoleProducer
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala ff5e81943e10ef37de16f657aeecc25e17d3e83a
> core/src/main/scala/kafka/server/AbstractFetcherThread.scala db7017b8a8ff06384674f36792053e4bc68419f1
> core/src/main/scala/kafka/server/KafkaApis.scala c068ef69207c351eec413a595f1747c59f8b3983
>
> Diff: https://reviews.apache.org/r/20030/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ivan Lyutov
>
>