You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2018/02/23 22:37:48 UTC
Review Request 65786: Prevented Docker library from terminating
incorrect processes.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65786/
-----------------------------------------------------------
Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.
Bugs: MESOS-8575
https://issues.apache.org/jira/browse/MESOS-8575
Repository: mesos
Description
-------
Previously, the Docker library might call `os::killtree()` on a
PID after the associated subprocess had already terminated, which
could lead to an unknown process being incorrectly killed.
Diffs
-----
src/docker/docker.cpp 3df370e988fce12d323ff6b441da15dab27bdd28
Diff: https://reviews.apache.org/r/65786/diff/1/
Testing
-------
Testing details are found later in this chain.
Thanks,
Greg Mann
Re: Review Request 65786: Prevented Docker library from terminating
incorrect processes.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65786/#review198228
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On Feb. 23, 2018, 2:37 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65786/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2018, 2:37 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.
>
>
> Bugs: MESOS-8575
> https://issues.apache.org/jira/browse/MESOS-8575
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, the Docker library might call `os::killtree()` on a
> PID after the associated subprocess had already terminated, which
> could lead to an unknown process being incorrectly killed.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp 3df370e988fce12d323ff6b441da15dab27bdd28
>
>
> Diff: https://reviews.apache.org/r/65786/diff/1/
>
>
> Testing
> -------
>
> Testing details are found later in this chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 65786: Prevented Docker library from terminating
incorrect processes.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65786/#review198223
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Feb. 23, 2018, 2:37 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65786/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2018, 2:37 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.
>
>
> Bugs: MESOS-8575
> https://issues.apache.org/jira/browse/MESOS-8575
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, the Docker library might call `os::killtree()` on a
> PID after the associated subprocess had already terminated, which
> could lead to an unknown process being incorrectly killed.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp 3df370e988fce12d323ff6b441da15dab27bdd28
>
>
> Diff: https://reviews.apache.org/r/65786/diff/1/
>
>
> Testing
> -------
>
> Testing details are found later in this chain.
>
>
> Thanks,
>
> Greg Mann
>
>