You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by ib...@apache.org on 2020/05/08 18:24:06 UTC
[beam] branch master updated: [BEAM-4782] Remove workaround in
Python multimap tests.
This is an automated email from the ASF dual-hosted git repository.
ibzib pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git
The following commit(s) were added to refs/heads/master by this push:
new dd9d73d [BEAM-4782] Remove workaround in Python multimap tests.
new d82d061 Merge pull request #11643 from ibzib/BEAM-4782
dd9d73d is described below
commit dd9d73d2f97d1e6d5256603550e8046d85e68f8d
Author: Kyle Weaver <kc...@google.com>
AuthorDate: Thu May 7 14:46:35 2020 -0700
[BEAM-4782] Remove workaround in Python multimap tests.
---
.../runners/portability/fn_api_runner/fn_runner_test.py | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner_test.py b/sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner_test.py
index 1f7dcb5..9f1b3b1 100644
--- a/sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner_test.py
+++ b/sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner_test.py
@@ -231,10 +231,7 @@ class FnApiRunnerTest(unittest.TestCase):
def test_multimap_side_input(self):
with self.create_pipeline() as p:
main = p | 'main' >> beam.Create(['a', 'b'])
- side = (
- p | 'side' >> beam.Create([('a', 1), ('b', 2), ('a', 3)])
- # TODO(BEAM-4782): Obviate the need for this map.
- | beam.Map(lambda kv: (kv[0], kv[1])))
+ side = p | 'side' >> beam.Create([('a', 1), ('b', 2), ('a', 3)])
assert_that(
main | beam.Map(
lambda k, d: (k, sorted(d[k])), beam.pvalue.AsMultiMap(side)),
@@ -245,10 +242,7 @@ class FnApiRunnerTest(unittest.TestCase):
# twice as side input.
with self.create_pipeline() as p:
main = p | 'main' >> beam.Create(['a', 'b'])
- side = (
- p | 'side' >> beam.Create([('a', 1), ('b', 2), ('a', 3)])
- # TODO(BEAM-4782): Obviate the need for this map.
- | beam.Map(lambda kv: (kv[0], kv[1])))
+ side = p | 'side' >> beam.Create([('a', 1), ('b', 2), ('a', 3)])
assert_that(
main | 'first map' >> beam.Map(
lambda k,