[GitHub] [apisix] spacewander commented on a diff in pull request #7043: chore: improve the implementation of pubsub module

[GitBox <gi...@apache.org>]

spacewander commented on code in PR #7043:
URL: https://github.com/apache/apisix/pull/7043#discussion_r872186304


##########
apisix/core/pubsub.lua:
##########
@@ -119,8 +138,8 @@ end
 -- no error exists.
 --
 -- @function core.pubsub.on
--- @tparam string command to add callback
--- @tparam function handler callback on receipt of command
+-- @tparam string The command to add callback.

Review Comment:
   ```suggestion
   -- @tparam string command The command to add callback.
   ```



##########
.github/workflows/build.yml:
##########
@@ -31,8 +31,8 @@ jobs:
           - linux_openresty_1_17
         test_dir:
           - t/plugin
-          - t/admin t/cli t/config-center-yaml t/control t/core t/debug t/discovery t/error_page t/misc t/pubsub
-          - t/node t/router t/script t/stream-node t/utils t/wasm t/xds-library t/xrpc
+          - t/admin t/cli t/config-center-yaml t/control t/core t/debug t/discovery t/error_page t/misc
+          - t/node t/pubsub t/router t/script t/stream-node t/utils t/wasm t/xds-library t/xrpc

Review Comment:
   pubsub < node



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org