You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by "acelyc111 (via GitHub)" <gi...@apache.org> on 2023/09/12 14:25:02 UTC

[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1597: fix(duplication): fix slog gc crash

acelyc111 commented on code in PR #1597:
URL: https://github.com/apache/incubator-pegasus/pull/1597#discussion_r1323127988


##########
src/replica/replica.h:
##########
@@ -633,6 +639,7 @@ class replica : public serverlet<replica>, public ref_counter, public replica_ba
     bool _is_manual_emergency_checkpointing{false};
     bool _is_duplication_master{false};
     bool _is_duplication_follower{false};
+    std::atomic<bool> _is_duplication_plog_checking{false};

Review Comment:
   Where will the variable be used?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org