You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/30 08:58:34 UTC

[GitHub] [flink] dianfu commented on a change in pull request #13855: [FLINK-19894][python] Use iloc for positional slicing instead of direct slicing in from_pandas

dianfu commented on a change in pull request #13855:
URL: https://github.com/apache/flink/pull/13855#discussion_r514952639



##########
File path: flink-python/pyflink/table/tests/test_pandas_conversion.py
##########
@@ -132,6 +132,12 @@ def test_from_pandas(self):
                             "1970-01-01 00:00:00.123,[hello, 中文],1,hello,"
                             "1970-01-01 00:00:00.123,[1, 2]"])
 
+    def test_from_pandas_with_float_index(self):

Review comment:
       Is it possible integrate this test case into an existing test case? Then we could avoid introduce another IT case.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org