[jira] [Commented] (LENS-67) jdbc: queries with alias names for tables are not rewritten correctly

["Sreekanth Ramakrishnan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LENS-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14229393#comment-14229393 ] 

Sreekanth Ramakrishnan commented on LENS-67:
--------------------------------------------

Hi Sushil,

Took a look at your patch. You have made too many formatting changes, can you just reformat the section of the code which you actually changed instead of entire file?

It is never a good idea to make unrelated changes in a patch as it rewrites history when you are doing a git blame making it difficult to figure out why this change was made in a patch which had nothing to do with it.

Thanks.

> jdbc: queries with alias names for tables are not rewritten correctly 
> ----------------------------------------------------------------------
>
>                 Key: LENS-67
>                 URL: https://issues.apache.org/jira/browse/LENS-67
>             Project: Apache Lens
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: Raghavendra Singh
>            Assignee: Sushil Mohanty
>             Fix For: 2.0
>
>         Attachments: LENS-67.patch
>
>
> Cube Query:-
> {CODE}
> cube SELECT d.dim1 AS d1, c.attr1 AS m1 from cube as c, dim as d where time_range_in(col,'from','to') GROUP BY d.dim1 limit 10
> {CODE}
> Error:-
> {CODE}
> Table 'db.a' doesn't exist cause:null
> {CODE}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)