You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/08 20:25:31 UTC

[GitHub] [superset] codecov-io commented on pull request #12359: fix: explore window replace wrong standalone slice url

codecov-io commented on pull request #12359:
URL: https://github.com/apache/superset/pull/12359#issuecomment-756981906


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12359?src=pr&el=h1) Report
   > Merging [#12359](https://codecov.io/gh/apache/superset/pull/12359?src=pr&el=desc) (a65ef77) into [master](https://codecov.io/gh/apache/superset/commit/d1767b906570d3ec9df5104d2e26c6080a1b2306?el=desc) (d1767b9) will **decrease** coverage by `13.07%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12359/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12359?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #12359       +/-   ##
   ===========================================
   - Coverage   63.89%   50.82%   -13.08%     
   ===========================================
     Files         485      473       -12     
     Lines       29888    16874    -13014     
     Branches        0     4331     +4331     
   ===========================================
   - Hits        19098     8576    -10522     
   + Misses      10790     8298     -2492     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `50.82% <100.00%> (?)` | |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12359?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/superset/pull/12359/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `81.45% <100.00%> (ø)` | |
   | [superset/tasks/alerts/validator.py](https://codecov.io/gh/apache/superset/pull/12359/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL3ZhbGlkYXRvci5weQ==) | | |
   | [...ions/b4a38aa87893\_deprecate\_database\_expression.py](https://codecov.io/gh/apache/superset/pull/12359/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9iNGEzOGFhODc4OTNfZGVwcmVjYXRlX2RhdGFiYXNlX2V4cHJlc3Npb24ucHk=) | | |
   | [...igrations/versions/763d4b211ec9\_fixing\_audit\_fk.py](https://codecov.io/gh/apache/superset/pull/12359/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83NjNkNGIyMTFlYzlfZml4aW5nX2F1ZGl0X2ZrLnB5) | | |
   | [...d6ffdf31bdd4\_add\_published\_column\_to\_dashboards.py](https://codecov.io/gh/apache/superset/pull/12359/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9kNmZmZGYzMWJkZDRfYWRkX3B1Ymxpc2hlZF9jb2x1bW5fdG9fZGFzaGJvYXJkcy5weQ==) | | |
   | [superset/db\_engine\_specs/clickhouse.py](https://codecov.io/gh/apache/superset/pull/12359/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NsaWNraG91c2UucHk=) | | |
   | [superset/charts/commands/data.py](https://codecov.io/gh/apache/superset/pull/12359/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RhdGEucHk=) | | |
   | [...ersions/2929af7925ed\_tz\_offsets\_in\_data\_sources.py](https://codecov.io/gh/apache/superset/pull/12359/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8yOTI5YWY3OTI1ZWRfdHpfb2Zmc2V0c19pbl9kYXRhX3NvdXJjZXMucHk=) | | |
   | [superset/migrations/versions/18dc26817ad2\_.py](https://codecov.io/gh/apache/superset/pull/12359/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8xOGRjMjY4MTdhZDJfLnB5) | | |
   | [superset/migrations/versions/f80a3b88324b\_.py](https://codecov.io/gh/apache/superset/pull/12359/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9mODBhM2I4ODMyNGJfLnB5) | | |
   | ... and [949 more](https://codecov.io/gh/apache/superset/pull/12359/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12359?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12359?src=pr&el=footer). Last update [d1767b9...a65ef77](https://codecov.io/gh/apache/superset/pull/12359?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org