You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mina.apache.org by lg...@apache.org on 2020/09/18 06:14:54 UTC

[mina-sshd] 02/02: [SSHD-1058] Removed some unusued local variables

This is an automated email from the ASF dual-hosted git repository.

lgoldstein pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mina-sshd.git

commit 7deb2adde24b3322b85277fc2a909fa32a8d0120
Author: Lyor Goldstein <lg...@apache.org>
AuthorDate: Thu Sep 17 13:01:42 2020 +0300

    [SSHD-1058] Removed some unusued local variables
---
 .../apache/sshd/common/keyprovider/AbstractResourceKeyPairProvider.java | 1 -
 .../src/main/java/org/apache/sshd/agent/unix/AgentServerProxy.java      | 2 --
 .../src/main/java/org/apache/sshd/common/io/nio2/Nio2Acceptor.java      | 1 -
 .../src/main/java/org/apache/sshd/server/channel/ChannelSession.java    | 1 -
 .../main/java/org/apache/sshd/server/session/AbstractServerSession.java | 1 -
 5 files changed, 6 deletions(-)

diff --git a/sshd-common/src/main/java/org/apache/sshd/common/keyprovider/AbstractResourceKeyPairProvider.java b/sshd-common/src/main/java/org/apache/sshd/common/keyprovider/AbstractResourceKeyPairProvider.java
index 80ccb3f..22f17bc 100644
--- a/sshd-common/src/main/java/org/apache/sshd/common/keyprovider/AbstractResourceKeyPairProvider.java
+++ b/sshd-common/src/main/java/org/apache/sshd/common/keyprovider/AbstractResourceKeyPairProvider.java
@@ -230,7 +230,6 @@ public abstract class AbstractResourceKeyPairProvider<R> extends AbstractKeyPair
                 return true;
             }
 
-            boolean debugEnabled = log.isDebugEnabled();
             while (iterator.hasNext()) {
                 R r = iterator.next();
                 try {
diff --git a/sshd-core/src/main/java/org/apache/sshd/agent/unix/AgentServerProxy.java b/sshd-core/src/main/java/org/apache/sshd/agent/unix/AgentServerProxy.java
index db22c1e..a187f67 100644
--- a/sshd-core/src/main/java/org/apache/sshd/agent/unix/AgentServerProxy.java
+++ b/sshd-core/src/main/java/org/apache/sshd/agent/unix/AgentServerProxy.java
@@ -87,8 +87,6 @@ public class AgentServerProxy extends AbstractLoggingBean implements SshAgentSer
                     : ThreadUtils.noClose(executor);
             piper = pipeService.submit(() -> {
                 try {
-                    boolean debugEnabled = log.isDebugEnabled();
-                    boolean traceEnabled = log.isTraceEnabled();
                     while (isOpen()) {
                         try {
                             long clientSock = Local.accept(handle);
diff --git a/sshd-core/src/main/java/org/apache/sshd/common/io/nio2/Nio2Acceptor.java b/sshd-core/src/main/java/org/apache/sshd/common/io/nio2/Nio2Acceptor.java
index 9b0f1b8..25915a0 100644
--- a/sshd-core/src/main/java/org/apache/sshd/common/io/nio2/Nio2Acceptor.java
+++ b/sshd-core/src/main/java/org/apache/sshd/common/io/nio2/Nio2Acceptor.java
@@ -183,7 +183,6 @@ public class Nio2Acceptor extends Nio2Service implements IoAcceptor {
 
     @Override
     public void unbind(Collection<? extends SocketAddress> addresses) {
-        boolean debugEnabled = log.isDebugEnabled();
         boolean traceEnabled = log.isTraceEnabled();
         for (SocketAddress address : addresses) {
             AsynchronousServerSocketChannel channel = channels.remove(address);
diff --git a/sshd-core/src/main/java/org/apache/sshd/server/channel/ChannelSession.java b/sshd-core/src/main/java/org/apache/sshd/server/channel/ChannelSession.java
index 87402b5..0d05d7a 100644
--- a/sshd-core/src/main/java/org/apache/sshd/server/channel/ChannelSession.java
+++ b/sshd-core/src/main/java/org/apache/sshd/server/channel/ChannelSession.java
@@ -196,7 +196,6 @@ public class ChannelSession extends AbstractServerChannel {
     }
 
     protected void closeImmediately0() {
-        boolean debugEnabled = log.isDebugEnabled();
         if (commandInstance != null) {
             try {
                 commandInstance.destroy(this);
diff --git a/sshd-core/src/main/java/org/apache/sshd/server/session/AbstractServerSession.java b/sshd-core/src/main/java/org/apache/sshd/server/session/AbstractServerSession.java
index f34bf8c..06fcc46 100644
--- a/sshd-core/src/main/java/org/apache/sshd/server/session/AbstractServerSession.java
+++ b/sshd-core/src/main/java/org/apache/sshd/server/session/AbstractServerSession.java
@@ -378,7 +378,6 @@ public abstract class AbstractServerSession extends AbstractSession implements S
                 "Mismatched signatures proposed factory manager");
 
         KeyPairProvider kpp = getKeyPairProvider();
-        boolean debugEnabled = log.isDebugEnabled();
         Collection<String> provided = null;
         try {
             if (kpp != null) {