You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by karensmolermiller <gi...@git.apache.org> on 2017/03/16 16:32:31 UTC
[GitHub] geode-native pull request #59: GEODE-2513 Unbrand Function Execution section...
GitHub user karensmolermiller opened a pull request:
https://github.com/apache/geode-native/pull/59
GEODE-2513 Unbrand Function Execution section of docs
Very minor wording changes.
@davebarnes97 @joeymcallister, along with anyone else who cares to, please review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/karensmolermiller/geode-native feature/GEODE-2513-10
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode-native/pull/59.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #59
----
commit e3834b8fc76889b0401663625a227b86f1685786
Author: Karen Miller <km...@pivotal.io>
Date: 2017-03-16T16:29:13Z
GEODE-2513 Unbrand Function Execution section of docs
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #59: GEODE-2513 Unbrand Function Execution section...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/geode-native/pull/59
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #59: GEODE-2513 Unbrand Function Execution section...
Posted by davebarnes97 <gi...@git.apache.org>.
Github user davebarnes97 commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/59#discussion_r106495072
--- Diff: docs/geode-native-docs/function-execution/handling-function-results.html.md.erb ---
@@ -19,7 +19,7 @@ See the License for the specific language governing permissions and
limitations under the License.
-->
-Geode provides a default result collector. If you need special results handling, code a custom `ResultsCollector` implementation to replace the provided default. Use the `Execution::withCollector` method to define your custom collector.
+There is a default result collector. If you need special results handling, code a custom `ResultsCollector` implementation to replace the provided default. Use the `Execution::withCollector` method to define your custom collector.
--- End diff --
As long as you (@karensmolermiller) are satisfied that no meaning was lost, you have my +1 for this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #59: GEODE-2513 Unbrand Function Execution section...
Posted by echobravopapa <gi...@git.apache.org>.
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/59#discussion_r106471945
--- Diff: docs/geode-native-docs/function-execution/solutions-use-cases.html.md.erb ---
@@ -19,7 +19,7 @@ See the License for the specific language governing permissions and
limitations under the License.
-->
-The function execution service provides solutions for various application use cases.
+The function execution service provides solutions for these application use cases:
--- End diff --
Colon is far superior to the period to precede the list of use cases.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #59: GEODE-2513 Unbrand Function Execution section...
Posted by PivotalSarge <gi...@git.apache.org>.
Github user PivotalSarge commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/59#discussion_r106483611
--- Diff: docs/geode-native-docs/function-execution/handling-function-results.html.md.erb ---
@@ -19,7 +19,7 @@ See the License for the specific language governing permissions and
limitations under the License.
-->
-Geode provides a default result collector. If you need special results handling, code a custom `ResultsCollector` implementation to replace the provided default. Use the `Execution::withCollector` method to define your custom collector.
+There is a default result collector. If you need special results handling, code a custom `ResultsCollector` implementation to replace the provided default. Use the `Execution::withCollector` method to define your custom collector.
--- End diff --
Would it be better to make the default results collector more active, e.g., "The default results collector provides the following functionality..."?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---