You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/11/08 19:25:07 UTC

[GitHub] [pinot] xiangfu0 commented on a change in pull request #7705: follow up with picocli migration

xiangfu0 commented on a change in pull request #7705:
URL: https://github.com/apache/pinot/pull/7705#discussion_r745026799



##########
File path: pinot-tools/src/main/java/org/apache/pinot/tools/segment/converter/DictionaryToRawIndexConverter.java
##########
@@ -262,20 +268,28 @@ private void updateMetadata(File segmentDir, String[] columns, String tableName)
     properties.save();
   }
 
+  @Override

Review comment:
       why need to override those methods here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org