You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "bschuchardt (GitHub)" <gi...@apache.org> on 2020/02/03 19:20:23 UTC
[GitHub] [geode] bschuchardt opened pull request #4668: GEODE-7760:
NPE in Locator during auto-reconnect
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/4668 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] bschuchardt closed pull request #4668: GEODE-7760:
NPE in Locator during auto-reconnect
Posted by "bschuchardt (GitHub)" <gi...@apache.org>.
[ pull request closed by bschuchardt ]
[ Full content available at: https://github.com/apache/geode/pull/4668 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] bschuchardt commented on pull request #4668:
GEODE-7760: NPE in Locator during auto-reconnect
Posted by "bschuchardt (GitHub)" <gi...@apache.org>.
yes, I agree. I'm going to make a pass through InternalLocator and remove the use of the "locator" static wherever possible. These uses all seem to come from cluster-configuration work.
[ Full content available at: https://github.com/apache/geode/pull/4668 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] dschneider-pivotal commented on pull request #4668:
GEODE-7760: NPE in Locator during auto-reconnect
Posted by "dschneider-pivotal (GitHub)" <gi...@apache.org>.
should "currentLocator.internalCache" be changed to "myCache"?
[ Full content available at: https://github.com/apache/geode/pull/4668 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] bschuchardt commented on pull request #4668:
GEODE-7760: NPE in Locator during auto-reconnect
Posted by "bschuchardt (GitHub)" <gi...@apache.org>.
yes. It looks like Aditya Anchuri added that code early in 2019. I'll change it.
[ Full content available at: https://github.com/apache/geode/pull/4668 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] bschuchardt commented on pull request #4668:
GEODE-7760: NPE in Locator during auto-reconnect
Posted by "bschuchardt (GitHub)" <gi...@apache.org>.
this caches the value to ensure that it doesn't go null after this check
[ Full content available at: https://github.com/apache/geode/pull/4668 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] echobravopapa commented on pull request #4668:
GEODE-7760: NPE in Locator during auto-reconnect
Posted by "echobravopapa (GitHub)" <gi...@apache.org>.
don't want to mind-read here, what was the rationale for a local copy?
[ Full content available at: https://github.com/apache/geode/pull/4668 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org