You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@syncope.apache.org by GitBox <gi...@apache.org> on 2020/05/15 09:48:05 UTC

[GitHub] [syncope] andrea-patricelli opened a new pull request #188: [SYNCOPE-1563] Fixed password mangement in user approval form

andrea-patricelli opened a new pull request #188:
URL: https://github.com/apache/syncope/pull/188


   Do not initialize user approval form with the password taken from workflow


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [syncope] ilgrosso commented on a change in pull request #188: [SYNCOPE-1563] Fixed password mangement in user approval form

Posted by GitBox <gi...@apache.org>.
ilgrosso commented on a change in pull request #188:
URL: https://github.com/apache/syncope/pull/188#discussion_r425745228



##########
File path: ext/flowable/client-console/src/main/java/org/apache/syncope/client/console/panels/UserRequestFormDirectoryPanel.java
##########
@@ -226,8 +226,10 @@ public void onClick(final AjaxRequestTarget target, final UserRequestForm ignore
                 UserRequestForm formTO = model.getObject();
                 UserTO newUserTO;
                 UserTO previousUserTO;
-                if (formTO.getUserPatch() == null) {
+                if (formTO.getUserPatch() == null && formTO.getUserTO() != null) {

Review comment:
       Maybe you can move this check right before the line below, e.g.
   
   ```java
   if (newUserTO != null) {
     // SYNCOPE-1563 do not use the password into UserTO
     newUserTO.setPassword(null);
   }
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [syncope] andrea-patricelli merged pull request #188: [SYNCOPE-1563] Fixed password mangement in user approval form

Posted by GitBox <gi...@apache.org>.
andrea-patricelli merged pull request #188:
URL: https://github.com/apache/syncope/pull/188


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org