You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/04/18 00:08:01 UTC

[GitHub] [spark] William1104 commented on a change in pull request #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name

William1104 commented on a change in pull request #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name
URL: https://github.com/apache/spark/pull/24221#discussion_r276477818
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/QueryTest.scala
 ##########
 @@ -205,6 +205,21 @@ abstract class QueryTest extends PlanTest {
         planWithCaching)
   }
 
+  /**
+   * Asserts that a given [[Dataset]] will be executed using the given named cache.
+   */
+  def assertCached(query: Dataset[_], cachedName: String): Unit = {
 
 Review comment:
   Right. Let me make it cover the cache level as well. I am sorry that I will not have Internet access for a week. Will work on it next week. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org