[PR] Helm: Add built-in ServiceMonitor support for PgBouncer and StatsD [airflow]

["dheerenmohta (via GitHub)" <gi...@apache.org>]

dheerenmohta opened a new pull request, #72479:
URL: https://github.com/apache/airflow/pull/72479

   Adds built-in Prometheus `ServiceMonitor` resources for the PgBouncer and StatsD exporter, so Prometheus Operator users no longer need to hand-write their own.
   
   - New `chart/templates/pgbouncer/pgbouncer-servicemonitor.yaml` and `chart/templates/statsd/statsd-servicemonitor.yaml`, pointed at the existing `pgb-metrics` / `statsd-scrape` ports.
   - New `pgbouncer.serviceMonitor` / `statsd.serviceMonitor` values (disabled by default, so there's no hard dependency on the Prometheus Operator CRDs being installed).
   - Vendored the `ServiceMonitor` CRD schema fixture for chart-testing, following the existing pattern used for the KEDA/Gateway API CRDs.
   - New tests in `test_pgbouncer.py` / `test_statsd.py` covering default-disabled, rendering, custom namespace/interval/scrapeTimeout, and additionalLabels.
   
   closes: #28779
   related: #31040, #23223
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code (Sonnet 5)
   
   Generated-by: Claude Code (Sonnet 5) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Helm: Add built-in ServiceMonitor support for PgBouncer and StatsD [airflow]

["dheerenmohta (via GitHub)" <gi...@apache.org>]

dheerenmohta commented on PR #72479:
URL: https://github.com/apache/airflow/pull/72479#issuecomment-5759627002

   Makes sense, thanks for the pointer. Went through `contributing-docs/29_helm_chart_development.rst`'s chart-vs-Kustomize decision criteria: ServiceMonitor support needs the Prometheus Operator CRDs, which the chart doesn't install, and it's an optional/environment-specific concern — that lands squarely under "belongs in Kustomize," not the core chart.
   
   Happy to close this and follow up with an overlay under `chart/kustomize-overlays/`, modeled on the existing `keda`/`kerberos` ones (`kustomization.yaml` + `README.rst` + `STATUS.yaml`). Let me know if that's the right shape, or if there's a reason to hold off given the overlay work is still early.
   
   ---
   Drafted-by: Claude Code (Sonnet 5) (no human review before posting)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org