You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/12/29 15:46:22 UTC

[GitHub] [beam] olehborysevych commented on a diff in pull request #24816: [Playground] Return only Playground examples in GetCatalog()

olehborysevych commented on code in PR #24816:
URL: https://github.com/apache/beam/pull/24816#discussion_r1059023372


##########
playground/backend/internal/db/datastore/datastore_db_test.go:
##########
@@ -439,6 +443,9 @@ func TestDatastore_GetCatalog(t *testing.T) {
 				t.Errorf("GetCatalog() error = %v, wantErr %v", err, tt.wantErr)
 			}
 			if err == nil {
+				if len(catalog) != 1 {

Review Comment:
   @TSultanov  I think I would create a new separate test or table test entry for that and also please ensure that you delete from the datastore emulators (see cleanData func in the test)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org