[jira] [Commented] (HBASE-13454) SecureClient#setupIOStreams should handle all Exception

["Liang Xie (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-13454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14492047#comment-14492047 ] 

Liang Xie commented on HBASE-13454:
-----------------------------------

+1 from me.  And jianwei, you need to ping [~lhofhansl] about 0.94 branch since he is the 0.94 branch RM

> SecureClient#setupIOStreams should handle all Exception
> -------------------------------------------------------
>
>                 Key: HBASE-13454
>                 URL: https://issues.apache.org/jira/browse/HBASE-13454
>             Project: HBase
>          Issue Type: Bug
>          Components: Client, security
>    Affects Versions: 0.94.27
>            Reporter: cuijianwei
>            Assignee: cuijianwei
>         Attachments: HBASE-13454-0.94.patch
>
>
> Similar to [HBASE-9256 | https://issues.apache.org/jira/browse/HBASE-9256], SecureClient#setupIOStreams should also catch up all Exception. In our production environment, an OutOfMemoryError is thrown in SecureClient#setupIOStreams, leaving an unclosed SecureConnection with its inputStream/outputStream still null. Therefore, following calls will be attached to this connection and will encounter NPE in HBaseClient#sendParam:
> {code}
> java.lang.NullPointerException
> at org.apache.hadoop.hbase.ipc.HBaseClient$Connection.sendParam(HBaseClient.java:619)
> at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:977)
> at org.apache.hadoop.hbase.ipc.SecureRpcEngine$Invoker.invoke(SecureRpcEngine.java:107)
> at $Proxy21.replicateLogEntries(Unknown Source)
> at org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.shipEdits(ReplicationSource.java:772)
> at org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.run(ReplicationSource.java:451)
> {code}
> We'd fix this in 0.94.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)