[GitHub] [incubator-doris] qidaye commented on a diff in pull request #8808: [feature](cold-hot) support s3 resource

[GitBox <gi...@apache.org>]

qidaye commented on code in PR #8808:
URL: https://github.com/apache/incubator-doris/pull/8808#discussion_r846551943


##########
fe/fe-core/src/main/java/org/apache/doris/catalog/OdbcCatalogResource.java:
##########
@@ -93,6 +93,29 @@ private void checkProperties(String propertiesKey) throws DdlException {
 
     }
 
+    @Override
+    public void modifyProperties(Map<String, String> properties) throws DdlException {
+        // check properties
+        String host = properties.remove(HOST);
+        String port = properties.remove(PORT);
+        String user = properties.remove(USER);
+        String password = properties.remove(PASSWORD);
+        String type = properties.remove(TYPE);
+        String driver = properties.remove(DRIVER);
+
+        if (!properties.isEmpty()) {
+            throw new DdlException("Unknown ODBC catalog resource: " + properties);

Review Comment:
   Because we have multiple resources, we cannot check all types of resources in the analysis phase, so I put the check in specific resouce.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org